gnucash maint: [html-acct-table] remove dead code

Christopher Lam clam at code.gnucash.org
Thu Feb 11 10:34:24 EST 2021


Updated	 via  https://github.com/Gnucash/gnucash/commit/1b41d517 (commit)
	from  https://github.com/Gnucash/gnucash/commit/14d444fa (commit)



commit 1b41d517d203c0e4794e1400a2f5bad14d39e2c9
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Feb 11 22:33:07 2021 +0800

    [html-acct-table] remove dead code
    
    balance-mode being 'pre-adjusting has never been used in code since
    introduction in 2007 in v2.0.

diff --git a/gnucash/report/html-acct-table.scm b/gnucash/report/html-acct-table.scm
index 43d069311..4c83f39b8 100644
--- a/gnucash/report/html-acct-table.scm
+++ b/gnucash/report/html-acct-table.scm
@@ -227,19 +227,11 @@
 ;;          account having a balance of zero. otherwise, a row will be
 ;;          generated for the account.
 ;; 
-;;     balance-mode: 'pre-adjusting 'pre-closing 'post-closing
+;;     balance-mode: 'pre-closing 'post-closing
 ;;
 ;;          indicates whether or not to ignore adjusting/closing
 ;;          entries when computing account balances. 'pre-closing
-;;          ignores only closing entries. 'pre-adjusting also ignores
-;;          adjusting entries. 'post-closing counts all entries.
-;; 
-;;     adjusting-pattern: alist of 'str 'cased 'regexp
-;; 
-;;          a pattern alist, as accepted by
-;;          gnc:account-get-trans-type-balance-interval, matching
-;;          adjusting transactions to be ignored when balance-mode is
-;;          'pre-adjusting.
+;;          ignores, 'post-closing counts closing entries.
 ;; 
 ;;     closing-pattern: alist of 'str 'cased 'regexp
 ;; 
@@ -631,11 +623,6 @@
 			       (list 'cased #f)
 			       (list 'regexp #f)
 			       (list 'closing #t))))
-	 (adjusting-pattern (or (get-val env 'adjusting-pattern)
-				(list
-				 (list 'str (G_ "Adjusting Entries"))
-				 (list 'cased #f)
-				 (list 'regexp #f))))
 	 (report-budget (or (get-val env 'report-budget) #f))
 	 ;; local variables
 	 (toplvl-accts
@@ -684,13 +671,6 @@
            (merge-splits (gnc:account-get-trans-type-splits-interval
                           accts closing-pattern start-date end-date) #t))
 
-          ;; remove closing and adjusting entries
-          ((pre-adjusting)
-           (merge-splits (gnc:account-get-trans-type-splits-interval
-                          accts closing-pattern start-date end-date) #t)
-           (merge-splits (gnc:account-get-trans-type-splits-interval
-                          accts adjusting-pattern start-date end-date) #t))
-
           (else
            (display "you fail it\n"))))
 



Summary of changes:
 gnucash/report/html-acct-table.scm | 24 ++----------------------
 1 file changed, 2 insertions(+), 22 deletions(-)



More information about the gnucash-changes mailing list