gnucash maint: Bug 798098 - Crash popup show when have 3 Windows in OSX

John Ralls jralls at code.gnucash.org
Mon Jan 25 16:02:15 EST 2021


Updated	 via  https://github.com/Gnucash/gnucash/commit/9583c09f (commit)
	from  https://github.com/Gnucash/gnucash/commit/a754289d (commit)



commit 9583c09f6292d105207d98e611c5327865831546
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Jan 25 13:01:14 2021 -0800

    Bug 798098 - Crash popup show when have 3 Windows in OSX
    
    Don't free things twice, it always ends in tears.

diff --git a/gnucash/gnome-utils/gnc-main-window.c b/gnucash/gnome-utils/gnc-main-window.c
index e41ec8913..7ed6b8dc5 100644
--- a/gnucash/gnome-utils/gnc-main-window.c
+++ b/gnucash/gnome-utils/gnc-main-window.c
@@ -3324,8 +3324,9 @@ gnc_main_window_close_page (GncPluginPage *page)
             gnc_main_window_remove_prefs (window);
 
             gtk_widget_destroy (GTK_WIDGET(window));
+            window = NULL;
         }
-        if (g_list_length (active_windows) > 1)
+        if (window && g_list_length (active_windows) > 1)
         {
             gtk_widget_destroy (GTK_WIDGET(window));
         }



Summary of changes:
 gnucash/gnome-utils/gnc-main-window.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)



More information about the gnucash-changes mailing list