gnucash maint: builder must be g_object_unref'ed

Christopher Lam clam at code.gnucash.org
Thu Jun 3 04:13:10 EDT 2021


Updated	 via  https://github.com/Gnucash/gnucash/commit/9f1c179f (commit)
	from  https://github.com/Gnucash/gnucash/commit/020f9a58 (commit)



commit 9f1c179fca746b5e4624b88f0aff0dd7d2d71cfb
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Jun 3 14:08:25 2021 +0800

    builder must be g_object_unref'ed

diff --git a/gnucash/gnome/dialog-invoice.c b/gnucash/gnome/dialog-invoice.c
index b05760ea3..0606f0d36 100644
--- a/gnucash/gnome/dialog-invoice.c
+++ b/gnucash/gnome/dialog-invoice.c
@@ -635,6 +635,7 @@ gnc_invoice_window_destroy_cb (GtkWidget *widget, gpointer data)
     gtk_widget_destroy(widget);
     gnc_entry_ledger_destroy (iw->ledger);
     gnc_unregister_gui_component (iw->component_id);
+    g_object_unref (G_OBJECT (iw->builder));
     gnc_resume_gui_refresh ();
 
     g_free (iw);
diff --git a/gnucash/gnome/dialog-price-edit-db.c b/gnucash/gnome/dialog-price-edit-db.c
index cd2cea10f..70ef0078f 100644
--- a/gnucash/gnome/dialog-price-edit-db.c
+++ b/gnucash/gnome/dialog-price-edit-db.c
@@ -522,6 +522,7 @@ gnc_prices_dialog_remove_old_clicked (GtkWidget *widget, gpointer data)
     }
     gnc_gui_refresh_all ();
     gtk_widget_destroy (pdb_dialog->remove_dialog);
+    g_object_unref (G_OBJECT (builder));
     LEAVE(" ");
 }
 
diff --git a/gnucash/import-export/customer-import/dialog-customer-import-gui.c b/gnucash/import-export/customer-import/dialog-customer-import-gui.c
index 9de88127b..eba0f033a 100644
--- a/gnucash/import-export/customer-import/dialog-customer-import-gui.c
+++ b/gnucash/import-export/customer-import/dialog-customer-import-gui.c
@@ -153,6 +153,7 @@ gnc_plugin_customer_import_showGUI(GtkWindow *parent)
     /* Setup signals */
     gtk_builder_connect_signals_full (builder, gnc_builder_connect_full_func, gui);
     gtk_widget_show_all ( gui->dialog );
+    g_object_unref (G_OBJECT (builder));
     return gui;
 }
 



Summary of changes:
 gnucash/gnome/dialog-invoice.c                                     | 1 +
 gnucash/gnome/dialog-price-edit-db.c                               | 1 +
 gnucash/import-export/customer-import/dialog-customer-import-gui.c | 1 +
 3 files changed, 3 insertions(+)



More information about the gnucash-changes mailing list