gnucash maint: [dialog-options] Plug memory leak

Christopher Lam clam at code.gnucash.org
Mon Mar 15 10:04:14 EDT 2021


Updated	 via  https://github.com/Gnucash/gnucash/commit/b51d227a (commit)
	from  https://github.com/Gnucash/gnucash/commit/7f1335e6 (commit)



commit b51d227aff62c3f3fee31ecec34cf58240bcb963
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Mar 15 22:03:15 2021 +0800

    [dialog-options] Plug memory leak
    
    37a403144 had leaks.

diff --git a/gnucash/gnome-utils/dialog-options.c b/gnucash/gnome-utils/dialog-options.c
index a743f1826..0c3f04ad0 100644
--- a/gnucash/gnome-utils/dialog-options.c
+++ b/gnucash/gnome-utils/dialog-options.c
@@ -398,10 +398,14 @@ gnc_option_set_ui_value_internal (GNCOption *option, gboolean use_default)
     {
         bad_value = option_def->set_value (option, use_default, widget, value);
         if (bad_value)
-            PERR("option '%s' bad value '%s'\n",
-                 gnc_option_name (option),
-                 scm_to_locale_string (scm_object_to_string
-                                       (value, scm_c_eval_string ("write"))));
+        {
+            gchar *name = gnc_option_name (option);
+            gchar *val = scm_to_locale_string (scm_object_to_string
+                                               (value, scm_c_eval_string ("write")));
+            PERR ("option '%s' bad value '%s'\n", name, val);
+            g_free (name);
+            g_free (val);
+        }
     }
     else
         PERR("Unknown type. Ignoring.\n");



Summary of changes:
 gnucash/gnome-utils/dialog-options.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)



More information about the gnucash-changes mailing list