gnucash maint: gnc_invoice_window_print_invoice return NULL if invoice is NULL.

Christopher Lam clam at code.gnucash.org
Sat Mar 20 11:01:03 EDT 2021


Updated	 via  https://github.com/Gnucash/gnucash/commit/c6c5777c (commit)
	from  https://github.com/Gnucash/gnucash/commit/31a36b2b (commit)



commit c6c5777cf244417b0530387012155a4aba3d04b1
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Mar 20 22:29:16 2021 +0800

    gnc_invoice_window_print_invoice return NULL if invoice is NULL.
    
    d6082e1a6 had triggered macOS's clang failures.

diff --git a/gnucash/gnome/dialog-invoice.c b/gnucash/gnome/dialog-invoice.c
index c443b9535..ceb9bb2d1 100644
--- a/gnucash/gnome/dialog-invoice.c
+++ b/gnucash/gnome/dialog-invoice.c
@@ -796,12 +796,12 @@ gnc_invoice_window_print_invoice(GtkWindow *parent, GncInvoice *invoice)
     const char *reportname = gnc_plugin_business_get_invoice_printreport();
     GncPluginPage *reportPage = NULL;
 
-    g_return_if_fail (invoice);
+    g_return_val_if_fail (invoice, NULL);
     if (!reportname)
         reportname = "5123a759ceb9483abf2182d01c140e8d"; // fallback if the option lookup failed
 
     func = scm_c_eval_string ("gnc:invoice-report-create");
-    g_return_if_fail (scm_is_procedure (func));
+    g_return_val_if_fail (scm_is_procedure (func), NULL);
 
     arg = SWIG_NewPointerObj(invoice, SWIG_TypeQuery("_p__gncInvoice"), 0);
     arg2 = scm_from_utf8_string(reportname);
@@ -810,7 +810,7 @@ gnc_invoice_window_print_invoice(GtkWindow *parent, GncInvoice *invoice)
     /* scm_gc_protect_object(func); */
 
     arg = scm_apply (func, args, SCM_EOL);
-    g_return_if_fail (scm_is_exact (arg));
+    g_return_val_if_fail (scm_is_exact (arg), NULL);
     report_id = scm_to_int (arg);
 
     /* scm_gc_unprotect_object(func); */



Summary of changes:
 gnucash/gnome/dialog-invoice.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)



More information about the gnucash-changes mailing list