gnucash maint: Multiple changes pushed
Christopher Lam
clam at code.gnucash.org
Fri May 28 20:02:13 EDT 2021
Updated via https://github.com/Gnucash/gnucash/commit/292deb0a (commit)
via https://github.com/Gnucash/gnucash/commit/1f281627 (commit)
from https://github.com/Gnucash/gnucash/commit/88f372da (commit)
commit 292deb0a11347d0032a0b7c5b179c5c2eb1b000b
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Fri May 28 22:36:37 2021 +0800
[binreloc.c] free strings
subdir, prefix are not consistently freed.
diff --git a/libgnucash/core-utils/binreloc.c b/libgnucash/core-utils/binreloc.c
index 6227be1e8..557f9d20f 100644
--- a/libgnucash/core-utils/binreloc.c
+++ b/libgnucash/core-utils/binreloc.c
@@ -438,11 +438,18 @@ find_component_directory (const gchar *default_dir, const gchar* compiled_dir)
prefix = gnc_gbr_find_prefix (NULL);
if (prefix == NULL)
+ {
+ g_free (subdir);
return g_strdup (default_dir ? default_dir : compiled_dir);
+ }
if (!g_getenv("GNC_UNINSTALLED"))
{
if (!g_strcmp0 (prefix, PREFIX))
+ {
+ g_free (subdir);
+ g_free (prefix);
return g_strdup (compiled_dir);
+ }
if (g_strcmp0 (compiled_dir, subdir) == 0)
{
commit 1f28162729cedc95c2002000e55559c29bcf0d52
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Fri May 28 22:36:00 2021 +0800
[gnc-tree-view.c] free array of strings
was created with g_strsplit but never freed.
diff --git a/gnucash/gnome-utils/gnc-tree-view.c b/gnucash/gnome-utils/gnc-tree-view.c
index 025b1d69c..37faa5d8e 100644
--- a/gnucash/gnome-utils/gnc-tree-view.c
+++ b/gnucash/gnome-utils/gnc-tree-view.c
@@ -1164,6 +1164,8 @@ void gnc_tree_view_save_state (GncTreeView *view)
else if (g_key_file_has_key (state_file, priv->state_section, STATE_KEY_COLUMN_ORDER, NULL))
g_key_file_remove_key (state_file, priv->state_section, STATE_KEY_COLUMN_ORDER, NULL);
+ g_strfreev (col_order);
+
// ENTER("view %p, wanted %s", view, wanted);
column_list = gtk_tree_view_get_columns (GTK_TREE_VIEW(view));
Summary of changes:
gnucash/gnome-utils/gnc-tree-view.c | 2 ++
libgnucash/core-utils/binreloc.c | 7 +++++++
2 files changed, 9 insertions(+)
More information about the gnucash-changes
mailing list