gnucash maint: Bug 798313 - "File/Import/Import Transactions From CSV" crashes Gnucash.
John Ralls
jralls at code.gnucash.org
Sat Oct 16 19:26:06 EDT 2021
Updated via https://github.com/Gnucash/gnucash/commit/fbf82847 (commit)
from https://github.com/Gnucash/gnucash/commit/09b3ce23 (commit)
commit fbf828476f4c84a9978390e9192ee52878c99eab
Author: John Ralls <jralls at ceridwen.us>
Date: Sat Oct 16 16:20:20 2021 -0700
Bug 798313 - "File/Import/Import Transactions From CSV" crashes Gnucash.
Don't shutdown and re-initialize the expression parser after every parse,
doing so overflows the Guile garbage collector's memory-region array.
It also forces the expression parser to load the user expressions-2.0
for every parse which is extremely expensive.
diff --git a/gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp b/gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp
index 00a16966a..4b3dee706 100644
--- a/gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp
+++ b/gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp
@@ -223,7 +223,6 @@ static GncNumeric parse_price (const std::string &str)
char *endptr;
auto success = gnc_exp_parser_parse (str.c_str(), &val, &endptr);
- gnc_exp_parser_shutdown();
if (!success)
throw std::invalid_argument (_("Price can't be parsed into a number."));
Summary of changes:
gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp | 1 -
1 file changed, 1 deletion(-)
More information about the gnucash-changes
mailing list