gnucash maint: Revert "[split-register-model.c] Hide price==1 for zero-amount splits"

Christopher Lam clam at code.gnucash.org
Mon Jan 10 06:16:30 EST 2022


Updated	 via  https://github.com/Gnucash/gnucash/commit/47f2e82f (commit)
	from  https://github.com/Gnucash/gnucash/commit/088874b1 (commit)



commit 47f2e82f8e802265af218e9c625c93007b512619
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Jan 10 19:12:58 2022 +0800

    Revert "[split-register-model.c] Hide price==1 for zero-amount splits"
    
    This reverts commit 203432c436d504ac86e2b392b39df7aa3aa11eae. It was
    intended as a cosmetic clean up but caused data entry difficulties
    described in bug 798406.

diff --git a/gnucash/register/ledger-core/split-register-model.c b/gnucash/register/ledger-core/split-register-model.c
index c5f955a0a..c2146d4a7 100644
--- a/gnucash/register/ledger-core/split-register-model.c
+++ b/gnucash/register/ledger-core/split-register-model.c
@@ -1389,12 +1389,11 @@ gnc_split_register_get_price_entry (VirtualLocation virt_loc,
 
     split = gnc_split_register_get_split (reg, virt_loc.vcell_loc);
 
-    if (gnc_numeric_zero_p (xaccSplitGetAmount(split)) ||
-        gnc_numeric_zero_p (xaccSplitGetValue(split)))
-        return NULL;
-
     price = xaccSplitGetSharePrice (split);
     curr = xaccTransGetCurrency (xaccSplitGetParent (split));
+    if (gnc_numeric_zero_p (price))
+        return NULL;
+
     return xaccPrintAmount (price, gnc_default_price_print_info (curr));
 }
 



Summary of changes:
 gnucash/register/ledger-core/split-register-model.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)



More information about the gnucash-changes mailing list