gnucash maint: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/4893d0b8 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6fe2028b (commit)
	from  https://github.com/Gnucash/gnucash/commit/59d95a4c (commit)



commit 4893d0b8d8c9ea83704450cea20ea9631c41279d
Merge: 59d95a4ce 6fe2028bc
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Nov 25 12:22:44 2022 -0800

    Merge Marco Scardovi's QofFakeQuery fix into maint.


commit 6fe2028bca49f455b7841d178a712baec8f72919
Author: Marco Scardovi <mscardovi at icloud.com>
Date:   Thu Nov 24 23:20:07 2022 +0100

    Fix test
    
    Signed-off-by: Marco Scardovi <mscardovi at icloud.com>

diff --git a/libgnucash/engine/mocks/fake-qofquery.cpp b/libgnucash/engine/mocks/fake-qofquery.cpp
index 15341189a..a82dadebf 100644
--- a/libgnucash/engine/mocks/fake-qofquery.cpp
+++ b/libgnucash/engine/mocks/fake-qofquery.cpp
@@ -59,8 +59,8 @@ public:
     {
         ASSERT_TRUE(query_used((QofQuery*)query));
         auto it = std::find(m_queriesUsed.begin(), m_queriesUsed.end(), query);
-        m_queriesUsed.erase(it);
         m_queriesConsumed.push_back(*it);
+        m_queriesUsed.erase(it);
     }
 
     /* Remove a formerly added QofFakeQueryObject from the pool */



Summary of changes:
 libgnucash/engine/mocks/fake-qofquery.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)