gnucash-htdocs beta: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Sat Apr 1 15:47:07 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash-htdocs/commit/0218933c (commit)
	 via  https://github.com/Gnucash/gnucash-htdocs/commit/1538a4ab (commit)
	 via  https://github.com/Gnucash/gnucash-htdocs/commit/87f8dc1f (commit)
	 via  https://github.com/Gnucash/gnucash-htdocs/commit/cd0f1892 (commit)
	 via  https://github.com/Gnucash/gnucash-htdocs/commit/7afd5fdd (commit)
	 via  https://github.com/Gnucash/gnucash-htdocs/commit/23f21d1f (commit)
	 via  https://github.com/Gnucash/gnucash-htdocs/commit/aaaf2699 (commit)
	from  https://github.com/Gnucash/gnucash-htdocs/commit/bc83b225 (commit)



commit 0218933cbf7bba3d80bea828152e2281a66d398d
Merge: bc83b22 1538a4a
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat Apr 1 12:46:54 2023 -0700

    Merge branch 'master' into beta


commit 1538a4ab763247972e0151a82dd36e108a90082b
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 31 20:58:48 2023 -0700

    Move primary test out of loop.

diff --git a/externals/gettext.php b/externals/gettext.php
index 5d61269..b09d4a6 100644
--- a/externals/gettext.php
+++ b/externals/gettext.php
@@ -19,7 +19,7 @@
    along with PHP-gettext; if not, write to the Free Software
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
-*/
+ */
 
 /**
  * Provides a simple gettext replacement that works independently from
@@ -34,395 +34,396 @@
  * that you don't want to keep in memory)
  */
 class gettext_reader {
-  //public:
-   var $error = 0; // public variable that holds error code (0 if no error)
-
-   //private:
-  var $BYTEORDER = 0;        // 0: low endian, 1: big endian
-  var $STREAM = NULL;
-  var $short_circuit = false;
-  var $enable_cache = false;
-  var $originals = NULL;      // offset of original table
-  var $translations = NULL;    // offset of translation table
-  var $pluralheader = NULL;    // cache header field for plural forms
-  var $total = 0;          // total string count
-  var $table_originals = NULL;  // table for original strings (offsets)
-  var $table_translations = NULL;  // table for translated strings (offsets)
-  var $cache_translations = NULL;  // original -> translation mapping
-
-
-  /* Methods */
-
-
-  /**
-   * Reads a 32bit Integer from the Stream
-   *
-   * @access private
-   * @return Integer from the Stream
-   */
-  function readint() {
-      if ($this->BYTEORDER == 0) {
-        // low endian
-        $input=unpack('V', $this->STREAM->read(4));
-        return array_shift($input);
-      } else {
-        // big endian
-        $input=unpack('N', $this->STREAM->read(4));
-        return array_shift($input);
-      }
+    //public:
+    var $error = 0; // public variable that holds error code (0 if no error)
+
+    //private:
+    var $BYTEORDER = 0;        // 0: low endian, 1: big endian
+    var $STREAM = NULL;
+    var $short_circuit = false;
+    var $enable_cache = false;
+    var $originals = NULL;      // offset of original table
+    var $translations = NULL;    // offset of translation table
+    var $pluralheader = NULL;    // cache header field for plural forms
+    var $total = 0;          // total string count
+    var $table_originals = NULL;  // table for original strings (offsets)
+    var $table_translations = NULL;  // table for translated strings (offsets)
+    var $cache_translations = NULL;  // original -> translation mapping
+
+
+    /* Methods */
+
+
+    /**
+     * Reads a 32bit Integer from the Stream
+     *
+     * @access private
+     * @return Integer from the Stream
+     */
+    function readint() {
+        if ($this->BYTEORDER == 0) {
+            // low endian
+            $input=unpack('V', $this->STREAM->read(4));
+            return array_shift($input);
+        } else {
+            // big endian
+            $input=unpack('N', $this->STREAM->read(4));
+            return array_shift($input);
+        }
     }
 
-  function read($bytes) {
-    return $this->STREAM->read($bytes);
-  }
-
-  /**
-   * Reads an array of Integers from the Stream
-   *
-   * @param int count How many elements should be read
-   * @return Array of Integers
-   */
-  function readintarray($count) {
-    if ($this->BYTEORDER == 0) {
-        // low endian
-        return unpack('V'.$count, $this->STREAM->read(4 * $count));
-      } else {
-        // big endian
-        return unpack('N'.$count, $this->STREAM->read(4 * $count));
-      }
-  }
-
-  /**
-   * Constructor
-   *
-   * @param object Reader the StreamReader object
-   * @param boolean enable_cache Enable or disable caching of strings (default on)
-   */
-  function gettext_reader($Reader, $enable_cache = true) {
-    // If there isn't a StreamReader, turn on short circuit mode.
-    if (! $Reader || isset($Reader->error) ) {
-      $this->short_circuit = true;
-      return;
+    function read($bytes) {
+        return $this->STREAM->read($bytes);
     }
 
-    // Caching can be turned off
-    $this->enable_cache = $enable_cache;
-
-    $MAGIC1 = "\x95\x04\x12\xde";
-    $MAGIC2 = "\xde\x12\x04\x95";
-
-    $this->STREAM = $Reader;
-    $magic = $this->read(4);
-    if ($magic == $MAGIC1) {
-      $this->BYTEORDER = 1;
-    } elseif ($magic == $MAGIC2) {
-      $this->BYTEORDER = 0;
-    } else {
-      $this->error = 1; // not MO file
-      return false;
+    /**
+     * Reads an array of Integers from the Stream
+     *
+     * @param int count How many elements should be read
+     * @return Array of Integers
+     */
+    function readintarray($count) {
+        if ($this->BYTEORDER == 0) {
+            // low endian
+            return unpack('V'.$count, $this->STREAM->read(4 * $count));
+        } else {
+            // big endian
+            return unpack('N'.$count, $this->STREAM->read(4 * $count));
+        }
     }
 
-    // FIXME: Do we care about revision? We should.
-    $revision = $this->readint();
-
-    $this->total = $this->readint();
-    $this->originals = $this->readint();
-    $this->translations = $this->readint();
-  }
-
-  /**
-   * Loads the translation tables from the MO file into the cache
-   * If caching is enabled, also loads all strings into a cache
-   * to speed up translation lookups
-   *
-   * @access private
-   */
-  function load_tables() {
-    if (is_array($this->cache_translations) &&
-        is_array($this->table_originals) &&
-        is_array($this->table_translations))
-      return;
-
-    /* get original and translations tables */
-      if ($this->table_originals &&
-          !is_array($this->table_originals)) {
-      $this->STREAM->seekto($this->originals);
-      $this->table_originals = $this->readintarray($this->total * 2);
+    /**
+     * Constructor
+     *
+     * @param object Reader the StreamReader object
+     * @param boolean enable_cache Enable or disable caching of strings (default on)
+     */
+    function gettext_reader($Reader, $enable_cache = true) {
+        // If there isn't a StreamReader, turn on short circuit mode.
+        if (! $Reader || isset($Reader->error) ) {
+            $this->short_circuit = true;
+            return;
+        }
+
+        // Caching can be turned off
+        $this->enable_cache = $enable_cache;
+
+        $MAGIC1 = "\x95\x04\x12\xde";
+        $MAGIC2 = "\xde\x12\x04\x95";
+
+        $this->STREAM = $Reader;
+        $magic = $this->read(4);
+        if ($magic == $MAGIC1) {
+            $this->BYTEORDER = 1;
+        } elseif ($magic == $MAGIC2) {
+            $this->BYTEORDER = 0;
+        } else {
+            $this->error = 1; // not MO file
+            return false;
+        }
+
+        // FIXME: Do we care about revision? We should.
+        $revision = $this->readint();
+
+        $this->total = $this->readint();
+        $this->originals = $this->readint();
+        $this->translations = $this->readint();
     }
-      if ($this->table_translations &&
-          !is_array($this->table_translations)) {
-      $this->STREAM->seekto($this->translations);
-      $this->table_translations = $this->readintarray($this->total * 2);
+
+    /**
+     * Loads the translation tables from the MO file into the cache
+     * If caching is enabled, also loads all strings into a cache
+     * to speed up translation lookups
+     *
+     * @access private
+     */
+    function load_tables() {
+        if (is_array($this->cache_translations) &&
+            is_array($this->table_originals) &&
+            is_array($this->table_translations))
+        return;
+
+        /* get original and translations tables */
+        if ($this->table_originals &&
+            !is_array($this->table_originals)) {
+            $this->STREAM->seekto($this->originals);
+            $this->table_originals = $this->readintarray($this->total * 2);
+        }
+        if ($this->table_translations &&
+            !is_array($this->table_translations)) {
+            $this->STREAM->seekto($this->translations);
+            $this->table_translations = $this->readintarray($this->total * 2);
+        }
+
+        if ($this->enable_cache) {
+            $this->cache_translations = array ();
+            /* read all strings in the cache */
+            if ($this && $this->table_originals) {
+                for ($i = 0; $i < $this->total; $i++) {
+                    $offset = $i * 2 + 2;
+                    if (!$this->table_originals[$offset]) {
+                        continue;
+                    }
+                    $this->STREAM->seekto($this->table_originals[$offset]);
+                    $original = $this->STREAM->read($this->table_originals[$offset - 1]);
+                    $this->STREAM->seekto($this->table_translations[$offset]);
+                    $translation = $this->STREAM->read($this->table_translations[$offset - 1]);
+                    $this->cache_translations[$original] = $translation;
+                }
+            }
+        }
     }
 
-    if ($this->enable_cache) {
-      $this->cache_translations = array ();
-      /* read all strings in the cache */
-      for ($i = 0; $i < $this->total; $i++) {
-          $offset = $i * 2 + 2;
-          if (!($this && $this->table_originals &&
-                $this->table_originals[$offset])) {
-              continue;
-          }
-          $this->STREAM->seekto($this->table_originals[$offset]);
-          $original = $this->STREAM->read($this->table_originals[$offset - 1]);
-          $this->STREAM->seekto($this->table_translations[$offset]);
-          $translation = $this->STREAM->read($this->table_translations[$offset - 1]);
-          $this->cache_translations[$original] = $translation;
-      }
+    /**
+     * Returns a string from the "originals" table
+     *
+     * @access private
+     * @param int num Offset number of original string
+     * @return string Requested string if found, otherwise ''
+     */
+    function get_original_string($num) {
+        $length = $this->table_originals[$num * 2 + 1];
+        $offset = $this->table_originals[$num * 2 + 2];
+        if (! $length)
+            return '';
+        $this->STREAM->seekto($offset);
+        $data = $this->STREAM->read($length);
+        return (string)$data;
     }
-  }
-
-  /**
-   * Returns a string from the "originals" table
-   *
-   * @access private
-   * @param int num Offset number of original string
-   * @return string Requested string if found, otherwise ''
-   */
-  function get_original_string($num) {
-    $length = $this->table_originals[$num * 2 + 1];
-    $offset = $this->table_originals[$num * 2 + 2];
-    if (! $length)
-      return '';
-    $this->STREAM->seekto($offset);
-    $data = $this->STREAM->read($length);
-    return (string)$data;
-  }
-
-  /**
-   * Returns a string from the "translations" table
-   *
-   * @access private
-   * @param int num Offset number of original string
-   * @return string Requested string if found, otherwise ''
-   */
-  function get_translation_string($num) {
-    $length = $this->table_translations[$num * 2 + 1];
-    $offset = $this->table_translations[$num * 2 + 2];
-    if (! $length)
-      return '';
-    $this->STREAM->seekto($offset);
-    $data = $this->STREAM->read($length);
-    return (string)$data;
-  }
-
-  /**
-   * Binary search for string
-   *
-   * @access private
-   * @param string string
-   * @param int start (internally used in recursive function)
-   * @param int end (internally used in recursive function)
-   * @return int string number (offset in originals table)
-   */
-  function find_string($string, $start = -1, $end = -1) {
-    if (($start == -1) or ($end == -1)) {
-      // find_string is called with only one parameter, set start end end
-      $start = 0;
-      $end = $this->total;
+
+    /**
+     * Returns a string from the "translations" table
+     *
+     * @access private
+     * @param int num Offset number of original string
+     * @return string Requested string if found, otherwise ''
+     */
+    function get_translation_string($num) {
+        $length = $this->table_translations[$num * 2 + 1];
+        $offset = $this->table_translations[$num * 2 + 2];
+        if (! $length)
+            return '';
+        $this->STREAM->seekto($offset);
+        $data = $this->STREAM->read($length);
+        return (string)$data;
     }
-    if (abs($start - $end) <= 1) {
-      // We're done, now we either found the string, or it doesn't exist
-      $txt = $this->get_original_string($start);
-      if ($string == $txt)
-        return $start;
-      else
-        return -1;
-    } else if ($start > $end) {
-      // start > end -> turn around and start over
-      return $this->find_string($string, $end, $start);
-    } else {
-      // Divide table in two parts
-      $half = (int)(($start + $end) / 2);
-      $cmp = strcmp($string, $this->get_original_string($half));
-      if ($cmp == 0)
-        // string is exactly in the middle => return it
-        return $half;
-      else if ($cmp < 0)
-        // The string is in the upper half
-        return $this->find_string($string, $start, $half);
-      else
-        // The string is in the lower half
-        return $this->find_string($string, $half, $end);
+
+    /**
+     * Binary search for string
+     *
+     * @access private
+     * @param string string
+     * @param int start (internally used in recursive function)
+     * @param int end (internally used in recursive function)
+     * @return int string number (offset in originals table)
+     */
+    function find_string($string, $start = -1, $end = -1) {
+        if (($start == -1) or ($end == -1)) {
+            // find_string is called with only one parameter, set start end end
+            $start = 0;
+            $end = $this->total;
+        }
+        if (abs($start - $end) <= 1) {
+            // We're done, now we either found the string, or it doesn't exist
+            $txt = $this->get_original_string($start);
+            if ($string == $txt)
+                return $start;
+            else
+                return -1;
+        } else if ($start > $end) {
+            // start > end -> turn around and start over
+            return $this->find_string($string, $end, $start);
+        } else {
+            // Divide table in two parts
+            $half = (int)(($start + $end) / 2);
+            $cmp = strcmp($string, $this->get_original_string($half));
+            if ($cmp == 0)
+                // string is exactly in the middle => return it
+                return $half;
+            else if ($cmp < 0)
+                // The string is in the upper half
+                return $this->find_string($string, $start, $half);
+            else
+                // The string is in the lower half
+                return $this->find_string($string, $half, $end);
+        }
     }
-  }
-
-  /**
-   * Translates a string
-   *
-   * @access public
-   * @param string string to be translated
-   * @return string translated string (or original, if not found)
-   */
-  function translate($string) {
-    if ($this->short_circuit)
-      return $string;
-    $this->load_tables();
-
-    if ($this->enable_cache) {
-      // Caching enabled, get translated string from cache
-      if (array_key_exists($string, $this->cache_translations))
-        return $this->cache_translations[$string];
-      else
-        return $string;
-    } else {
-      // Caching not enabled, try to find string
-      $num = $this->find_string($string);
-      if ($num == -1)
-        return $string;
-      else
-        return $this->get_translation_string($num);
+
+    /**
+     * Translates a string
+     *
+     * @access public
+     * @param string string to be translated
+     * @return string translated string (or original, if not found)
+     */
+    function translate($string) {
+        if ($this->short_circuit)
+            return $string;
+        $this->load_tables();
+
+        if ($this->enable_cache) {
+            // Caching enabled, get translated string from cache
+            if (array_key_exists($string, $this->cache_translations))
+                return $this->cache_translations[$string];
+            else
+                return $string;
+        } else {
+            // Caching not enabled, try to find string
+            $num = $this->find_string($string);
+            if ($num == -1)
+                return $string;
+            else
+                return $this->get_translation_string($num);
+        }
     }
-  }
-
-  /**
-   * Sanitize plural form expression for use in PHP eval call.
-   *
-   * @access private
-   * @return string sanitized plural form expression
-   */
-  function sanitize_plural_expression($expr) {
-    // Get rid of disallowed characters.
-    $expr = preg_replace('@[^a-zA-Z0-9_:;\(\)\?\|\&=!<>+*/\%-]@', '', $expr);
-
-    // Add parenthesis for tertiary '?' operator.
-    $expr .= ';';
-    $res = '';
-    $p = 0;
-    for ($i = 0; $i < strlen($expr); $i++) {
-      $ch = $expr[$i];
-      switch ($ch) {
-      case '?':
-        $res .= ' ? (';
-        $p++;
-        break;
-      case ':':
-        $res .= ') : (';
-        break;
-      case ';':
-        $res .= str_repeat( ')', $p) . ';';
+
+    /**
+     * Sanitize plural form expression for use in PHP eval call.
+     *
+     * @access private
+     * @return string sanitized plural form expression
+     */
+    function sanitize_plural_expression($expr) {
+        // Get rid of disallowed characters.
+        $expr = preg_replace('@[^a-zA-Z0-9_:;\(\)\?\|\&=!<>+*/\%-]@', '', $expr);
+
+        // Add parenthesis for tertiary '?' operator.
+        $expr .= ';';
+        $res = '';
         $p = 0;
-        break;
-      default:
-        $res .= $ch;
-      }
+        for ($i = 0; $i < strlen($expr); $i++) {
+            $ch = $expr[$i];
+            switch ($ch) {
+                case '?':
+                    $res .= ' ? (';
+                    $p++;
+                    break;
+                case ':':
+                    $res .= ') : (';
+                    break;
+                case ';':
+                    $res .= str_repeat( ')', $p) . ';';
+                    $p = 0;
+                    break;
+                default:
+                    $res .= $ch;
+            }
+        }
+        return $res;
     }
-    return $res;
-  }
-
-  /**
-   * Parse full PO header and extract only plural forms line.
-   *
-   * @access private
-   * @return string verbatim plural form header field
-   */
-  function extract_plural_forms_header_from_po_header($header) {
-    if (preg_match("/(^|\n)plural-forms: ([^\n]*)\n/i", $header, $regs))
-      $expr = $regs[2];
-    else
-      $expr = "nplurals=2; plural=n == 1 ? 0 : 1;";
-    return $expr;
-  }
-
-  /**
-   * Get possible plural forms from MO header
-   *
-   * @access private
-   * @return string plural form header
-   */
-  function get_plural_forms() {
-    // lets assume message number 0 is header
-    // this is true, right?
-    $this->load_tables();
-
-    // cache header field for plural forms
-    if (! is_string($this->pluralheader)) {
-      if ($this->enable_cache) {
-        $header = $this->cache_translations[""];
-      } else {
-        $header = $this->get_translation_string(0);
-      }
-      $expr = $this->extract_plural_forms_header_from_po_header($header);
-      $this->pluralheader = $this->sanitize_plural_expression($expr);
+
+    /**
+     * Parse full PO header and extract only plural forms line.
+     *
+     * @access private
+     * @return string verbatim plural form header field
+     */
+    function extract_plural_forms_header_from_po_header($header) {
+        if (preg_match("/(^|\n)plural-forms: ([^\n]*)\n/i", $header, $regs))
+            $expr = $regs[2];
+        else
+            $expr = "nplurals=2; plural=n == 1 ? 0 : 1;";
+        return $expr;
+    }
+
+    /**
+     * Get possible plural forms from MO header
+     *
+     * @access private
+     * @return string plural form header
+     */
+    function get_plural_forms() {
+        // lets assume message number 0 is header
+        // this is true, right?
+        $this->load_tables();
+
+        // cache header field for plural forms
+        if (! is_string($this->pluralheader)) {
+            if ($this->enable_cache) {
+                $header = $this->cache_translations[""];
+            } else {
+                $header = $this->get_translation_string(0);
+            }
+            $expr = $this->extract_plural_forms_header_from_po_header($header);
+            $this->pluralheader = $this->sanitize_plural_expression($expr);
+        }
+        return $this->pluralheader;
     }
-    return $this->pluralheader;
-  }
-
-  /**
-   * Detects which plural form to take
-   *
-   * @access private
-   * @param n count
-   * @return int array index of the right plural form
-   */
-  function select_string($n) {
-    $string = $this->get_plural_forms();
-    $string = str_replace('nplurals',"\$total",$string);
-    $string = str_replace("n",$n,$string);
-    $string = str_replace('plural',"\$plural",$string);
-
-    $total = 0;
-    $plural = 0;
-
-    eval("$string");
-    if ($plural >= $total) $plural = $total - 1;
-    return $plural;
-  }
-
-  /**
-   * Plural version of gettext
-   *
-   * @access public
-   * @param string single
-   * @param string plural
-   * @param string number
-   * @return translated plural form
-   */
-  function ngettext($single, $plural, $number) {
-    if ($this->short_circuit) {
-      if ($number != 1)
+
+    /**
+     * Detects which plural form to take
+     *
+     * @access private
+     * @param n count
+     * @return int array index of the right plural form
+     */
+    function select_string($n) {
+        $string = $this->get_plural_forms();
+        $string = str_replace('nplurals',"\$total",$string);
+        $string = str_replace("n",$n,$string);
+        $string = str_replace('plural',"\$plural",$string);
+
+        $total = 0;
+        $plural = 0;
+
+        eval("$string");
+        if ($plural >= $total) $plural = $total - 1;
         return $plural;
-      else
-        return $single;
     }
 
-    // find out the appropriate form
-    $select = $this->select_string($number);
-
-    // this should contains all strings separated by NULLs
-    $key = $single . chr(0) . $plural;
-
-
-    if ($this->enable_cache) {
-      if (! array_key_exists($key, $this->cache_translations)) {
-        return ($number != 1) ? $plural : $single;
-      } else {
-        $result = $this->cache_translations[$key];
-        $list = explode(chr(0), $result);
-        return $list[$select];
-      }
-    } else {
-      $num = $this->find_string($key);
-      if ($num == -1) {
-        return ($number != 1) ? $plural : $single;
-      } else {
-        $result = $this->get_translation_string($num);
-        $list = explode(chr(0), $result);
-        return $list[$select];
-      }
+    /**
+     * Plural version of gettext
+     *
+     * @access public
+     * @param string single
+     * @param string plural
+     * @param string number
+     * @return translated plural form
+     */
+    function ngettext($single, $plural, $number) {
+        if ($this->short_circuit) {
+            if ($number != 1)
+                return $plural;
+            else
+                return $single;
+        }
+
+        // find out the appropriate form
+        $select = $this->select_string($number);
+
+        // this should contains all strings separated by NULLs
+        $key = $single . chr(0) . $plural;
+
+
+        if ($this->enable_cache) {
+            if (! array_key_exists($key, $this->cache_translations)) {
+                return ($number != 1) ? $plural : $single;
+            } else {
+                $result = $this->cache_translations[$key];
+                $list = explode(chr(0), $result);
+                return $list[$select];
+            }
+        } else {
+            $num = $this->find_string($key);
+            if ($num == -1) {
+                return ($number != 1) ? $plural : $single;
+            } else {
+                $result = $this->get_translation_string($num);
+                $list = explode(chr(0), $result);
+                return $list[$select];
+            }
+        }
     }
-  }
 
-  function pgettext($context, $msgid) {
-    $key = $context . chr(4) . $msgid;
-    return $this->translate($key);
-  }
+    function pgettext($context, $msgid) {
+        $key = $context . chr(4) . $msgid;
+        return $this->translate($key);
+    }
 
-  function npgettext($context, $singular, $plural, $number) {
-    $singular = $context . chr(4) . $singular;
-    return $this->ngettext($singular, $plural, $number);
-  }
+    function npgettext($context, $singular, $plural, $number) {
+        $singular = $context . chr(4) . $singular;
+        return $this->ngettext($singular, $plural, $number);
+    }
 }
 
 ?>

commit 87f8dc1f7125488287c15e9462823707d1580dfc
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 31 20:31:21 2023 -0700

    Fix typos

diff --git a/externals/gettext.php b/externals/gettext.php
index 4c937ea..5d61269 100644
--- a/externals/gettext.php
+++ b/externals/gettext.php
@@ -160,7 +160,7 @@ class gettext_reader {
       /* read all strings in the cache */
       for ($i = 0; $i < $this->total; $i++) {
           $offset = $i * 2 + 2;
-          if (!($this && $this->table_oritinals &&
+          if (!($this && $this->table_originals &&
                 $this->table_originals[$offset])) {
               continue;
           }
diff --git a/lang.php b/lang.php
index 8d4896d..3afdc92 100644
--- a/lang.php
+++ b/lang.php
@@ -66,7 +66,7 @@ if ($locale == "") {
     {
         # tolower() => remove space => '-' -> '_'
         # "fr-ch;q=0.3, en, zh-cn;q=0.7" => "fr_ch;q=0.3,en,zh_cn;q=0.7"
-        $accept_language = filter_input(INPUT_SERVER, 'HTTP_ACCEPT_LANGUAGE', FILTER_SANITZE_STRING);
+        $accept_language = filter_input(INPUT_SERVER, 'HTTP_ACCEPT_LANGUAGE', FILTER_SANITIZE_STRING);
         $languages = str_replace('-','_', str_replace(' ', '', strtolower($accept_language)));
         $languages = explode(",", $languages);
         foreach ($languages as $item)

commit cd0f1892ce5f981b9e126d63754a86b89cd5af33
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 31 19:53:42 2023 -0700

    Check intermediate level of indirection (table_originals) for NULL.

diff --git a/externals/gettext.php b/externals/gettext.php
index 633df2b..4c937ea 100644
--- a/externals/gettext.php
+++ b/externals/gettext.php
@@ -160,7 +160,8 @@ class gettext_reader {
       /* read all strings in the cache */
       for ($i = 0; $i < $this->total; $i++) {
           $offset = $i * 2 + 2;
-          if (!($this && $this->table_originals[$offset])) {
+          if (!($this && $this->table_oritinals &&
+                $this->table_originals[$offset])) {
               continue;
           }
           $this->STREAM->seekto($this->table_originals[$offset]);

commit 7afd5fdd499830f8f2775c7ba481c48aef20ccc7
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 31 19:45:46 2023 -0700

    Prevent null references in translations cache.

diff --git a/externals/gettext.php b/externals/gettext.php
index de50b8c..633df2b 100644
--- a/externals/gettext.php
+++ b/externals/gettext.php
@@ -159,11 +159,15 @@ class gettext_reader {
       $this->cache_translations = array ();
       /* read all strings in the cache */
       for ($i = 0; $i < $this->total; $i++) {
-        $this->STREAM->seekto($this->table_originals[$i * 2 + 2]);
-        $original = $this->STREAM->read($this->table_originals[$i * 2 + 1]);
-        $this->STREAM->seekto($this->table_translations[$i * 2 + 2]);
-        $translation = $this->STREAM->read($this->table_translations[$i * 2 + 1]);
-        $this->cache_translations[$original] = $translation;
+          $offset = $i * 2 + 2;
+          if (!($this && $this->table_originals[$offset])) {
+              continue;
+          }
+          $this->STREAM->seekto($this->table_originals[$offset]);
+          $original = $this->STREAM->read($this->table_originals[$offset - 1]);
+          $this->STREAM->seekto($this->table_translations[$offset]);
+          $translation = $this->STREAM->read($this->table_translations[$offset - 1]);
+          $this->cache_translations[$original] = $translation;
       }
     }
   }

commit 23f21d1f7691984f5338d89d9972304a38369b7c
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 31 14:28:44 2023 -0700

    Revert "Update php-gettext to latest Debian patch."
    
    This reverts commit aaaf269954707f346fd45e8cf7b7ac2793d2f24a. It worked
    locally but broke code/website.

diff --git a/externals/gettext.inc b/externals/gettext.inc
index 423eb77..399a0f2 100644
--- a/externals/gettext.inc
+++ b/externals/gettext.inc
@@ -32,6 +32,7 @@ LC_MESSAGES     5
 LC_ALL          6
 */
 
+
 // LC_MESSAGES is not available if php-gettext is not loaded
 // while the other constants are already available from session extension.
 if (!defined('LC_MESSAGES')) {
@@ -167,20 +168,21 @@ function _check_locale_and_function($function=false) {
 function _get_codeset($domain=null) {
     global $text_domains, $default_domain, $LC_CATEGORIES;
     if (!isset($domain)) $domain = $default_domain;
-    return (isset($text_domains[$domain]->codeset))? $text_domains[$domain]->codeset : ini_get('default_charset');
+    return (isset($text_domains[$domain]->codeset))? $text_domains[$domain]->codeset : ini_get('mbstring.internal_encoding');
 }
 
 /**
  * Convert the given string to the encoding set by bind_textdomain_codeset.
  */
 function _encode($text) {
-  $target_encoding = _get_codeset();
-  if (function_exists("mb_detect_encoding")) {
     $source_encoding = mb_detect_encoding($text);
-    if ($source_encoding != $target_encoding)
-      $text = mb_convert_encoding($text, $target_encoding, $source_encoding);
-  }
-  return $text;
+    $target_encoding = _get_codeset();
+    if ($source_encoding != $target_encoding) {
+        return mb_convert_encoding($text, $target_encoding, $source_encoding);
+    }
+    else {
+        return $text;
+    }
 }
 
 
@@ -227,9 +229,7 @@ function _setlocale($category, $locale) {
         }
         // Allow locale to be changed on the go for one translation domain.
         global $text_domains, $default_domain;
-        if (array_key_exists($default_domain, $text_domains)) {
-            unset($text_domains[$default_domain]->l10n);
-        }
+        unset($text_domains[$default_domain]->l10n);
         return $CURRENTLOCALE;
     }
 }
@@ -288,9 +288,9 @@ function __($msgid) {
 /**
  * Plural version of gettext.
  */
-function _ngettext($singular, $plural, $number) {
+function _ngettext($single, $plural, $number) {
     $l10n = _get_reader();
-    return _encode($l10n->ngettext($singular, $plural, $number));
+    return _encode($l10n->ngettext($single, $plural, $number));
 }
 
 /**
@@ -304,9 +304,9 @@ function _dgettext($domain, $msgid) {
 /**
  * Plural version of dgettext.
  */
-function _dngettext($domain, $singular, $plural, $number) {
+function _dngettext($domain, $single, $plural, $number) {
     $l10n = _get_reader($domain);
-    return _encode($l10n->ngettext($singular, $plural, $number));
+    return _encode($l10n->ngettext($single, $plural, $number));
 }
 
 /**
@@ -319,9 +319,9 @@ function _dcgettext($domain, $msgid, $category) {
 /**
  * Plural version of dcgettext.
  */
-function _dcngettext($domain, $singular, $plural, $number, $category) {
+function _dcngettext($domain, $single, $plural, $number, $category) {
     $l10n = _get_reader($domain, $category);
-    return _encode($l10n->ngettext($singular, $plural, $number));
+    return _encode($l10n->ngettext($single, $plural, $number));
 }
 
 /**
@@ -405,29 +405,29 @@ function T_($msgid) {
     if (_check_locale_and_function()) return _($msgid);
     return __($msgid);
 }
-function T_ngettext($singular, $plural, $number) {
+function T_ngettext($single, $plural, $number) {
     if (_check_locale_and_function())
-        return ngettext($singular, $plural, $number);
-    else return _ngettext($singular, $plural, $number);
+        return ngettext($single, $plural, $number);
+    else return _ngettext($single, $plural, $number);
 }
 function T_dgettext($domain, $msgid) {
     if (_check_locale_and_function()) return dgettext($domain, $msgid);
     else return _dgettext($domain, $msgid);
 }
-function T_dngettext($domain, $singular, $plural, $number) {
+function T_dngettext($domain, $single, $plural, $number) {
     if (_check_locale_and_function())
-        return dngettext($domain, $singular, $plural, $number);
-    else return _dngettext($domain, $singular, $plural, $number);
+        return dngettext($domain, $single, $plural, $number);
+    else return _dngettext($domain, $single, $plural, $number);
 }
 function T_dcgettext($domain, $msgid, $category) {
     if (_check_locale_and_function())
         return dcgettext($domain, $msgid, $category);
     else return _dcgettext($domain, $msgid, $category);
 }
-function T_dcngettext($domain, $singular, $plural, $number, $category) {
+function T_dcngettext($domain, $single, $plural, $number, $category) {
     if (_check_locale_and_function())
-      return dcngettext($domain, $singular, $plural, $number, $category);
-    else return _dcngettext($domain, $singular, $plural, $number, $category);
+      return dcngettext($domain, $single, $plural, $number, $category);
+    else return _dcngettext($domain, $single, $plural, $number, $category);
 }
 
 function T_pgettext($context, $msgid) {
@@ -451,27 +451,26 @@ function T_dcpgettext($domain, $context, $msgid, $category) {
       return _dcpgettext($domain, $context, $msgid, $category);
 }
 
-function T_npgettext($context, $singular, $plural, $number) {
+function T_npgettext($context, $singular, $plural) {
     if (_check_locale_and_function('npgettext'))
-        return npgettext($context, $singular, $plural, $number);
+        return npgettext($context, $single, $plural, $number);
     else
-        return _npgettext($context, $singular, $plural, $number);
+        return _npgettext($context, $single, $plural, $number);
 }
 
-function T_dnpgettext($domain, $context, $singular, $plural, $number) {
+function T_dnpgettext($domain, $context, $singular, $plural) {
   if (_check_locale_and_function('dnpgettext'))
-      return dnpgettext($domain, $context, $singular, $plural, $number);
+      return dnpgettext($domain, $context, $single, $plural, $number);
   else
-      return _dnpgettext($domain, $context, $singular, $plural, $number);
+      return _dnpgettext($domain, $context, $single, $plural, $number);
 }
 
-function T_dcnpgettext($domain, $context, $singular, $plural,
-                       $number, $category) {
+function T_dcnpgettext($domain, $context, $singular, $plural, $category) {
     if (_check_locale_and_function('dcnpgettext'))
-        return dcnpgettext($domain, $context, $singular,
+        return dcnpgettext($domain, $context, $single,
                            $plural, $number, $category);
     else
-        return _dcnpgettext($domain, $context, $singular,
+        return _dcnpgettext($domain, $context, $single,
                             $plural, $number, $category);
 }
 
@@ -495,39 +494,39 @@ if (!function_exists('gettext')) {
     function _($msgid) {
         return __($msgid);
     }
-    function ngettext($singular, $plural, $number) {
-        return _ngettext($singular, $plural, $number);
+    function ngettext($single, $plural, $number) {
+        return _ngettext($single, $plural, $number);
     }
     function dgettext($domain, $msgid) {
         return _dgettext($domain, $msgid);
     }
-    function dngettext($domain, $singular, $plural, $number) {
-        return _dngettext($domain, $singular, $plural, $number);
+    function dngettext($domain, $single, $plural, $number) {
+        return _dngettext($domain, $single, $plural, $number);
     }
     function dcgettext($domain, $msgid, $category) {
         return _dcgettext($domain, $msgid, $category);
     }
-    function dcngettext($domain, $singular, $plural, $number, $category) {
-        return _dcngettext($domain, $singular, $plural, $number, $category);
+    function dcngettext($domain, $single, $plural, $number, $category) {
+        return _dcngettext($domain, $single, $plural, $number, $category);
     }
     function pgettext($context, $msgid) {
         return _pgettext($context, $msgid);
     }
-    function npgettext($context, $singular, $plural, $number) {
-        return _npgettext($context, $singular, $plural, $number);
+    function npgettext($context, $single, $plural, $number) {
+        return _npgettext($context, $single, $plural, $number);
     }
     function dpgettext($domain, $context, $msgid) {
         return _dpgettext($domain, $context, $msgid);
     }
-    function dnpgettext($domain, $context, $singular, $plural, $number) {
-        return _dnpgettext($domain, $context, $singular, $plural, $number);
+    function dnpgettext($domain, $context, $single, $plural, $number) {
+        return _dnpgettext($domain, $context, $single, $plural, $number);
     }
     function dcpgettext($domain, $context, $msgid, $category) {
         return _dcpgettext($domain, $context, $msgid, $category);
     }
-    function dcnpgettext($domain, $context, $singular, $plural,
+    function dcnpgettext($domain, $context, $single, $plural,
                          $number, $category) {
-      return _dcnpgettext($domain, $context, $singular, $plural,
+      return _dcnpgettext($domain, $context, $single, $plural,
                           $number, $category);
     }
 }
diff --git a/externals/gettext.php b/externals/gettext.php
index 295d4b0..de50b8c 100644
--- a/externals/gettext.php
+++ b/externals/gettext.php
@@ -21,8 +21,6 @@
 
 */
 
-require('plurals.php');
-
 /**
  * Provides a simple gettext replacement that works independently from
  * the system's gettext abilities.
@@ -100,7 +98,7 @@ class gettext_reader {
    * @param object Reader the StreamReader object
    * @param boolean enable_cache Enable or disable caching of strings (default on)
    */
-  function __construct($Reader, $enable_cache = true) {
+  function gettext_reader($Reader, $enable_cache = true) {
     // If there isn't a StreamReader, turn on short circuit mode.
     if (! $Reader || isset($Reader->error) ) {
       $this->short_circuit = true;
@@ -141,16 +139,18 @@ class gettext_reader {
    */
   function load_tables() {
     if (is_array($this->cache_translations) &&
-      is_array($this->table_originals) &&
-      is_array($this->table_translations))
+        is_array($this->table_originals) &&
+        is_array($this->table_translations))
       return;
 
     /* get original and translations tables */
-    if (!is_array($this->table_originals)) {
+      if ($this->table_originals &&
+          !is_array($this->table_originals)) {
       $this->STREAM->seekto($this->originals);
       $this->table_originals = $this->readintarray($this->total * 2);
     }
-    if (!is_array($this->table_translations)) {
+      if ($this->table_translations &&
+          !is_array($this->table_translations)) {
       $this->STREAM->seekto($this->translations);
       $this->table_translations = $this->readintarray($this->total * 2);
     }
@@ -271,6 +271,41 @@ class gettext_reader {
     }
   }
 
+  /**
+   * Sanitize plural form expression for use in PHP eval call.
+   *
+   * @access private
+   * @return string sanitized plural form expression
+   */
+  function sanitize_plural_expression($expr) {
+    // Get rid of disallowed characters.
+    $expr = preg_replace('@[^a-zA-Z0-9_:;\(\)\?\|\&=!<>+*/\%-]@', '', $expr);
+
+    // Add parenthesis for tertiary '?' operator.
+    $expr .= ';';
+    $res = '';
+    $p = 0;
+    for ($i = 0; $i < strlen($expr); $i++) {
+      $ch = $expr[$i];
+      switch ($ch) {
+      case '?':
+        $res .= ' ? (';
+        $p++;
+        break;
+      case ':':
+        $res .= ') : (';
+        break;
+      case ';':
+        $res .= str_repeat( ')', $p) . ';';
+        $p = 0;
+        break;
+      default:
+        $res .= $ch;
+      }
+    }
+    return $res;
+  }
+
   /**
    * Parse full PO header and extract only plural forms line.
    *
@@ -297,14 +332,14 @@ class gettext_reader {
     $this->load_tables();
 
     // cache header field for plural forms
-    if ($this->pluralheader === NULL) {
+    if (! is_string($this->pluralheader)) {
       if ($this->enable_cache) {
         $header = $this->cache_translations[""];
       } else {
         $header = $this->get_translation_string(0);
       }
       $expr = $this->extract_plural_forms_header_from_po_header($header);
-      $this->pluralheader = new PluralHeader($expr);
+      $this->pluralheader = $this->sanitize_plural_expression($expr);
     }
     return $this->pluralheader;
   }
@@ -317,16 +352,16 @@ class gettext_reader {
    * @return int array index of the right plural form
    */
   function select_string($n) {
-    if (!is_int($n)) {
-      throw new InvalidArgumentException(
-        "Select_string only accepts integers: " . $n);
-    }
-    $plural_header = $this->get_plural_forms();
-    $plural = $plural_header->expression->evaluate($n);
+    $string = $this->get_plural_forms();
+    $string = str_replace('nplurals',"\$total",$string);
+    $string = str_replace("n",$n,$string);
+    $string = str_replace('plural',"\$plural",$string);
 
-    if ($plural < 0) $plural = 0;
-    if ($plural >= $plural_header->total) $plural = $plural_header->total - 1;
+    $total = 0;
+    $plural = 0;
 
+    eval("$string");
+    if ($plural >= $total) $plural = $total - 1;
     return $plural;
   }
 
@@ -376,23 +411,12 @@ class gettext_reader {
 
   function pgettext($context, $msgid) {
     $key = $context . chr(4) . $msgid;
-    $ret = $this->translate($key);
-    if (strpos($ret, "\004") !== FALSE) {
-      return $msgid;
-    } else {
-      return $ret;
-    }
+    return $this->translate($key);
   }
 
   function npgettext($context, $singular, $plural, $number) {
-    $key = $context . chr(4) . $singular;
-    $ret = $this->ngettext($key, $plural, $number);
-    if (strpos($ret, "\004") !== FALSE) {
-      return $singular;
-    } else {
-      return $ret;
-    }
-
+    $singular = $context . chr(4) . $singular;
+    return $this->ngettext($singular, $plural, $number);
   }
 }
 
diff --git a/externals/streams.php b/externals/streams.php
index 00cf6cc..3cdc158 100644
--- a/externals/streams.php
+++ b/externals/streams.php
@@ -49,7 +49,7 @@ class StringReader {
   var $_pos;
   var $_str;
 
-  function __construct($str='') {
+  function StringReader($str='') {
     $this->_str = $str;
     $this->_pos = 0;
   }
@@ -86,7 +86,7 @@ class FileReader {
   var $_fd;
   var $_length;
 
-  function __construct($filename) {
+  function FileReader($filename) {
     if (file_exists($filename)) {
 
       $this->_length=filesize($filename);
@@ -143,7 +143,7 @@ class FileReader {
 // Preloads entire file in memory first, then creates a StringReader
 // over it (it assumes knowledge of StringReader internals)
 class CachedFileReader extends StringReader {
-  function __construct($filename) {
+  function CachedFileReader($filename) {
     if (file_exists($filename)) {
 
       $length=filesize($filename);

commit aaaf269954707f346fd45e8cf7b7ac2793d2f24a
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 31 14:18:58 2023 -0700

    Update php-gettext to latest Debian patch.
    
    Fixes CVE-2016-6175, among other things.

diff --git a/externals/gettext.inc b/externals/gettext.inc
index 399a0f2..423eb77 100644
--- a/externals/gettext.inc
+++ b/externals/gettext.inc
@@ -32,7 +32,6 @@ LC_MESSAGES     5
 LC_ALL          6
 */
 
-
 // LC_MESSAGES is not available if php-gettext is not loaded
 // while the other constants are already available from session extension.
 if (!defined('LC_MESSAGES')) {
@@ -168,21 +167,20 @@ function _check_locale_and_function($function=false) {
 function _get_codeset($domain=null) {
     global $text_domains, $default_domain, $LC_CATEGORIES;
     if (!isset($domain)) $domain = $default_domain;
-    return (isset($text_domains[$domain]->codeset))? $text_domains[$domain]->codeset : ini_get('mbstring.internal_encoding');
+    return (isset($text_domains[$domain]->codeset))? $text_domains[$domain]->codeset : ini_get('default_charset');
 }
 
 /**
  * Convert the given string to the encoding set by bind_textdomain_codeset.
  */
 function _encode($text) {
+  $target_encoding = _get_codeset();
+  if (function_exists("mb_detect_encoding")) {
     $source_encoding = mb_detect_encoding($text);
-    $target_encoding = _get_codeset();
-    if ($source_encoding != $target_encoding) {
-        return mb_convert_encoding($text, $target_encoding, $source_encoding);
-    }
-    else {
-        return $text;
-    }
+    if ($source_encoding != $target_encoding)
+      $text = mb_convert_encoding($text, $target_encoding, $source_encoding);
+  }
+  return $text;
 }
 
 
@@ -229,7 +227,9 @@ function _setlocale($category, $locale) {
         }
         // Allow locale to be changed on the go for one translation domain.
         global $text_domains, $default_domain;
-        unset($text_domains[$default_domain]->l10n);
+        if (array_key_exists($default_domain, $text_domains)) {
+            unset($text_domains[$default_domain]->l10n);
+        }
         return $CURRENTLOCALE;
     }
 }
@@ -288,9 +288,9 @@ function __($msgid) {
 /**
  * Plural version of gettext.
  */
-function _ngettext($single, $plural, $number) {
+function _ngettext($singular, $plural, $number) {
     $l10n = _get_reader();
-    return _encode($l10n->ngettext($single, $plural, $number));
+    return _encode($l10n->ngettext($singular, $plural, $number));
 }
 
 /**
@@ -304,9 +304,9 @@ function _dgettext($domain, $msgid) {
 /**
  * Plural version of dgettext.
  */
-function _dngettext($domain, $single, $plural, $number) {
+function _dngettext($domain, $singular, $plural, $number) {
     $l10n = _get_reader($domain);
-    return _encode($l10n->ngettext($single, $plural, $number));
+    return _encode($l10n->ngettext($singular, $plural, $number));
 }
 
 /**
@@ -319,9 +319,9 @@ function _dcgettext($domain, $msgid, $category) {
 /**
  * Plural version of dcgettext.
  */
-function _dcngettext($domain, $single, $plural, $number, $category) {
+function _dcngettext($domain, $singular, $plural, $number, $category) {
     $l10n = _get_reader($domain, $category);
-    return _encode($l10n->ngettext($single, $plural, $number));
+    return _encode($l10n->ngettext($singular, $plural, $number));
 }
 
 /**
@@ -405,29 +405,29 @@ function T_($msgid) {
     if (_check_locale_and_function()) return _($msgid);
     return __($msgid);
 }
-function T_ngettext($single, $plural, $number) {
+function T_ngettext($singular, $plural, $number) {
     if (_check_locale_and_function())
-        return ngettext($single, $plural, $number);
-    else return _ngettext($single, $plural, $number);
+        return ngettext($singular, $plural, $number);
+    else return _ngettext($singular, $plural, $number);
 }
 function T_dgettext($domain, $msgid) {
     if (_check_locale_and_function()) return dgettext($domain, $msgid);
     else return _dgettext($domain, $msgid);
 }
-function T_dngettext($domain, $single, $plural, $number) {
+function T_dngettext($domain, $singular, $plural, $number) {
     if (_check_locale_and_function())
-        return dngettext($domain, $single, $plural, $number);
-    else return _dngettext($domain, $single, $plural, $number);
+        return dngettext($domain, $singular, $plural, $number);
+    else return _dngettext($domain, $singular, $plural, $number);
 }
 function T_dcgettext($domain, $msgid, $category) {
     if (_check_locale_and_function())
         return dcgettext($domain, $msgid, $category);
     else return _dcgettext($domain, $msgid, $category);
 }
-function T_dcngettext($domain, $single, $plural, $number, $category) {
+function T_dcngettext($domain, $singular, $plural, $number, $category) {
     if (_check_locale_and_function())
-      return dcngettext($domain, $single, $plural, $number, $category);
-    else return _dcngettext($domain, $single, $plural, $number, $category);
+      return dcngettext($domain, $singular, $plural, $number, $category);
+    else return _dcngettext($domain, $singular, $plural, $number, $category);
 }
 
 function T_pgettext($context, $msgid) {
@@ -451,26 +451,27 @@ function T_dcpgettext($domain, $context, $msgid, $category) {
       return _dcpgettext($domain, $context, $msgid, $category);
 }
 
-function T_npgettext($context, $singular, $plural) {
+function T_npgettext($context, $singular, $plural, $number) {
     if (_check_locale_and_function('npgettext'))
-        return npgettext($context, $single, $plural, $number);
+        return npgettext($context, $singular, $plural, $number);
     else
-        return _npgettext($context, $single, $plural, $number);
+        return _npgettext($context, $singular, $plural, $number);
 }
 
-function T_dnpgettext($domain, $context, $singular, $plural) {
+function T_dnpgettext($domain, $context, $singular, $plural, $number) {
   if (_check_locale_and_function('dnpgettext'))
-      return dnpgettext($domain, $context, $single, $plural, $number);
+      return dnpgettext($domain, $context, $singular, $plural, $number);
   else
-      return _dnpgettext($domain, $context, $single, $plural, $number);
+      return _dnpgettext($domain, $context, $singular, $plural, $number);
 }
 
-function T_dcnpgettext($domain, $context, $singular, $plural, $category) {
+function T_dcnpgettext($domain, $context, $singular, $plural,
+                       $number, $category) {
     if (_check_locale_and_function('dcnpgettext'))
-        return dcnpgettext($domain, $context, $single,
+        return dcnpgettext($domain, $context, $singular,
                            $plural, $number, $category);
     else
-        return _dcnpgettext($domain, $context, $single,
+        return _dcnpgettext($domain, $context, $singular,
                             $plural, $number, $category);
 }
 
@@ -494,39 +495,39 @@ if (!function_exists('gettext')) {
     function _($msgid) {
         return __($msgid);
     }
-    function ngettext($single, $plural, $number) {
-        return _ngettext($single, $plural, $number);
+    function ngettext($singular, $plural, $number) {
+        return _ngettext($singular, $plural, $number);
     }
     function dgettext($domain, $msgid) {
         return _dgettext($domain, $msgid);
     }
-    function dngettext($domain, $single, $plural, $number) {
-        return _dngettext($domain, $single, $plural, $number);
+    function dngettext($domain, $singular, $plural, $number) {
+        return _dngettext($domain, $singular, $plural, $number);
     }
     function dcgettext($domain, $msgid, $category) {
         return _dcgettext($domain, $msgid, $category);
     }
-    function dcngettext($domain, $single, $plural, $number, $category) {
-        return _dcngettext($domain, $single, $plural, $number, $category);
+    function dcngettext($domain, $singular, $plural, $number, $category) {
+        return _dcngettext($domain, $singular, $plural, $number, $category);
     }
     function pgettext($context, $msgid) {
         return _pgettext($context, $msgid);
     }
-    function npgettext($context, $single, $plural, $number) {
-        return _npgettext($context, $single, $plural, $number);
+    function npgettext($context, $singular, $plural, $number) {
+        return _npgettext($context, $singular, $plural, $number);
     }
     function dpgettext($domain, $context, $msgid) {
         return _dpgettext($domain, $context, $msgid);
     }
-    function dnpgettext($domain, $context, $single, $plural, $number) {
-        return _dnpgettext($domain, $context, $single, $plural, $number);
+    function dnpgettext($domain, $context, $singular, $plural, $number) {
+        return _dnpgettext($domain, $context, $singular, $plural, $number);
     }
     function dcpgettext($domain, $context, $msgid, $category) {
         return _dcpgettext($domain, $context, $msgid, $category);
     }
-    function dcnpgettext($domain, $context, $single, $plural,
+    function dcnpgettext($domain, $context, $singular, $plural,
                          $number, $category) {
-      return _dcnpgettext($domain, $context, $single, $plural,
+      return _dcnpgettext($domain, $context, $singular, $plural,
                           $number, $category);
     }
 }
diff --git a/externals/gettext.php b/externals/gettext.php
index de50b8c..295d4b0 100644
--- a/externals/gettext.php
+++ b/externals/gettext.php
@@ -21,6 +21,8 @@
 
 */
 
+require('plurals.php');
+
 /**
  * Provides a simple gettext replacement that works independently from
  * the system's gettext abilities.
@@ -98,7 +100,7 @@ class gettext_reader {
    * @param object Reader the StreamReader object
    * @param boolean enable_cache Enable or disable caching of strings (default on)
    */
-  function gettext_reader($Reader, $enable_cache = true) {
+  function __construct($Reader, $enable_cache = true) {
     // If there isn't a StreamReader, turn on short circuit mode.
     if (! $Reader || isset($Reader->error) ) {
       $this->short_circuit = true;
@@ -139,18 +141,16 @@ class gettext_reader {
    */
   function load_tables() {
     if (is_array($this->cache_translations) &&
-        is_array($this->table_originals) &&
-        is_array($this->table_translations))
+      is_array($this->table_originals) &&
+      is_array($this->table_translations))
       return;
 
     /* get original and translations tables */
-      if ($this->table_originals &&
-          !is_array($this->table_originals)) {
+    if (!is_array($this->table_originals)) {
       $this->STREAM->seekto($this->originals);
       $this->table_originals = $this->readintarray($this->total * 2);
     }
-      if ($this->table_translations &&
-          !is_array($this->table_translations)) {
+    if (!is_array($this->table_translations)) {
       $this->STREAM->seekto($this->translations);
       $this->table_translations = $this->readintarray($this->total * 2);
     }
@@ -271,41 +271,6 @@ class gettext_reader {
     }
   }
 
-  /**
-   * Sanitize plural form expression for use in PHP eval call.
-   *
-   * @access private
-   * @return string sanitized plural form expression
-   */
-  function sanitize_plural_expression($expr) {
-    // Get rid of disallowed characters.
-    $expr = preg_replace('@[^a-zA-Z0-9_:;\(\)\?\|\&=!<>+*/\%-]@', '', $expr);
-
-    // Add parenthesis for tertiary '?' operator.
-    $expr .= ';';
-    $res = '';
-    $p = 0;
-    for ($i = 0; $i < strlen($expr); $i++) {
-      $ch = $expr[$i];
-      switch ($ch) {
-      case '?':
-        $res .= ' ? (';
-        $p++;
-        break;
-      case ':':
-        $res .= ') : (';
-        break;
-      case ';':
-        $res .= str_repeat( ')', $p) . ';';
-        $p = 0;
-        break;
-      default:
-        $res .= $ch;
-      }
-    }
-    return $res;
-  }
-
   /**
    * Parse full PO header and extract only plural forms line.
    *
@@ -332,14 +297,14 @@ class gettext_reader {
     $this->load_tables();
 
     // cache header field for plural forms
-    if (! is_string($this->pluralheader)) {
+    if ($this->pluralheader === NULL) {
       if ($this->enable_cache) {
         $header = $this->cache_translations[""];
       } else {
         $header = $this->get_translation_string(0);
       }
       $expr = $this->extract_plural_forms_header_from_po_header($header);
-      $this->pluralheader = $this->sanitize_plural_expression($expr);
+      $this->pluralheader = new PluralHeader($expr);
     }
     return $this->pluralheader;
   }
@@ -352,16 +317,16 @@ class gettext_reader {
    * @return int array index of the right plural form
    */
   function select_string($n) {
-    $string = $this->get_plural_forms();
-    $string = str_replace('nplurals',"\$total",$string);
-    $string = str_replace("n",$n,$string);
-    $string = str_replace('plural',"\$plural",$string);
+    if (!is_int($n)) {
+      throw new InvalidArgumentException(
+        "Select_string only accepts integers: " . $n);
+    }
+    $plural_header = $this->get_plural_forms();
+    $plural = $plural_header->expression->evaluate($n);
 
-    $total = 0;
-    $plural = 0;
+    if ($plural < 0) $plural = 0;
+    if ($plural >= $plural_header->total) $plural = $plural_header->total - 1;
 
-    eval("$string");
-    if ($plural >= $total) $plural = $total - 1;
     return $plural;
   }
 
@@ -411,12 +376,23 @@ class gettext_reader {
 
   function pgettext($context, $msgid) {
     $key = $context . chr(4) . $msgid;
-    return $this->translate($key);
+    $ret = $this->translate($key);
+    if (strpos($ret, "\004") !== FALSE) {
+      return $msgid;
+    } else {
+      return $ret;
+    }
   }
 
   function npgettext($context, $singular, $plural, $number) {
-    $singular = $context . chr(4) . $singular;
-    return $this->ngettext($singular, $plural, $number);
+    $key = $context . chr(4) . $singular;
+    $ret = $this->ngettext($key, $plural, $number);
+    if (strpos($ret, "\004") !== FALSE) {
+      return $singular;
+    } else {
+      return $ret;
+    }
+
   }
 }
 
diff --git a/externals/streams.php b/externals/streams.php
index 3cdc158..00cf6cc 100644
--- a/externals/streams.php
+++ b/externals/streams.php
@@ -49,7 +49,7 @@ class StringReader {
   var $_pos;
   var $_str;
 
-  function StringReader($str='') {
+  function __construct($str='') {
     $this->_str = $str;
     $this->_pos = 0;
   }
@@ -86,7 +86,7 @@ class FileReader {
   var $_fd;
   var $_length;
 
-  function FileReader($filename) {
+  function __construct($filename) {
     if (file_exists($filename)) {
 
       $this->_length=filesize($filename);
@@ -143,7 +143,7 @@ class FileReader {
 // Preloads entire file in memory first, then creates a StringReader
 // over it (it assumes knowledge of StringReader internals)
 class CachedFileReader extends StringReader {
-  function CachedFileReader($filename) {
+  function __construct($filename) {
     if (file_exists($filename)) {
 
       $length=filesize($filename);



Summary of changes:
 externals/gettext.php | 732 +++++++++++++++++++++++++-------------------------
 lang.php              |   2 +-
 2 files changed, 370 insertions(+), 364 deletions(-)



More information about the gnucash-changes mailing list