gnucash stable: Multiple changes pushed

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/273c961f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3a7d9549 (commit)
	from  https://github.com/Gnucash/gnucash/commit/921bdc49 (commit)



commit 273c961fc4d2b531e74af17605866bc59c80978c
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Dec 11 13:50:32 2023 -0800

    Add gnc-quote-source.cpp to POTFILES.in
    
    Even though it doesn't have any translatable strings just to stop
    git from whining about it.

diff --git a/po/POTFILES.in b/po/POTFILES.in
index b7db89bca1..fd26edc008 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -656,6 +656,7 @@ libgnucash/engine/gnc-option-impl.cpp
 libgnucash/engine/gncOrder.c
 libgnucash/engine/gncOwner.c
 libgnucash/engine/gnc-pricedb.cpp
+libgnucash/engine/gnc-quote-source.cpp
 libgnucash/engine/gnc-rational.cpp
 libgnucash/engine/gnc-session.c
 libgnucash/engine/gncTaxTable.c

commit 3a7d9549348c4b678824874b696db9a3f6b0c4c1
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Dec 11 13:42:07 2023 -0800

    Bug 799130 - split-register.c:1847:gnc_split_register_save:...
    
    assertion failed: (xaccTransIsOpen (blank_trans))
    
    Don't override the save cancelation if the pending_trans is the blank_trans.

diff --git a/gnucash/register/ledger-core/split-register-control.c b/gnucash/register/ledger-core/split-register-control.c
index 09b0c89b0c..324764c8f0 100644
--- a/gnucash/register/ledger-core/split-register-control.c
+++ b/gnucash/register/ledger-core/split-register-control.c
@@ -39,6 +39,7 @@
 #include "split-register-control.h"
 #include "split-register-model-save.h"
 #include "split-register-p.h"
+#include "split-register.h"
 #include "table-allgui.h"
 #include "engine-helpers.h"
 
@@ -448,6 +449,10 @@ gnc_split_register_move_cursor (VirtualLocation *p_new_virt_loc,
     saved = gnc_split_register_save (reg, old_trans != new_trans);
     pending_trans = xaccTransLookup (&info->pending_trans_guid,
                                      gnc_get_current_book ());
+    Split* blank_split = xaccSplitLookup (&info->blank_split_guid,
+                                          gnc_get_current_book ());
+    Transaction* blank_trans = xaccSplitGetParent (blank_split);
+
     if ((old_class == CURSOR_CLASS_SPLIT) &&
             old_split &&
             (old_split != new_split) &&
@@ -471,6 +476,7 @@ gnc_split_register_move_cursor (VirtualLocation *p_new_virt_loc,
     }
     else if ((pending_trans != NULL)      &&
              (pending_trans == old_trans) &&
+             (pending_trans != blank_trans) &&
              (old_trans != new_trans))
     {
         if (gnc_split_register_balance_trans (reg, pending_trans))



Summary of changes:
 gnucash/register/ledger-core/split-register-control.c | 6 ++++++
 po/POTFILES.in                                        | 1 +
 2 files changed, 7 insertions(+)