gnucash master: Multiple changes pushed

John Ralls jralls at code.gnucash.org
Tue Jan 24 15:09:11 EST 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/f6919e60 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/705ad0f0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6927535a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/925fcbc3 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e83c9105 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/47491eea (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d6ac56ce (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3360a6d1 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/a81b72f0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/19bbde70 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/d1b84fae (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c16bde1a (commit)
	 via  https://github.com/Gnucash/gnucash/commit/5a490d9f (commit)
	from  https://github.com/Gnucash/gnucash/commit/046e4a15 (commit)



commit f6919e60a7920d77f6bd74cc36d8b588c5f9a235
Merge: 705ad0f04 6927535a0
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Jan 24 12:05:47 2023 -0800

    Merge Richard Cohen's 'cleanup' into master.

diff --cc gnucash/gnucash.cpp
index d3fea5b31,ba5116fc0..b0b78871f
--- a/gnucash/gnucash.cpp
+++ b/gnucash/gnucash.cpp
@@@ -279,8 -305,24 +279,8 @@@ Gnucash::Gnucash::start ([[maybe_unused
  {
      Gnucash::CoreApp::start();
  
 -    // Test for the deprecated add-price-quotes option and run it
 -    // Will be removed in 5.0
 -    if (m_add_quotes)
 -    {
 -        std::cerr << _("The '--add-price-quotes' option to gnucash has been deprecated and will be removed in GnuCash 5.0. "
 -                       "Please use 'gnucash-cli --quotes get <datafile>' instead.") << "\n";
 -        if (!m_file_to_load || m_file_to_load->empty())
 -        {
 -            std::cerr << _("Missing data file parameter") << "\n\n"
 -            << *m_opt_desc_display.get();
 -            return 1;
 -        }
 -        else
 -            return add_quotes (m_file_to_load);
 -    }
 -
      /* Now the module files are looked up, which might cause some library
-      initialization to be run, hence gtk must be initialized b*eforehand. */
+      initialization to be run, hence gtk must be initialized beforehand. */
      gnc_module_system_init();
  
      gnc_gui_init();
diff --cc libgnucash/engine/qofobject.cpp
index ab803e299,781cc1210..fed5ee58f
--- a/libgnucash/engine/qofobject.cpp
+++ b/libgnucash/engine/qofobject.cpp
@@@ -40,20 -40,18 +40,13 @@@ static GList *book_list = NULL
   * They should be removed when no longer needed
   */
  
 -#ifdef __cplusplus
  extern "C"
  {
 -#endif
  
- gboolean get_object_is_initialized( void );
  GList* get_object_modules( void );
  GList* get_book_list( void );
 -
 -#ifdef __cplusplus
  }
 -#endif
  
- gboolean
- get_object_is_initialized( void )
- {
-     return object_is_initialized;
- }
- 
  GList*
  get_object_modules( void )
  {
diff --cc libgnucash/engine/test/test-qofobject.c
index 0016cc62e,7706ce416..893f1234e
--- a/libgnucash/engine/test/test-qofobject.c
+++ b/libgnucash/engine/test/test-qofobject.c
@@@ -77,7 -85,11 +77,6 @@@ new_object( QofIdType e_type, const cha
      return object;
  }
  
- extern gboolean get_object_is_initialized( void );
 -#ifdef __cplusplus
 -extern "C"
 -{
 -#endif
 -
  extern GList* get_object_modules( void );
  extern GList* get_book_list( void );
  

commit 705ad0f046e70245695733947b71f28e4933da96
Merge: 046e4a156 3360a6d13
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Jan 24 11:49:37 2023 -0800

    Merge Richard Cohen's 'remove-extra-semicolons' into master.


commit 6927535a0a420df745778c03ad1b9949944c2589
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Jan 24 13:36:37 2023 +0000

    Remove unused test function get_object_is_initialized in qofobject.cpp

diff --git a/libgnucash/engine/qofobject.cpp b/libgnucash/engine/qofobject.cpp
index 0138aad15..781cc1210 100644
--- a/libgnucash/engine/qofobject.cpp
+++ b/libgnucash/engine/qofobject.cpp
@@ -45,7 +45,6 @@ extern "C"
 {
 #endif
 
-gboolean get_object_is_initialized( void );
 GList* get_object_modules( void );
 GList* get_book_list( void );
 
@@ -53,12 +52,6 @@ GList* get_book_list( void );
 }
 #endif
 
-gboolean
-get_object_is_initialized( void )
-{
-    return object_is_initialized;
-}
-
 GList*
 get_object_modules( void )
 {
diff --git a/libgnucash/engine/test/test-qofobject.c b/libgnucash/engine/test/test-qofobject.c
index fae5bc843..7706ce416 100644
--- a/libgnucash/engine/test/test-qofobject.c
+++ b/libgnucash/engine/test/test-qofobject.c
@@ -90,7 +90,6 @@ extern "C"
 {
 #endif
 
-extern gboolean get_object_is_initialized( void );
 extern GList* get_object_modules( void );
 extern GList* get_book_list( void );
 

commit 925fcbc3fdf7c0f32e7f307cdcebd8bd1e985a95
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Jan 24 13:36:23 2023 +0000

    Remove unused gnc-jalali.{c,h}

diff --git a/libgnucash/core-utils/CMakeLists.txt b/libgnucash/core-utils/CMakeLists.txt
index d2ceff6a9..7d7b8653d 100644
--- a/libgnucash/core-utils/CMakeLists.txt
+++ b/libgnucash/core-utils/CMakeLists.txt
@@ -11,7 +11,6 @@ set (core_utils_SOURCES
   gnc-filepath-utils.cpp
   gnc-gkeyfile-utils.c
   gnc-glib-utils.c
-  gnc-jalali.c
   gnc-locale-utils.c
   gnc-locale-utils.cpp
   gnc-path.c
@@ -29,7 +28,6 @@ set(core_utils_noinst_HEADERS
   gnc-filepath-utils.h
   gnc-gkeyfile-utils.h
   gnc-glib-utils.h
-  gnc-jalali.h
   gnc-locale-utils.h
   gnc-locale-utils.hpp
   gnc-path.h
diff --git a/libgnucash/core-utils/gnc-jalali.c b/libgnucash/core-utils/gnc-jalali.c
deleted file mode 100644
index 2cd85dd16..000000000
--- a/libgnucash/core-utils/gnc-jalali.c
+++ /dev/null
@@ -1,196 +0,0 @@
-/* This file is part of:
- *    Jalali, a Gregorian to Jalali and inverse date converter
- * Copyright (C) 2001  Roozbeh Pournader <roozbeh at sharif.edu>
- * Copyright (C) 2001  Mohammad Toossi <mohammad at bamdad.org>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You can receive a copy of GNU Lesser General Public License at the
- * World Wide Web address <https://www.gnu.org/licenses/lgpl.html>.
- *
- * For licensing issues, contact The FarsiWeb Project Group,
- * Computing Center, Sharif University of Technology,
- * PO Box 11365-8515, Tehran, Iran, or contact us the
- * email address <FWPG at sharif.edu>.
- */
-
-/* Changes:
- *
- * 2005-Sep-06:
- *      General cleanup  --Behdad Esfahbod
- *
- * 2001-Sep-21:
- *	Fixed a bug with "30 Esfand" dates, reported by Mahmoud Ghandi
- *
- * 2001-Sep-20:
- *	First LGPL release, with both sides of conversions
- */
-
-
-#include "gnc-jalali.h"
-
-
-/* implementation */
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <glib.h>
-
-int g_days_in_month[12] = {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};
-int j_days_in_month[12] = {31, 31, 31, 31, 31, 31, 30, 30, 30, 30, 30, 29};
-const char *j_month_name[12] =
-{
-    "Farvardin", "Ordibehesht", "Khordad",
-    "Tir", "Mordad", "Shahrivar",
-    "Mehr", "Aban", "Azar",
-    "Dey", "Bahman", "Esfand"
-};
-
-int gnc_jalali_days_in_month(int month_index)
-{
-    g_assert(month_index < 12);
-    return j_days_in_month[month_index];
-}
-
-const char* gnc_jalali_month_name(int month_index)
-{
-    g_assert(month_index < 12);
-    return j_month_name[month_index];
-}
-
-void gnc_gregorian_to_jalali(int *j_y, int *j_m, int *j_d,
-                             int  g_y, int  g_m, int  g_d)
-{
-    int gy, gm, gd;
-    int jy, jm, jd;
-    long g_day_no, j_day_no;
-    int j_np;
-
-    int i;
-
-    gy = g_y - 1600;
-    gm = g_m - 1;
-    gd = g_d - 1;
-
-    g_day_no = 365 * gy + (gy + 3) / 4 - (gy + 99) / 100 + (gy + 399) / 400;
-    for (i = 0; i < gm; ++i)
-        g_day_no += g_days_in_month[i];
-    if (gm > 1 && ((gy % 4 == 0 && gy % 100 != 0) || (gy % 400 == 0)))
-        /* leap and after Feb */
-        ++g_day_no;
-    g_day_no += gd;
-
-    j_day_no = g_day_no - 79;
-
-    j_np = j_day_no / 12053;
-    j_day_no %= 12053;
-
-    jy = 979 + 33 * j_np + 4 * (j_day_no / 1461);
-    j_day_no %= 1461;
-
-    if (j_day_no >= 366)
-    {
-        jy += (j_day_no - 1) / 365;
-        j_day_no = (j_day_no - 1) % 365;
-    }
-
-    for (i = 0; i < 11 && j_day_no >= j_days_in_month[i]; ++i)
-    {
-        j_day_no -= j_days_in_month[i];
-    }
-    jm = i + 1;
-    jd = j_day_no + 1;
-    *j_y = jy;
-    *j_m = jm;
-    *j_d = jd;
-}
-
-void gnc_jalali_to_gregorian(int *g_y, int *g_m, int *g_d,
-                             int  j_y, int  j_m, int  j_d)
-{
-    int gy, gm, gd;
-    int jy, jm, jd;
-    long g_day_no, j_day_no;
-    int leap;
-
-    int i;
-
-    jy = j_y - 979;
-    jm = j_m - 1;
-    jd = j_d - 1;
-
-    j_day_no = 365 * jy + (jy / 33) * 8 + (jy % 33 + 3) / 4;
-    for (i = 0; i < jm; ++i)
-        j_day_no += j_days_in_month[i];
-
-    j_day_no += jd;
-
-    g_day_no = j_day_no + 79;
-
-    gy = 1600 + 400 * (g_day_no / 146097); /* 146097 = 365*400 + 400/4 - 400/100 + 400/400 */
-    g_day_no = g_day_no % 146097;
-
-    leap = 1;
-    if (g_day_no >= 36525) /* 36525 = 365*100 + 100/4 */
-    {
-        g_day_no--;
-        gy += 100 * (g_day_no / 36524); /* 36524 = 365*100 + 100/4 - 100/100 */
-        g_day_no = g_day_no % 36524;
-
-        if (g_day_no >= 365)
-            g_day_no++;
-        else
-            leap = 0;
-    }
-
-    gy += 4 * (g_day_no / 1461); /* 1461 = 365*4 + 4/4 */
-    g_day_no %= 1461;
-
-    if (g_day_no >= 366)
-    {
-        leap = 0;
-
-        g_day_no--;
-        gy += g_day_no / 365;
-        g_day_no = g_day_no % 365;
-    }
-
-    for (i = 0; g_day_no >= g_days_in_month[i] + (i == 1 && leap); i++)
-        g_day_no -= g_days_in_month[i] + (i == 1 && leap);
-    gm = i + 1;
-    gd = g_day_no + 1;
-
-    *g_y = gy;
-    *g_m = gm;
-    *g_d = gd;
-}
-
-#if 0
-int
-main(void)
-{
-    int y, m, d;
-    time64 bin_time;
-    struct tm br_time;
-
-    gnc_time (&bin_time);
-    gnc_localtime_r (&bin_time, &br_time);
-
-    gregorian_to_jalali(&y, &m, &d,
-                        1900 + br_time.tm_year,
-                        1 + br_time.tm_mon,
-                        br_time.tm_mday);
-
-    printf("Current Jalali date: %d %s %d\n", d, j_month_name[m-1], y);
-
-    return 0;
-}
-#endif
diff --git a/libgnucash/core-utils/gnc-jalali.h b/libgnucash/core-utils/gnc-jalali.h
deleted file mode 100644
index 48841c121..000000000
--- a/libgnucash/core-utils/gnc-jalali.h
+++ /dev/null
@@ -1,46 +0,0 @@
-/*
- * jalali.h
- * Copyright (C) 2010 Christian Stimming
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, contact:
- *
- * Free Software Foundation           Voice:  +1-617-542-5942
- * 51 Franklin Street, Fifth Floor    Fax:    +1-617-542-2652
- * Boston, MA  02110-1301,  USA       gnu at gnu.org
- */
-
-#ifndef GNC_JALALI_H
-#define GNC_JALALI_H
-
-/** Convert gregorian year/month/day (arguments 4-6) to jalali
- * year/month/day (arguments 1-3) */
-void gnc_gregorian_to_jalali(/* output */ int *j_y, int *j_m, int *j_d,
-        /*  input */ int  g_y, int  g_m, int  g_d);
-
-/** Convert jalali year/month/day (arguments 4-6) to gregorian
- * year/month/day (arguments 1-3) */
-void gnc_jalali_to_gregorian(/* output */ int *g_y, int *g_m, int *g_d,
-        /*  input */ int  j_y, int  j_m, int  j_d);
-
-/** Returns the number of days in month in the Jalali calendar, which
- * is different from the Gregorian one. Argument month_index is 0 for
- * the first month. */
-int gnc_jalali_days_in_month(int month_index);
-
-/** Returns the month name of the Jalali calendar. Argument
- * month_index is 0 for the first month. */
-const char* gnc_jalali_month_name(int month_index);
-
-
-#endif
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 51de233da..3fef79e99 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -615,7 +615,6 @@ libgnucash/core-utils/gnc-environment.c
 libgnucash/core-utils/gnc-filepath-utils.cpp
 libgnucash/core-utils/gnc-gkeyfile-utils.c
 libgnucash/core-utils/gnc-glib-utils.c
-libgnucash/core-utils/gnc-jalali.c
 libgnucash/core-utils/gnc-locale-utils.c
 libgnucash/core-utils/gnc-locale-utils.cpp
 libgnucash/core-utils/gnc-path.c

commit e83c91050c1082c1c2af0bb130b7fd2db06e98b1
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Jan 24 13:36:02 2023 +0000

    Remove unneeded dummy.cpp

diff --git a/libgnucash/engine/test/CMakeLists.txt b/libgnucash/engine/test/CMakeLists.txt
index b1ff56f96..14513d91b 100644
--- a/libgnucash/engine/test/CMakeLists.txt
+++ b/libgnucash/engine/test/CMakeLists.txt
@@ -204,7 +204,6 @@ gnc_add_test(test-qofevent "${test_qofevent_SOURCES}"
 
 
 set(test_engine_SOURCES_DIST
-        dummy.cpp
         gtest-gnc-euro.cpp
         gtest-gnc-int128.cpp
         gtest-gnc-rational.cpp
diff --git a/libgnucash/engine/test/dummy.cpp b/libgnucash/engine/test/dummy.cpp
deleted file mode 100644
index 78752143e..000000000
--- a/libgnucash/engine/test/dummy.cpp
+++ /dev/null
@@ -1,2 +0,0 @@
-// This is a dummy source file since we need a C++ file in test_engine so
-// it will be linked as a C++ program.

commit 47491eeaa5780e0b800eac1e842acd1cb8597e75
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Jan 24 13:35:46 2023 +0000

    Update old-style function definition for my_strtok()

diff --git a/gnucash/import-export/log-replay/gnc-log-replay.c b/gnucash/import-export/log-replay/gnc-log-replay.c
index 0d44e144c..f40e287d3 100644
--- a/gnucash/import-export/log-replay/gnc-log-replay.c
+++ b/gnucash/import-export/log-replay/gnc-log-replay.c
@@ -109,9 +109,7 @@ static char *olds;
    returning a 0 length valid string between two consecutive ocurence of delim.
    It will also return a 0 length string instead of NULL when it reaches the end of s
 */
-static char * my_strtok (s, delim)
-char *s;
-const char *delim;
+static char * my_strtok (char *s, const char *delim)
 {
     char *token;
     /*DEBUG("strtok(): Start...");*/

commit d6ac56ce5f7e50f3d52af2d8f6188b0866dea315
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Jan 24 13:35:22 2023 +0000

    Re-enable -Waddress - gncInvoiceLookup etc. are now inline functions, not macros
    
    - Remove outdated comments

diff --git a/bindings/business-core.i b/bindings/business-core.i
index af1349235..8c7eff8d8 100644
--- a/bindings/business-core.i
+++ b/bindings/business-core.i
@@ -18,19 +18,6 @@
  *                                                                  *
 \********************************************************************/
 
-#if defined(SWIGGUILE)
-%{
-/* Disable -Waddress.  GCC 4.2 warns (and fails to compile with -Werror) when
- * passing the address of a guid on the stack to QOF_BOOK_LOOKUP_ENTITY via
- * gncInvoiceLookup and friends.  When the macro gets inlined, the compiler
- * emits a warning that the guid null pointer test is always true.
- */
-#if (__GNUC__ >= 4 && __GNUC_MINOR__ >= 2)
-#    pragma GCC diagnostic warning "-Waddress"
-#endif
-%}
-#endif
-
 %rename(gncOwnerReturnGUID) gncOwnerRetGUID;
 
 %inline %{
diff --git a/gnucash/gnome/business-urls.c b/gnucash/gnome/business-urls.c
index 3e585267f..8868eb9eb 100644
--- a/gnucash/gnome/business-urls.c
+++ b/gnucash/gnome/business-urls.c
@@ -45,15 +45,6 @@
 #include "dialog-invoice.h"
 #include "dialog-job.h"
 
-/* Disable -Waddress.  GCC 4.2 warns (and fails to compile with -Werror) when
- * passing the address of a guid on the stack to QOF_BOOK_LOOKUP_ENTITY via
- * gncInvoiceLookup and friends.  When the macro gets inlined, the compiler
- * emits a warning that the guid null pointer test is always true.
- */
-#if (__GNUC__ >= 4 && __GNUC_MINOR__ >= 2)
-#    pragma GCC diagnostic warning "-Waddress"
-#endif
-
 #define HANDLE_TYPE(URL_TYPE_STR,OBJ_TYPE) {                                 \
   QofBook *book;                                                             \
   GncGUID guid;                                                                 \
diff --git a/gnucash/gnome/dialog-invoice.c b/gnucash/gnome/dialog-invoice.c
index 8307cec9f..e72e5f5b4 100644
--- a/gnucash/gnome/dialog-invoice.c
+++ b/gnucash/gnome/dialog-invoice.c
@@ -80,15 +80,6 @@
 #include "dialog-transfer.h"
 #include "gnc-uri-utils.h"
 
-/* Disable -Waddress.  GCC 4.2 warns (and fails to compile with -Werror) when
- * passing the address of a guid on the stack to QOF_BOOK_LOOKUP_ENTITY via
- * gncInvoiceLookup and friends.  When the macro gets inlined, the compiler
- * emits a warning that the guid null pointer test is always true.
- */
-#if (__GNUC__ >= 4 && __GNUC_MINOR__ >= 2)
-#    pragma GCC diagnostic warning "-Waddress"
-#endif
-
 #define DIALOG_NEW_INVOICE_CM_CLASS "dialog-new-invoice"
 #define DIALOG_VIEW_INVOICE_CM_CLASS "dialog-view-invoice"
 
diff --git a/libgnucash/engine/gncBillTerm.h b/libgnucash/engine/gncBillTerm.h
index 724679cc7..34c180354 100644
--- a/libgnucash/engine/gncBillTerm.h
+++ b/libgnucash/engine/gncBillTerm.h
@@ -115,8 +115,6 @@ void gncBillTermSetCutoff (GncBillTerm *term, gint cutoff);
 /** Return a pointer to the instance gncBillTerm that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncBillTerm * gncBillTermLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncBillTerm * gncBillTermLookup (const QofBook *book, const GncGUID *guid)
 {
diff --git a/libgnucash/engine/gncCustomer.h b/libgnucash/engine/gncCustomer.h
index 58ca70b1d..ec9704079 100644
--- a/libgnucash/engine/gncCustomer.h
+++ b/libgnucash/engine/gncCustomer.h
@@ -112,8 +112,6 @@ void gncCustomerRemoveJob (GncCustomer *customer, GncJob *job);
 /** Return a pointer to the instance gncCustomer that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncCustomer * gncCustomerLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncCustomer * gncCustomerLookup (const QofBook *book, const GncGUID *guid)
 {
diff --git a/libgnucash/engine/gncEmployee.h b/libgnucash/engine/gncEmployee.h
index 901123b62..98bdd8d43 100644
--- a/libgnucash/engine/gncEmployee.h
+++ b/libgnucash/engine/gncEmployee.h
@@ -108,8 +108,6 @@ Account * gncEmployeeGetCCard (const GncEmployee *employee);
 /** Return a pointer to the instance gncEmployee that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncEmployee * gncEmployeeLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncEmployee * gncEmployeeLookup (const QofBook *book, const GncGUID *guid)
 {
diff --git a/libgnucash/engine/gncEntry.h b/libgnucash/engine/gncEntry.h
index bdb4c1212..ee818283c 100644
--- a/libgnucash/engine/gncEntry.h
+++ b/libgnucash/engine/gncEntry.h
@@ -290,8 +290,6 @@ GncInvoice * gncEntryGetBill (const GncEntry *entry);
 /** Return a pointer to the instance gncEntry that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncEntry * gncEntryLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncEntry * gncEntryLookup (const QofBook *book, const GncGUID *guid)
 {
diff --git a/libgnucash/engine/gncInvoice.h b/libgnucash/engine/gncInvoice.h
index 43cb1865b..fcc471df8 100644
--- a/libgnucash/engine/gncInvoice.h
+++ b/libgnucash/engine/gncInvoice.h
@@ -268,8 +268,6 @@ GncInvoice * gncInvoiceGetInvoiceFromLot (GNCLot *lot);
 /** Return a pointer to the instance gncInvoice that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncInvoice * gncInvoiceLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncInvoice * gncInvoiceLookup (const QofBook *book, const GncGUID *guid)
 {
diff --git a/libgnucash/engine/gncJob.h b/libgnucash/engine/gncJob.h
index b40cdbcab..d200cdf11 100644
--- a/libgnucash/engine/gncJob.h
+++ b/libgnucash/engine/gncJob.h
@@ -89,8 +89,6 @@ gboolean     gncJobGetActive (const GncJob *job);
 /** Return a pointer to the instance gncJob that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncJob * gncJobLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncJob * gncJobLookup (const QofBook *book, const GncGUID *guid)
 {
diff --git a/libgnucash/engine/gncOrder.h b/libgnucash/engine/gncOrder.h
index 7e7796964..769d7ec2b 100644
--- a/libgnucash/engine/gncOrder.h
+++ b/libgnucash/engine/gncOrder.h
@@ -98,8 +98,6 @@ gboolean gncOrderIsClosed (const GncOrder *order);
 /** Return a pointer to the instance gncOrder that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncOrder * gncOrderLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncOrder * gncOrderLookup (const QofBook *book, const GncGUID *guid)
 {
diff --git a/libgnucash/engine/gncTaxTable.h b/libgnucash/engine/gncTaxTable.h
index 4ec0dafb2..a479b85e0 100644
--- a/libgnucash/engine/gncTaxTable.h
+++ b/libgnucash/engine/gncTaxTable.h
@@ -142,8 +142,6 @@ gboolean gncTaxTableEqual(const GncTaxTable *a, const GncTaxTable *b);
 /** Return a pointer to the instance gncTaxTable that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncTaxTable * gncTaxTableLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncTaxTable *gncTaxTableLookup (const QofBook* book, const GncGUID *guid)
 {
diff --git a/libgnucash/engine/gncVendor.h b/libgnucash/engine/gncVendor.h
index 3bcdf6272..718c0b851 100644
--- a/libgnucash/engine/gncVendor.h
+++ b/libgnucash/engine/gncVendor.h
@@ -108,8 +108,6 @@ int gncVendorCompare (const GncVendor *a, const GncVendor *b);
 /** Return a pointer to the instance gncVendor that is identified
  *  by the guid, and is residing in the book. Returns NULL if the
  *  instance can't be found.
- *  Equivalent function prototype is
- *  GncVendor * gncVendorLookup (QofBook *book, const GncGUID *guid);
  */
 static inline GncVendor * gncVendorLookup (const QofBook *book, const GncGUID *guid)
 {

commit 3360a6d13b1ee2a49f44592a64e910b90535e75d
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Tue Jan 24 13:22:18 2023 +0000

    Remove extra semicolons
    
    Courtesy of gcc -pedantic

diff --git a/gnucash/gnome/assistant-stock-transaction.cpp b/gnucash/gnome/assistant-stock-transaction.cpp
index 248240cbd..bae896aba 100644
--- a/gnucash/gnome/assistant-stock-transaction.cpp
+++ b/gnucash/gnome/assistant-stock-transaction.cpp
@@ -913,7 +913,7 @@ stock_assistant_prepare (GtkAssistant  *assistant, GtkWidget *page,
 
     switch (currentpage)
     {
-    case PAGE_TRANSACTION_TYPE:;
+    case PAGE_TRANSACTION_TYPE:
         // initialize transaction types.
         gnc_numeric balance;
         time64 date;
diff --git a/gnucash/gnome/dialog-invoice.h b/gnucash/gnome/dialog-invoice.h
index 6130bf37e..660ae858b 100644
--- a/gnucash/gnome/dialog-invoice.h
+++ b/gnucash/gnome/dialog-invoice.h
@@ -76,7 +76,7 @@ void gnc_invoice_window_sort (InvoiceWindow *iw, invoice_sort_type_t sort_code);
 
 GtkWidget * gnc_invoice_window_create_summary_bar (InvoiceWindow *iw);
 
-void gnc_invoice_window_changed (InvoiceWindow *iw, GtkWidget *window);;
+void gnc_invoice_window_changed (InvoiceWindow *iw, GtkWidget *window);
 
 gchar *gnc_invoice_get_help (InvoiceWindow *iw);
 
diff --git a/gnucash/gnome/search-owner.c b/gnucash/gnome/search-owner.c
index e8bce2a4e..60baddebb 100644
--- a/gnucash/gnome/search-owner.c
+++ b/gnucash/gnome/search-owner.c
@@ -57,7 +57,7 @@ typedef struct _GNCSearchOwnerPrivate
     GtkWidget * owner_choice;
 } GNCSearchOwnerPrivate;
 
-G_DEFINE_TYPE_WITH_PRIVATE(GNCSearchOwner, gnc_search_owner, GNC_TYPE_SEARCH_CORE_TYPE);
+G_DEFINE_TYPE_WITH_PRIVATE(GNCSearchOwner, gnc_search_owner, GNC_TYPE_SEARCH_CORE_TYPE)
 
 #define _PRIVATE(o)  \
    ((GNCSearchOwnerPrivate*)gnc_search_owner_get_instance_private((GNCSearchOwner*)o))
diff --git a/gnucash/import-export/bi-import/gnc-plugin-bi-import.c b/gnucash/import-export/bi-import/gnc-plugin-bi-import.c
index 88e1d2192..6174feff2 100644
--- a/gnucash/import-export/bi-import/gnc-plugin-bi-import.c
+++ b/gnucash/import-export/bi-import/gnc-plugin-bi-import.c
@@ -69,7 +69,7 @@ static const gchar *gnc_plugin_load_ui_items [] =
  *                   Object Implementation                  *
  ************************************************************/
 
-G_DEFINE_TYPE(GncPluginbi_import, gnc_plugin_bi_import, GNC_TYPE_PLUGIN);
+G_DEFINE_TYPE(GncPluginbi_import, gnc_plugin_bi_import, GNC_TYPE_PLUGIN)
 
 GncPlugin *
 gnc_plugin_bi_import_new (void)
diff --git a/gnucash/import-export/customer-import/gnc-plugin-customer-import.c b/gnucash/import-export/customer-import/gnc-plugin-customer-import.c
index e78794031..e0188cecd 100644
--- a/gnucash/import-export/customer-import/gnc-plugin-customer-import.c
+++ b/gnucash/import-export/customer-import/gnc-plugin-customer-import.c
@@ -69,7 +69,7 @@ static const gchar *gnc_plugin_load_ui_items [] =
  *                   Object Implementation                  *
  ************************************************************/
 
-G_DEFINE_TYPE(GncPlugincustomer_import, gnc_plugin_customer_import, GNC_TYPE_PLUGIN);
+G_DEFINE_TYPE(GncPlugincustomer_import, gnc_plugin_customer_import, GNC_TYPE_PLUGIN)
 
 GncPlugin *
 gnc_plugin_customer_import_new (void)
diff --git a/gnucash/import-export/import-commodity-matcher.c b/gnucash/import-export/import-commodity-matcher.c
index 303832de5..d34904ef4 100644
--- a/gnucash/import-export/import-commodity-matcher.c
+++ b/gnucash/import-export/import-commodity-matcher.c
@@ -140,5 +140,5 @@ gnc_commodity * gnc_import_select_commodity(const char * cusip,
         gnc_commodity_set_cusip(retval, cusip);
     }
     return retval;
-};
+}
 /**@}*/
diff --git a/gnucash/import-export/import-settings.c b/gnucash/import-export/import-settings.c
index cf5e38f75..db8030515 100644
--- a/gnucash/import-export/import-settings.c
+++ b/gnucash/import-export/import-settings.c
@@ -123,49 +123,49 @@ gnc_import_Settings_get_fuzzy_amount (GNCImportSettings *settings)
 {
     g_assert (settings);
     return settings->fuzzy_amount;
-};
+}
 
 gboolean gnc_import_Settings_get_action_skip_enabled (GNCImportSettings *settings)
 {
     g_assert (settings);
     return settings->action_skip_enabled;
-};
+}
 
 gboolean gnc_import_Settings_get_action_add_enabled (GNCImportSettings *settings)
 {
     g_assert (settings);
     return settings->action_add_enabled;
-};
+}
 
 gboolean gnc_import_Settings_get_action_update_enabled (GNCImportSettings *settings)
 {
     g_assert (settings);
     return settings->action_update_enabled;
-};
+}
 
 gboolean gnc_import_Settings_get_action_clear_enabled (GNCImportSettings *settings)
 {
     g_assert (settings);
     return settings->action_clear_enabled;
-};
+}
 
 gint gnc_import_Settings_get_clear_threshold (GNCImportSettings *settings)
 {
     g_assert (settings);
     return settings->clear_threshold;
-};
+}
 
 gint gnc_import_Settings_get_add_threshold (GNCImportSettings *settings)
 {
     g_assert (settings);
     return settings->add_threshold;
-};
+}
 
 gint gnc_import_Settings_get_display_threshold (GNCImportSettings *settings)
 {
     g_assert (settings);
     return settings->display_threshold;
-};
+}
 
 gint gnc_import_Settings_get_date_threshold (GNCImportSettings *settings)
 {
diff --git a/gnucash/import-export/qif-imp/gnc-plugin-qif-import.c b/gnucash/import-export/qif-imp/gnc-plugin-qif-import.c
index 451cbf9ed..ab1ba6f36 100644
--- a/gnucash/import-export/qif-imp/gnc-plugin-qif-import.c
+++ b/gnucash/import-export/qif-imp/gnc-plugin-qif-import.c
@@ -61,7 +61,7 @@ typedef struct GncPluginQifImportPrivate
     gpointer dummy;
 } GncPluginQifImportPrivate;
 
-G_DEFINE_TYPE_WITH_PRIVATE(GncPluginQifImport, gnc_plugin_qif_import, GNC_TYPE_PLUGIN);
+G_DEFINE_TYPE_WITH_PRIVATE(GncPluginQifImport, gnc_plugin_qif_import, GNC_TYPE_PLUGIN)
 
 #define GNC_PLUGIN_QIF_IMPORT_GET_PRIVATE(o)  \
    ((GncPluginQifImportPrivate*)gnc_plugin_qif_import_get_instance_private((GncPluginQifImport*)o))
diff --git a/gnucash/register/ledger-core/split-register-copy-ops.c b/gnucash/register/ledger-core/split-register-copy-ops.c
index 5b4b6a786..ebee1a1d3 100644
--- a/gnucash/register/ledger-core/split-register-copy-ops.c
+++ b/gnucash/register/ledger-core/split-register-copy-ops.c
@@ -86,57 +86,57 @@ void gnc_float_split_set_split(FloatingSplit *fs, Split *split)
 {
     g_return_if_fail (fs);
     fs->m_split = split;
-};
+}
 
 void gnc_float_split_set_account (FloatingSplit *fs, Account *account) /* direct account pointer rather than account guid */
 {
     g_return_if_fail (fs);
     fs->m_account = account;
-};
+}
 
 void gnc_float_split_set_transaction (FloatingSplit *fs, Transaction *transaction) /* direct transaction pointer rather than transaction guid */
 {
     g_return_if_fail (fs);
     fs->m_transaction = transaction;
-};
+}
 
 void gnc_float_split_set_memo (FloatingSplit *fs, const char *memo)
 {
     g_return_if_fail (fs);
     CACHE_REPLACE (fs->m_memo, memo);
-};
+}
 
 void gnc_float_split_set_action (FloatingSplit *fs, const char *action)
 {
     g_return_if_fail (fs);
     CACHE_REPLACE (fs->m_action, action);
-};
+}
 
 void gnc_float_split_set_reconcile_state (FloatingSplit *fs, char reconcile_state)
 {
     g_return_if_fail (fs);
     fs->m_reconcile_state = reconcile_state;
-};
+}
 
 void gnc_float_split_set_reconcile_date (FloatingSplit *fs, time64 reconcile_date)
 {
     g_return_if_fail (fs);
     fs->m_reconcile_date = reconcile_date;
-};
+}
 
 void gnc_float_split_set_amount (FloatingSplit *fs, const gnc_numeric amount)
 {
     g_return_if_fail (fs);
 
     fs->m_amount = amount;
-};
+}
 
 void gnc_float_split_set_value (FloatingSplit *fs, const gnc_numeric value)
 {
     g_return_if_fail (fs);
 
     fs->m_value = value;
-};
+}
 
 /* This function takes a split and returns a representation
    of it as a floating_split structure. Assumes the transaction is open
@@ -280,55 +280,55 @@ void gnc_float_txn_set_txn (FloatingTxn *ft, Transaction *txn)
 {
     g_return_if_fail (ft);
     ft->m_txn = txn;
-};
+}
 
 void gnc_float_txn_set_currency (FloatingTxn *ft, gnc_commodity *currency)
 {
     g_return_if_fail (ft);
     ft->m_currency = currency;
-};
+}
 
 void gnc_float_txn_set_date_entered (FloatingTxn *ft, time64 date_entered)
 {
     g_return_if_fail (ft);
     ft->m_date_entered = date_entered;
-};
+}
 
 void gnc_float_txn_set_date_posted (FloatingTxn *ft, time64 date_posted)
 {
     g_return_if_fail (ft);
     ft->m_date_posted = date_posted;
-};
+}
 
 void gnc_float_txn_set_num (FloatingTxn *ft, const char *num)
 {
     g_return_if_fail (ft);
     CACHE_REPLACE (ft->m_num, num);
-};
+}
 
 void gnc_float_txn_set_description (FloatingTxn *ft, const char *description)
 {
     g_return_if_fail (ft);
     CACHE_REPLACE (ft->m_description, description);
-};
+}
 
 void gnc_float_txn_set_notes (FloatingTxn *ft, const char *notes)
 {
     g_return_if_fail (ft);
     CACHE_REPLACE (ft->m_notes, notes);
-};
+}
 
 void gnc_float_txn_set_doclink (FloatingTxn *ft, const char *doclink)
 {
     g_return_if_fail (ft);
     CACHE_REPLACE (ft->m_doclink, doclink);
-};
+}
 
 void gnc_float_txn_set_splits (FloatingTxn *ft, SplitList *splits)
 {
     g_return_if_fail (ft);
     ft->m_splits = splits;
-};
+}
 
 void gnc_float_txn_append_float_split (FloatingTxn *ft, FloatingSplit *fs)
 {
diff --git a/libgnucash/engine/SX-book.c b/libgnucash/engine/SX-book.c
index 15eb1943b..a7d185f16 100644
--- a/libgnucash/engine/SX-book.c
+++ b/libgnucash/engine/SX-book.c
@@ -232,7 +232,7 @@ gnc_sxes_del_sx(SchedXactions *sxes, SchedXaction *sx)
 /* SX-trans stuff */
 
 /* GObject initialization */
-QOF_GOBJECT_IMPL(gnc_schedxactions, SchedXactions, QOF_TYPE_INSTANCE);
+QOF_GOBJECT_IMPL(gnc_schedxactions, SchedXactions, QOF_TYPE_INSTANCE)
 
 static void
 gnc_schedxactions_init(SchedXactions* sxs)
diff --git a/libgnucash/engine/SchedXaction.c b/libgnucash/engine/SchedXaction.c
index 99177e9ef..127f45272 100644
--- a/libgnucash/engine/SchedXaction.c
+++ b/libgnucash/engine/SchedXaction.c
@@ -61,7 +61,7 @@ enum
 };
 
 /* GObject initialization */
-G_DEFINE_TYPE(SchedXaction, gnc_schedxaction, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(SchedXaction, gnc_schedxaction, QOF_TYPE_INSTANCE)
 
 static void
 gnc_schedxaction_init(SchedXaction* sx)
diff --git a/libgnucash/engine/gnc-commodity.c b/libgnucash/engine/gnc-commodity.c
index ac686c4b7..9799d9f79 100644
--- a/libgnucash/engine/gnc-commodity.c
+++ b/libgnucash/engine/gnc-commodity.c
@@ -654,7 +654,7 @@ reset_unique_name(gnc_commodityPrivate *priv)
 }
 
 /* GObject Initialization */
-G_DEFINE_TYPE_WITH_PRIVATE(gnc_commodity, gnc_commodity, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE_WITH_PRIVATE(gnc_commodity, gnc_commodity, QOF_TYPE_INSTANCE)
 
 static void
 gnc_commodity_init(gnc_commodity* com)
@@ -2306,7 +2306,7 @@ gnc_commodity_table_get_quotable_commodities(const gnc_commodity_table * table)
  ********************************************************************/
 
 /* GObject Initialization */
-QOF_GOBJECT_IMPL(gnc_commodity_namespace, gnc_commodity_namespace, QOF_TYPE_INSTANCE);
+QOF_GOBJECT_IMPL(gnc_commodity_namespace, gnc_commodity_namespace, QOF_TYPE_INSTANCE)
 
 static void
 gnc_commodity_namespace_init(gnc_commodity_namespace* ns)
diff --git a/libgnucash/engine/gnc-pricedb.c b/libgnucash/engine/gnc-pricedb.c
index 13819ce81..3d13ca3c8 100644
--- a/libgnucash/engine/gnc-pricedb.c
+++ b/libgnucash/engine/gnc-pricedb.c
@@ -96,7 +96,7 @@ hash_entry_free_gfunc(gpointer data, G_GNUC_UNUSED gpointer user_data)
 }
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GNCPrice, gnc_price, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GNCPrice, gnc_price, QOF_TYPE_INSTANCE)
 
 static void
 gnc_price_init(GNCPrice* price)
@@ -835,7 +835,7 @@ gnc_price_list_equal(PriceList *prices1, PriceList *prices2)
  */
 
 /* GObject Initialization */
-QOF_GOBJECT_IMPL(gnc_pricedb, GNCPriceDB, QOF_TYPE_INSTANCE);
+QOF_GOBJECT_IMPL(gnc_pricedb, GNCPriceDB, QOF_TYPE_INSTANCE)
 
 static void
 gnc_pricedb_init(GNCPriceDB* pdb)
diff --git a/libgnucash/engine/gncAddress.c b/libgnucash/engine/gncAddress.c
index 6bd871e28..19c40bee7 100644
--- a/libgnucash/engine/gncAddress.c
+++ b/libgnucash/engine/gncAddress.c
@@ -86,7 +86,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncAddress, gnc_address, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncAddress, gnc_address, QOF_TYPE_INSTANCE)
 
 static void
 gnc_address_init(GncAddress* addr)
diff --git a/libgnucash/engine/gncBillTerm.c b/libgnucash/engine/gncBillTerm.c
index 3338b1433..e0abb5c04 100644
--- a/libgnucash/engine/gncBillTerm.c
+++ b/libgnucash/engine/gncBillTerm.c
@@ -137,7 +137,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncBillTerm, gnc_billterm, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncBillTerm, gnc_billterm, QOF_TYPE_INSTANCE)
 
 static void
 gnc_billterm_init(GncBillTerm* bt)
diff --git a/libgnucash/engine/gncCustomer.c b/libgnucash/engine/gncCustomer.c
index ddb03aee0..4ac50d888 100644
--- a/libgnucash/engine/gncCustomer.c
+++ b/libgnucash/engine/gncCustomer.c
@@ -103,7 +103,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncCustomer, gnc_customer, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncCustomer, gnc_customer, QOF_TYPE_INSTANCE)
 
 static void
 gnc_customer_init(GncCustomer* cust)
diff --git a/libgnucash/engine/gncEmployee.c b/libgnucash/engine/gncEmployee.c
index 293b52dcb..fd9518f88 100644
--- a/libgnucash/engine/gncEmployee.c
+++ b/libgnucash/engine/gncEmployee.c
@@ -99,7 +99,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncEmployee, gnc_employee, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncEmployee, gnc_employee, QOF_TYPE_INSTANCE)
 
 static void
 gnc_employee_init(GncEmployee* emp)
diff --git a/libgnucash/engine/gncEntry.c b/libgnucash/engine/gncEntry.c
index 449abcabf..0350bc573 100644
--- a/libgnucash/engine/gncEntry.c
+++ b/libgnucash/engine/gncEntry.c
@@ -238,7 +238,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncEntry, gnc_entry, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncEntry, gnc_entry, QOF_TYPE_INSTANCE)
 
 static void
 gnc_entry_init(GncEntry* entry)
diff --git a/libgnucash/engine/gncInvoice.c b/libgnucash/engine/gncInvoice.c
index 7f8f923c3..ab10dc196 100644
--- a/libgnucash/engine/gncInvoice.c
+++ b/libgnucash/engine/gncInvoice.c
@@ -132,7 +132,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncInvoice, gnc_invoice, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncInvoice, gnc_invoice, QOF_TYPE_INSTANCE)
 
 static void
 gnc_invoice_init (GncInvoice* inv)
diff --git a/libgnucash/engine/gncJob.c b/libgnucash/engine/gncJob.c
index 46fb843d6..3b6689d56 100644
--- a/libgnucash/engine/gncJob.c
+++ b/libgnucash/engine/gncJob.c
@@ -83,7 +83,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncJob, gnc_job, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncJob, gnc_job, QOF_TYPE_INSTANCE)
 
 static void
 gnc_job_init(GncJob* job)
diff --git a/libgnucash/engine/gncOrder.c b/libgnucash/engine/gncOrder.c
index 24b3901f5..21748717a 100644
--- a/libgnucash/engine/gncOrder.c
+++ b/libgnucash/engine/gncOrder.c
@@ -93,7 +93,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncOrder, gnc_order, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncOrder, gnc_order, QOF_TYPE_INSTANCE)
 
 static void
 gnc_order_init(GncOrder* order)
diff --git a/libgnucash/engine/gncTaxTable.c b/libgnucash/engine/gncTaxTable.c
index 2e0cbfa90..fca6cc1fa 100644
--- a/libgnucash/engine/gncTaxTable.c
+++ b/libgnucash/engine/gncTaxTable.c
@@ -212,7 +212,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncTaxTable, gnc_taxtable, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncTaxTable, gnc_taxtable, QOF_TYPE_INSTANCE)
 
 static void
 gnc_taxtable_init(GncTaxTable* tt)
diff --git a/libgnucash/engine/gncVendor.c b/libgnucash/engine/gncVendor.c
index 67af18c61..e6518125e 100644
--- a/libgnucash/engine/gncVendor.c
+++ b/libgnucash/engine/gncVendor.c
@@ -107,7 +107,7 @@ enum
 };
 
 /* GObject Initialization */
-G_DEFINE_TYPE(GncVendor, gnc_vendor, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(GncVendor, gnc_vendor, QOF_TYPE_INSTANCE)
 
 static void
 gnc_vendor_init(GncVendor* vendor)
diff --git a/libgnucash/engine/mocks/gmock-Account.cpp b/libgnucash/engine/mocks/gmock-Account.cpp
index aea26ed81..bfed846da 100644
--- a/libgnucash/engine/mocks/gmock-Account.cpp
+++ b/libgnucash/engine/mocks/gmock-Account.cpp
@@ -9,7 +9,7 @@ struct _MockAccountClass
 };
 typedef struct _MockAccountClass MockAccountClass;
 
-G_DEFINE_TYPE(MockAccount, gnc_mockaccount, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(MockAccount, gnc_mockaccount, QOF_TYPE_INSTANCE)
 
 static void
 gnc_mockaccount_init (MockAccount *inst)
diff --git a/libgnucash/engine/mocks/gmock-Split.cpp b/libgnucash/engine/mocks/gmock-Split.cpp
index de67a40f5..f01807f2b 100644
--- a/libgnucash/engine/mocks/gmock-Split.cpp
+++ b/libgnucash/engine/mocks/gmock-Split.cpp
@@ -13,7 +13,7 @@ struct _MockSplitClass
 };
 typedef struct _MockSplitClass MockSplitClass;
 
-G_DEFINE_TYPE(MockSplit, gnc_mocksplit, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(MockSplit, gnc_mocksplit, QOF_TYPE_INSTANCE)
 
 static void
 gnc_mocksplit_init (MockSplit *inst)
diff --git a/libgnucash/engine/mocks/gmock-Transaction.cpp b/libgnucash/engine/mocks/gmock-Transaction.cpp
index 331c84959..9c92d4ffc 100644
--- a/libgnucash/engine/mocks/gmock-Transaction.cpp
+++ b/libgnucash/engine/mocks/gmock-Transaction.cpp
@@ -11,7 +11,7 @@ struct _MockTransactionClass
 };
 typedef struct _MockTransactionClass MockTransactionClass;
 
-G_DEFINE_TYPE(MockTransaction, gnc_mocktransaction, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(MockTransaction, gnc_mocktransaction, QOF_TYPE_INSTANCE)
 
 static void
 gnc_mocktransaction_init (MockTransaction *inst)
diff --git a/libgnucash/engine/mocks/gmock-qofbook.cpp b/libgnucash/engine/mocks/gmock-qofbook.cpp
index 1ea7d7215..73c50b04a 100644
--- a/libgnucash/engine/mocks/gmock-qofbook.cpp
+++ b/libgnucash/engine/mocks/gmock-qofbook.cpp
@@ -6,7 +6,7 @@ struct _QofMockBookClass
 };
 typedef struct _QofMockBookClass QofMockBookClass;
 
-G_DEFINE_TYPE(QofMockBook, qof_mockbook, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(QofMockBook, qof_mockbook, QOF_TYPE_INSTANCE)
 
 static void
 qof_mockbook_init (QofMockBook *inst)
diff --git a/libgnucash/engine/mocks/gmock-qofinstance.cpp b/libgnucash/engine/mocks/gmock-qofinstance.cpp
index cd253b199..542684e20 100644
--- a/libgnucash/engine/mocks/gmock-qofinstance.cpp
+++ b/libgnucash/engine/mocks/gmock-qofinstance.cpp
@@ -6,7 +6,7 @@
 #include <qofinstance-p.h>
 
 
-G_DEFINE_TYPE(QofInstance, qof_instance, G_TYPE_OBJECT);
+G_DEFINE_TYPE(QofInstance, qof_instance, G_TYPE_OBJECT)
 
 static void
 qof_instance_init (QofInstance *inst)
diff --git a/libgnucash/engine/qof-gobject.h b/libgnucash/engine/qof-gobject.h
index d051657f2..44e996a33 100644
--- a/libgnucash/engine/qof-gobject.h
+++ b/libgnucash/engine/qof-gobject.h
@@ -57,7 +57,7 @@
  */
 
 #define QOF_GOBJECT_GET_TYPE(TypeName, type_name, TYPE_PARENT, CODE)	\
-  G_DEFINE_TYPE_WITH_CODE(TypeName, type_name, TYPE_PARENT, CODE);
+  G_DEFINE_TYPE_WITH_CODE(TypeName, type_name, TYPE_PARENT, CODE)
 
 #define QOF_GOBJECT_CLASS_INIT(type_name, TypeName)			\
   static void type_name##_dispose(GObject *object);			\
@@ -86,10 +86,10 @@
   }
 
 #define QOF_GOBJECT_IMPL_WITH_CODE(type_name, TypeName, TYPE_PARENT, CODE) \
-  QOF_GOBJECT_GET_TYPE(TypeName, type_name, TYPE_PARENT, CODE);		\
-  QOF_GOBJECT_CLASS_INIT(type_name, TypeName);				\
-  QOF_GOBJECT_DISPOSE(type_name);					\
-  QOF_GOBJECT_FINALIZE(type_name);
+  QOF_GOBJECT_GET_TYPE(TypeName, type_name, TYPE_PARENT, CODE)		\
+  QOF_GOBJECT_CLASS_INIT(type_name, TypeName)				\
+  QOF_GOBJECT_DISPOSE(type_name)					\
+  QOF_GOBJECT_FINALIZE(type_name)
 
 #define QOF_GOBJECT_IMPL(type_name, TypeName, TYPE_PARENT) \
   QOF_GOBJECT_IMPL_WITH_CODE(type_name, TypeName, TYPE_PARENT, {})
diff --git a/libgnucash/engine/qofbook.cpp b/libgnucash/engine/qofbook.cpp
index ba73cdc94..5c4b8a8fb 100644
--- a/libgnucash/engine/qofbook.cpp
+++ b/libgnucash/engine/qofbook.cpp
@@ -89,7 +89,7 @@ qof_book_option_num_autoreadonly_changed_cb (GObject *gobject,
 #define PARAM_NAME_NUM_FIELD_SOURCE "split-action-num-field"
 #define PARAM_NAME_NUM_AUTOREAD_ONLY "autoreadonly-days"
 
-G_DEFINE_TYPE(QofBook, qof_book, QOF_TYPE_INSTANCE);
+G_DEFINE_TYPE(QofBook, qof_book, QOF_TYPE_INSTANCE)
 QOF_GOBJECT_DISPOSE(qof_book);
 QOF_GOBJECT_FINALIZE(qof_book);
 
diff --git a/libgnucash/engine/qofinstance.cpp b/libgnucash/engine/qofinstance.cpp
index c79663741..6b7d3393f 100644
--- a/libgnucash/engine/qofinstance.cpp
+++ b/libgnucash/engine/qofinstance.cpp
@@ -111,7 +111,7 @@ typedef struct QofInstancePrivate
 #define GET_PRIVATE(o)  \
     ((QofInstancePrivate*)qof_instance_get_instance_private((QofInstance*)o))
 
-G_DEFINE_TYPE_WITH_PRIVATE(QofInstance, qof_instance, G_TYPE_OBJECT);
+G_DEFINE_TYPE_WITH_PRIVATE(QofInstance, qof_instance, G_TYPE_OBJECT)
 QOF_GOBJECT_FINALIZE(qof_instance);
 #undef G_PARAM_READWRITE
 #define G_PARAM_READWRITE static_cast<GParamFlags>(G_PARAM_READABLE | G_PARAM_WRITABLE)

commit a81b72f04cdfa2bc774d230a76438046647e0bd6
Merge: 19bbde700 5a490d9ff
Author: John Ralls <jralls at ceridwen.us>
Date:   Mon Jan 23 14:03:01 2023 -0800

    Merge Ralf Habacker's 'activate-opening-balance-accounts' into maint.

diff --cc gnucash/gnome/gnc-plugin-page-register.c
index 81ac39874,8afdc5d51..72ebe469b
--- a/gnucash/gnome/gnc-plugin-page-register.c
+++ b/gnucash/gnome/gnc-plugin-page-register.c
@@@ -758,6 -742,10 +758,10 @@@ gnc_plugin_page_register_new_common (GN
      if (!gnc_features_check_used (gnc_get_current_book(), GNC_FEATURE_REG_SORT_FILTER))
          gnc_features_set_used (gnc_get_current_book(), GNC_FEATURE_REG_SORT_FILTER);
  
 -    // added for version 4.5 onwards
++    // added for version 4.14 onwards
+     if (!gnc_using_equity_type_opening_balance_account (gnc_get_current_book()))
+         gnc_set_use_equity_type_opening_balance_account (gnc_get_current_book());
+ 
      /* Is there an existing page? */
      gsr = gnc_ledger_display_get_user_data (ledger);
      if (gsr)

commit 19bbde7000c21e471e1c877a1716a61dde73af79
Author: Richard Cohen <richard at daijobu.co.uk>
Date:   Mon Jan 23 15:01:46 2023 +0000

    Fix some typos

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 26e700bcd..8a4bacf3f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -617,7 +617,7 @@ if (XCODE_VERSION)
   set(CMAKE_LIBRARY_OUTPUT_DIRECTORY_RELEASE ${LIBDIR_BUILD}/gnucash)
 endif()
 
-# For binarines
+# For binaries
 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY         ${CMAKE_BINARY_DIR}/bin)
 if (XCODE_VERSION)
   set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG   ${CMAKE_BINARY_DIR}/bin)
diff --git a/gnucash/gnome-utils/dialog-totd.c b/gnucash/gnome-utils/dialog-totd.c
index 48d10fd1e..01e16f237 100644
--- a/gnucash/gnome-utils/dialog-totd.c
+++ b/gnucash/gnome-utils/dialog-totd.c
@@ -103,7 +103,7 @@ gnc_new_tip_number (TotdDialog *totd_dialog, gint offset)
      */
     if (tip_list[current_tip_number])
         tip_components = g_strsplit(tip_list[current_tip_number], "|", 0);
-    /* If the tip is empty, g_strisplit will return an empty list. This
+    /* If the tip is empty, g_strsplit will return an empty list. This
      * shouldn't normally happen, but make sure we don't crash just in
      * case */
     if (tip_components == NULL)
diff --git a/gnucash/gnome-utils/gnc-date-edit.c b/gnucash/gnome-utils/gnc-date-edit.c
index d0d7ba8e9..fde3aa5ee 100644
--- a/gnucash/gnome-utils/gnc-date-edit.c
+++ b/gnucash/gnome-utils/gnc-date-edit.c
@@ -1057,7 +1057,7 @@ gnc_date_edit_get_date_internal (GNCDateEdit *gde)
 
     if (!date_was_valid)
     {
-        /* Hm... no valid date. What should we do not? As a hacky workaround we
+        /* Hm... no valid date. What should we do now? As a hacky workaround we
         revert to today's date. Alternatively we can return some value that
         signals that we don't get a valid date, but all callers of this
         function will have to check this. Alas, I'm too lazy to do this here. */
diff --git a/gnucash/gnome-utils/gnc-main-window.c b/gnucash/gnome-utils/gnc-main-window.c
index 2ffbac052..51890edfd 100644
--- a/gnucash/gnome-utils/gnc-main-window.c
+++ b/gnucash/gnome-utils/gnc-main-window.c
@@ -1444,7 +1444,7 @@ gnc_main_window_quit(GncMainWindow *window)
         GList *w, *next;
 
         /* This is not a typical list iteration. There is a possibility
-         * that the window maybe removed from the active_windows list so
+         * that the window may be removed from the active_windows list so
          * we have to cache the 'next' pointer before executing any code
          * in the loop. */
         for (w = active_windows; w; w = next)
diff --git a/gnucash/gnucash.cpp b/gnucash/gnucash.cpp
index d32c21018..ba5116fc0 100644
--- a/gnucash/gnucash.cpp
+++ b/gnucash/gnucash.cpp
@@ -322,7 +322,7 @@ Gnucash::Gnucash::start ([[maybe_unused]] int argc, [[maybe_unused]] char **argv
     }
 
     /* Now the module files are looked up, which might cause some library
-     initialization to be run, hence gtk must be initialized b*eforehand. */
+     initialization to be run, hence gtk must be initialized beforehand. */
     gnc_module_system_init();
 
     gnc_gui_init();
diff --git a/gnucash/import-export/qif-imp/assistant-qif-import.c b/gnucash/import-export/qif-imp/assistant-qif-import.c
index fb1347fd0..9231ef308 100644
--- a/gnucash/import-export/qif-imp/assistant-qif-import.c
+++ b/gnucash/import-export/qif-imp/assistant-qif-import.c
@@ -2119,7 +2119,7 @@ gnc_ui_qif_import_account_prepare (GtkAssistant  *assistant, gpointer user_data)
     if (wind->ask_date_format && wind->date_format)
         qif_import_reparse_dates (wind);
 
-    /* make sure there is a file selected, may of come back */
+    /* make sure there is a file selected, may have come back */
     if (wind->selected_file == SCM_BOOL_F)
     {
         GtkAssistant *assistant = GTK_ASSISTANT(wind->window);
diff --git a/libgnucash/app-utils/QuickFill.h b/libgnucash/app-utils/QuickFill.h
index 4fd125319..ba85097c6 100644
--- a/libgnucash/app-utils/QuickFill.h
+++ b/libgnucash/app-utils/QuickFill.h
@@ -71,7 +71,7 @@ void         gnc_quickfill_purge (QuickFill *qf);
  */
 const char * gnc_quickfill_string (QuickFill *qf);
 
-/** Return the subnode of the tree whose strings all hold 'wc' as
+/** Return the subnode of the tree whose strings all hold 'c' as
  *  the next letter.  That is, if 'qf' holds all strings starting
  *  with the letter 'a', and we ask for the letter 'b', then this
  *  routine will return the node holding all strings that start
diff --git a/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp b/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp
index 3eaf4d9bc..aabacc313 100644
--- a/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp
+++ b/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp
@@ -556,7 +556,7 @@ GncDbiSqlConnection::quote_string (const std::string& unquoted_str)
 
 
 /** Check if the dbi connection is valid. If not attempt to re-establish it
- * Returns TRUE is there is a valid connection in the end or FALSE otherwise
+ * Returns TRUE if there is a valid connection in the end or FALSE otherwise
  */
 bool
 GncDbiSqlConnection::verify () noexcept
diff --git a/libgnucash/backend/dbi/gnc-dbisqlconnection.hpp b/libgnucash/backend/dbi/gnc-dbisqlconnection.hpp
index 7865bd216..a87137836 100644
--- a/libgnucash/backend/dbi/gnc-dbisqlconnection.hpp
+++ b/libgnucash/backend/dbi/gnc-dbisqlconnection.hpp
@@ -76,7 +76,7 @@ public:
         set_error(ERR_BACKEND_NO_ERR, 0, false);
     }
     /** Check if the dbi connection is valid. If not attempt to re-establish it
-     * Returns TRUE is there is a valid connection in the end or FALSE otherwise
+     * Returns TRUE if there is a valid connection in the end or FALSE otherwise
      */
     bool verify() noexcept override;
     bool retry_connection(const char* msg) noexcept override;
diff --git a/libgnucash/engine/qoflog.cpp b/libgnucash/engine/qoflog.cpp
index 993d9c208..58a78f4cc 100644
--- a/libgnucash/engine/qoflog.cpp
+++ b/libgnucash/engine/qoflog.cpp
@@ -237,7 +237,7 @@ qof_log_init_filename(const gchar* log_filename)
             g_assert(g_strcmp0(log_filename, "/dev/null") != 0);
 
             /* Windows prevents renaming of open files, so the next command silently fails there
-             * No problem, the filename on Winows will simply have the random characters */
+             * No problem, the filename on Windows will simply have the random characters */
             g_rename(fname, log_filename);
             fout = fdopen(fd, "w");
 #endif
diff --git a/libgnucash/engine/test/test-gnc-guid.cpp b/libgnucash/engine/test/test-gnc-guid.cpp
index 65c9f341b..10137f42e 100644
--- a/libgnucash/engine/test/test-gnc-guid.cpp
+++ b/libgnucash/engine/test/test-gnc-guid.cpp
@@ -82,7 +82,7 @@ TEST (GncGUID, from_string)
         fail = true;
     }
     /* Currently, boost uuid string parsing is mostly very permissive, but it has some
-     * odd pet peves. See https://svn.boost.org/trac/boost/ticket/12253 for more.*/
+     * odd pet peeves. See https://svn.boost.org/trac/boost/ticket/12253 for more.*/
     if (BOOST_VERSION >= 106600)
         EXPECT_TRUE (fail) << "Parsing the bogus string should throw";
     else
diff --git a/libgnucash/gnc-module/gnc-module.c b/libgnucash/gnc-module/gnc-module.c
index 11465757e..f6ffcdf7d 100644
--- a/libgnucash/gnc-module/gnc-module.c
+++ b/libgnucash/gnc-module/gnc-module.c
@@ -228,9 +228,9 @@ gnc_module_system_refresh(void)
 
             /* Gotcha: On MacOS, G_MODULE_SUFFIX is defined as "so",
              * but if we do not build clean libtool modules with
-             * "-module", we get dynamic libraries ending on .dylib On
-             * Windows, all modules will move to bin/, so they will be
-             * mixed with other libraries, such as gtk+. Adding a
+             * "-module", we get dynamic libraries ending in .dylib
+             * On Windows, all modules will move to bin/, so they will
+             * be mixed with other libraries, such as gtk+. Adding a
              * prefix "libgncmod" filter will prevent the module loader
              * from loading other libraries. The filter should work on
              * other platforms.

commit d1b84fae9f73775ed57aefa2639b9c1408e24417
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Jan 23 14:12:21 2023 +0800

    [balsheet-pnl] shorten workload by deduping commodities

diff --git a/gnucash/report/reports/standard/balsheet-pnl.scm b/gnucash/report/reports/standard/balsheet-pnl.scm
index e1f5d2b44..ac0bc826a 100644
--- a/gnucash/report/reports/standard/balsheet-pnl.scm
+++ b/gnucash/report/reports/standard/balsheet-pnl.scm
@@ -764,12 +764,17 @@ also show overall period profit & loss."))
 
          ;; generate an exchange-fn for date, and cache its result.
          (get-date-exchange-fn
-          (let ((h (make-hash-table)))
+          (let ((h (make-hash-table))
+                (commodities (sort-and-delete-duplicates
+                              (map xaccAccountGetCommodity accounts)
+                              (lambda (a b)
+                                (gnc:string-locale<? (gnc-commodity-get-unique-name a)
+                                                     (gnc-commodity-get-unique-name b)))
+                              gnc-commodity-equal)))
             (lambda (date)
               (or (hashv-ref h date)
                   (let ((exchangefn (gnc:case-exchange-time-fn
-                                     price-source common-currency
-                                     (map xaccAccountGetCommodity accounts)
+                                     price-source common-currency commodities
                                      date #f #f)))
                     (hashv-set! h date exchangefn)
                     exchangefn)))))

commit c16bde1aeac7d5a6febf76ef236829cc11ead358
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Jan 23 13:27:57 2023 +0800

    [commodity-utilities] shorten workload by deduping commodities

diff --git a/gnucash/report/commodity-utilities.scm b/gnucash/report/commodity-utilities.scm
index 5e1990de2..2ca72f09c 100644
--- a/gnucash/report/commodity-utilities.scm
+++ b/gnucash/report/commodity-utilities.scm
@@ -229,6 +229,12 @@
           (gnc-account-get-descendants-sorted (gnc-get-current-root-account)))
          (all-splits (get-all-splits currency-accounts end-date))
          (interesting-splits (sort (filter interesting-split? all-splits) date<?))
+         (commodity-list (sort-and-delete-duplicates
+                          commodity-list
+                          (lambda (a b)
+                            (gnc:string-locale<? (gnc-commodity-get-unique-name a)
+                                                 (gnc-commodity-get-unique-name b)))
+                          gnc-commodity-equal))
          (work-to-do (length commodity-list)))
     (map
      (lambda (c work-done)

commit 5a490d9ff7f600654d06139999c099f55eacb9d5
Author: Ralf Habacker <ralf.habacker at freenet.de>
Date:   Wed Oct 28 06:44:42 2020 +0100

    Activate feature GNC_FEATURE_EQUITY_TYPE_OPENING_BALANCE

diff --git a/gnucash/gnome/assistant-hierarchy.c b/gnucash/gnome/assistant-hierarchy.c
index 6d39f37ad..f5431e9b8 100644
--- a/gnucash/gnome/assistant-hierarchy.c
+++ b/gnucash/gnome/assistant-hierarchy.c
@@ -1424,6 +1424,9 @@ on_finish (GtkAssistant  *gtkassistant,
     ENTER (" ");
     com = gnc_currency_edit_get_currency (GNC_CURRENCY_EDIT(data->currency_selector));
 
+    if (!gnc_using_equity_type_opening_balance_account (gnc_get_current_book()))
+        gnc_set_use_equity_type_opening_balance_account (gnc_get_current_book());
+
     if (data->our_account_tree)
     {
         gnc_account_foreach_descendant (data->our_account_tree,
diff --git a/gnucash/gnome/gnc-plugin-page-register.c b/gnucash/gnome/gnc-plugin-page-register.c
index 797b2959d..8afdc5d51 100644
--- a/gnucash/gnome/gnc-plugin-page-register.c
+++ b/gnucash/gnome/gnc-plugin-page-register.c
@@ -742,6 +742,10 @@ gnc_plugin_page_register_new_common (GNCLedgerDisplay* ledger)
     if (!gnc_features_check_used (gnc_get_current_book(), GNC_FEATURE_REG_SORT_FILTER))
         gnc_features_set_used (gnc_get_current_book(), GNC_FEATURE_REG_SORT_FILTER);
 
+    // added for version 4.5 onwards
+    if (!gnc_using_equity_type_opening_balance_account (gnc_get_current_book()))
+        gnc_set_use_equity_type_opening_balance_account (gnc_get_current_book());
+
     /* Is there an existing page? */
     gsr = gnc_ledger_display_get_user_data (ledger);
     if (gsr)



Summary of changes:
 CMakeLists.txt                                     |   2 +-
 bindings/business-core.i                           |  13 --
 gnucash/gnome-utils/dialog-totd.c                  |   2 +-
 gnucash/gnome-utils/gnc-date-edit.c                |   2 +-
 gnucash/gnome-utils/gnc-main-window.cpp            |   2 +-
 gnucash/gnome/assistant-hierarchy.cpp              |   3 +
 gnucash/gnome/assistant-stock-transaction.cpp      |   2 +-
 gnucash/gnome/business-urls.c                      |   9 -
 gnucash/gnome/dialog-invoice.c                     |   9 -
 gnucash/gnome/dialog-invoice.h                     |   2 +-
 gnucash/gnome/gnc-plugin-page-register.c           |   4 +
 gnucash/gnome/search-owner.c                       |   2 +-
 gnucash/gnucash.cpp                                |   2 +-
 .../import-export/bi-import/gnc-plugin-bi-import.c |   2 +-
 .../customer-import/gnc-plugin-customer-import.c   |   2 +-
 gnucash/import-export/import-commodity-matcher.c   |   2 +-
 gnucash/import-export/import-settings.c            |  16 +-
 gnucash/import-export/log-replay/gnc-log-replay.c  |   4 +-
 .../import-export/qif-imp/assistant-qif-import.c   |   2 +-
 .../import-export/qif-imp/gnc-plugin-qif-import.c  |   2 +-
 .../register/ledger-core/split-register-copy-ops.c |  36 ++--
 gnucash/report/commodity-utilities.scm             |   6 +
 gnucash/report/reports/standard/balsheet-pnl.scm   |  11 +-
 libgnucash/app-utils/QuickFill.h                   |   2 +-
 libgnucash/backend/dbi/gnc-dbisqlconnection.cpp    |   2 +-
 libgnucash/backend/dbi/gnc-dbisqlconnection.hpp    |   2 +-
 libgnucash/core-utils/CMakeLists.txt               |   2 -
 libgnucash/core-utils/gnc-jalali.c                 | 196 ---------------------
 libgnucash/core-utils/gnc-jalali.h                 |  46 -----
 libgnucash/engine/SX-book.c                        |   2 +-
 libgnucash/engine/SchedXaction.c                   |   2 +-
 libgnucash/engine/gnc-commodity.c                  |   4 +-
 libgnucash/engine/gnc-pricedb.c                    |   4 +-
 libgnucash/engine/gncAddress.c                     |   2 +-
 libgnucash/engine/gncBillTerm.c                    |   2 +-
 libgnucash/engine/gncBillTerm.h                    |   2 -
 libgnucash/engine/gncCustomer.c                    |   2 +-
 libgnucash/engine/gncCustomer.h                    |   2 -
 libgnucash/engine/gncEmployee.c                    |   2 +-
 libgnucash/engine/gncEmployee.h                    |   2 -
 libgnucash/engine/gncEntry.c                       |   2 +-
 libgnucash/engine/gncEntry.h                       |   2 -
 libgnucash/engine/gncInvoice.c                     |   2 +-
 libgnucash/engine/gncInvoice.h                     |   2 -
 libgnucash/engine/gncJob.c                         |   2 +-
 libgnucash/engine/gncJob.h                         |   2 -
 libgnucash/engine/gncOrder.c                       |   2 +-
 libgnucash/engine/gncOrder.h                       |   2 -
 libgnucash/engine/gncTaxTable.c                    |   2 +-
 libgnucash/engine/gncTaxTable.h                    |   2 -
 libgnucash/engine/gncVendor.c                      |   2 +-
 libgnucash/engine/gncVendor.h                      |   2 -
 libgnucash/engine/mocks/gmock-Account.cpp          |   2 +-
 libgnucash/engine/mocks/gmock-Split.cpp            |   2 +-
 libgnucash/engine/mocks/gmock-Transaction.cpp      |   2 +-
 libgnucash/engine/mocks/gmock-qofbook.cpp          |   2 +-
 libgnucash/engine/mocks/gmock-qofinstance.cpp      |   2 +-
 libgnucash/engine/qof-gobject.h                    |  10 +-
 libgnucash/engine/qofbook.cpp                      |   2 +-
 libgnucash/engine/qofinstance.cpp                  |   2 +-
 libgnucash/engine/qoflog.cpp                       |   2 +-
 libgnucash/engine/qofobject.cpp                    |   7 -
 libgnucash/engine/test/CMakeLists.txt              |   1 -
 libgnucash/engine/test/dummy.cpp                   |   2 -
 libgnucash/engine/test/test-gnc-guid.cpp           |   2 +-
 libgnucash/engine/test/test-qofobject.c            |   1 -
 libgnucash/gnc-module/gnc-module.c                 |   6 +-
 po/POTFILES.in                                     |   1 -
 68 files changed, 97 insertions(+), 386 deletions(-)
 delete mode 100644 libgnucash/core-utils/gnc-jalali.c
 delete mode 100644 libgnucash/core-utils/gnc-jalali.h
 delete mode 100644 libgnucash/engine/test/dummy.cpp



More information about the gnucash-changes mailing list