gnucash master: Multiple changes pushed
John Ralls
jralls at code.gnucash.org
Thu Jan 26 16:01:57 EST 2023
Updated via https://github.com/Gnucash/gnucash/commit/44f4b559 (commit)
via https://github.com/Gnucash/gnucash/commit/09b0bfe8 (commit)
via https://github.com/Gnucash/gnucash/commit/846e7514 (commit)
via https://github.com/Gnucash/gnucash/commit/5be5c58b (commit)
via https://github.com/Gnucash/gnucash/commit/619f62fb (commit)
via https://github.com/Gnucash/gnucash/commit/671f14f6 (commit)
via https://github.com/Gnucash/gnucash/commit/a2ffc7fe (commit)
from https://github.com/Gnucash/gnucash/commit/f8465dad (commit)
commit 44f4b55927396e4cc23bcd6d54d733375bf9a387
Merge: 09b0bfe8b 5be5c58b4
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Jan 26 12:52:21 2023 -0800
Merge Richard Cohen's 'fix-memleaks' into master.
commit 09b0bfe8b9108f857a03ff83e9c45c77994bb171
Merge: f8465dadf 846e75146
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Jan 26 12:48:08 2023 -0800
Merge Richard Cohen's 'reinstate-tests' into master.
commit 846e75146ac5626a6ba22251ba652a597642d536
Author: Richard Cohen <richard at example.com>
Date: Sun Nov 27 21:14:10 2022 +0000
Fix some typos so that the correct tests are run
- test_gnc_txn_to_float_txn_cut_semantics
- test_dbi_business_store_and_reload
diff --git a/gnucash/register/ledger-core/test/utest-split-register-copy-ops.c b/gnucash/register/ledger-core/test/utest-split-register-copy-ops.c
index 46c8ce9e2..2712541c8 100644
--- a/gnucash/register/ledger-core/test/utest-split-register-copy-ops.c
+++ b/gnucash/register/ledger-core/test/utest-split-register-copy-ops.c
@@ -600,7 +600,7 @@ test_suite_split_register_copy_ops (void)
GNC_TEST_ADD (suitename, "gnc split to float split", Fixture, NULL, setup, test_gnc_split_to_float_split, teardown);
GNC_TEST_ADD (suitename, "gnc float split to split", Fixture, NULL, setup, test_gnc_float_split_to_split, teardown);
GNC_TEST_ADD (suitename, "gnc float txn to float txn", Fixture, NULL, setup, test_gnc_txn_to_float_txn, teardown);
- GNC_TEST_ADD (suitename, "gnc float txn to float txn cut semantics", Fixture, NULL, setup, test_gnc_txn_to_float_txn, teardown);
+ GNC_TEST_ADD (suitename, "gnc float txn to float txn cut semantics", Fixture, NULL, setup, test_gnc_txn_to_float_txn_cut_semantics, teardown);
GNC_TEST_ADD (suitename, "gnc float txn get float split", FlFixture, NULL, flsetup, test_gnc_float_txn_get_float_split, flteardown);
GNC_TEST_ADD (suitename, "gnc float txn get other float split", FlFixture, NULL, flsetup, test_gnc_float_txn_get_other_float_split, flteardown);
diff --git a/libgnucash/backend/dbi/test/test-backend-dbi-basic.cpp b/libgnucash/backend/dbi/test/test-backend-dbi-basic.cpp
index 85837fe59..9dcef907d 100644
--- a/libgnucash/backend/dbi/test/test-backend-dbi-basic.cpp
+++ b/libgnucash/backend/dbi/test/test-backend-dbi-basic.cpp
@@ -643,7 +643,7 @@ create_dbi_test_suite (const char* dbm_name, const char* url)
GNC_TEST_ADD (subsuite, "version_control", Fixture, url, setup_memory,
test_dbi_version_control, teardown);
GNC_TEST_ADD (subsuite, "business_store_and_reload", Fixture, url,
- setup_business, test_dbi_version_control, teardown);
+ setup_business, test_dbi_business_store_and_reload, teardown);
g_free (subsuite);
}
commit 5be5c58b4f7b7dd98c5a064d30cdbb57955b9767
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Thu Jan 26 14:10:51 2023 +0000
Fix memory leak in aqbanking
diff --git a/gnucash/import-export/aqb/gnc-ab-utils.c b/gnucash/import-export/aqb/gnc-ab-utils.c
index e9727ff23..f8a01f124 100644
--- a/gnucash/import-export/aqb/gnc-ab-utils.c
+++ b/gnucash/import-export/aqb/gnc-ab-utils.c
@@ -1239,7 +1239,6 @@ gnc_ab_imexporter_list (AB_BANKING* api)
pd = GWEN_PluginDescription_List2Iterator_Next(ilit))
{
AB_Node_Pair *node = NULL;
- GWEN_BUFFER *tbuf = GWEN_Buffer_new(0, 256, 0, 1);
node = g_slice_new (AB_Node_Pair);
node->name = g_strdup(GWEN_PluginDescription_GetName(pd));
commit 619f62fb0edd0c583a4c0a8e143ad1b162958b9a
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Thu Jan 26 14:10:43 2023 +0000
Fix memory leak in gnc-split-reg.c
diff --git a/gnucash/gnome/gnc-split-reg.c b/gnucash/gnome/gnc-split-reg.c
index d6c37ce17..ca24beed2 100644
--- a/gnucash/gnome/gnc-split-reg.c
+++ b/gnucash/gnome/gnc-split-reg.c
@@ -2502,7 +2502,6 @@ gnc_split_reg_determine_read_only( GNCSplitReg *gsr, gboolean show_dialog )
if ( !gsr->read_only )
{
- dialog_args *args;
char *string = NULL;
reg = gnc_ledger_display_get_split_register( gsr->ledger );
if(reg->mismatched_commodities)
@@ -2539,12 +2538,15 @@ gnc_split_reg_determine_read_only( GNCSplitReg *gsr, gboolean show_dialog )
}
}
gsr->read_only = TRUE;
- /* Put up a warning dialog */
- args = g_malloc(sizeof(dialog_args));
- args->string = string;
- args->gsr = gsr;
if (show_dialog)
+ {
+ /* Put up a warning dialog */
+ dialog_args *args = g_malloc(sizeof(dialog_args));
+ args->string = string;
+ args->gsr = gsr;
+
g_timeout_add (250, gtk_callback_bug_workaround, args); /* 0.25 seconds */
+ }
}
/* Make the contents immutable */
commit 671f14f68a713761a0ab7b982b3af6fbade0a6dd
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Thu Jan 26 14:10:36 2023 +0000
Fix memory leak in import-main-matcher.c
diff --git a/gnucash/import-export/import-main-matcher.c b/gnucash/import-export/import-main-matcher.c
index 75e92d3d7..f6a32d7b0 100644
--- a/gnucash/import-export/import-main-matcher.c
+++ b/gnucash/import-export/import-main-matcher.c
@@ -832,7 +832,7 @@ gnc_gen_trans_assign_transfer_account (GtkTreeView *treeview,
old_acc = gnc_import_TransInfo_get_destacc (trans_info);
if (*first)
{
- gchar *acc_full_name = gnc_account_get_full_name (*new_acc);
+ gchar *acc_full_name;
ok_pressed = FALSE;
*new_acc = gnc_import_select_account (info->main_widget,
NULL,
commit a2ffc7fe759cf66495204c74d365c1ba9a93c711
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Thu Jan 26 14:10:26 2023 +0000
Fix memory leak in binreloc function _br_find_exe()
Ironically, it seems to be in a code path that
is only followed when using valgrind
diff --git a/libgnucash/core-utils/binreloc.c b/libgnucash/core-utils/binreloc.c
index 828b9acc2..9e28cb667 100644
--- a/libgnucash/core-utils/binreloc.c
+++ b/libgnucash/core-utils/binreloc.c
@@ -195,6 +195,7 @@ _br_find_exe (Gnc_GbrInitError *error)
result = g_strdup (result);
fclose (f);
+ g_free (line);
return result;
#endif /* ENABLE_BINRELOC */
}
Summary of changes:
gnucash/gnome/gnc-split-reg.c | 12 +++++++-----
gnucash/import-export/aqb/gnc-ab-utils.c | 1 -
gnucash/import-export/import-main-matcher.c | 2 +-
.../ledger-core/test/utest-split-register-copy-ops.c | 2 +-
libgnucash/backend/dbi/test/test-backend-dbi-basic.cpp | 2 +-
libgnucash/core-utils/binreloc.c | 1 +
6 files changed, 11 insertions(+), 9 deletions(-)
More information about the gnucash-changes
mailing list