gnucash stable: [import-backend.cpp] inline gnc_import_TransInfo_set_match_list

Christopher Lam clam at code.gnucash.org
Sun Jul 16 11:17:01 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/7acfa1a9 (commit)
	from  https://github.com/Gnucash/gnucash/commit/49b47f9d (commit)



commit 7acfa1a9a56772e36db32a428c27a62e25f4fd18
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Jul 16 19:47:53 2023 +0800

    [import-backend.cpp] inline gnc_import_TransInfo_set_match_list
    
    Inline this function which is only used in
    gnc_import_TransInfo_remove_top_match.

diff --git a/gnucash/import-export/import-backend.cpp b/gnucash/import-export/import-backend.cpp
index fed2d51d31..7943f8603f 100644
--- a/gnucash/import-export/import-backend.cpp
+++ b/gnucash/import-export/import-backend.cpp
@@ -128,26 +128,18 @@ gnc_import_TransInfo_get_match_list (const GNCImportTransInfo *info)
     return info->match_list;
 }
 
-static void
-gnc_import_TransInfo_set_match_list (GNCImportTransInfo *info, GList* match_list)
+void
+gnc_import_TransInfo_remove_top_match (GNCImportTransInfo *info)
 {
-    g_assert (info);
-    info->match_list = match_list;
-    if (match_list)
-        info->selected_match_info.selected_match = static_cast<GNCImportMatchInfo*>(match_list->data);
+    g_return_if_fail (info);
+    info->match_list = g_list_remove (info->match_list, static_cast<gpointer>(info->match_list->data));
+    if (info->match_list)
+        info->selected_match_info.selected_match = static_cast<GNCImportMatchInfo*>(info->match_list->data);
     else
     {
         info->selected_match_info.selected_match = nullptr;
         gnc_import_TransInfo_set_action (info, GNCImport_ADD);
-    }
-}
-
-void
-gnc_import_TransInfo_remove_top_match (GNCImportTransInfo *info)
-{
-    GList* match_trans = gnc_import_TransInfo_get_match_list (info);
-    match_trans = g_list_remove (match_trans, static_cast<gpointer>(match_trans->data));
-    gnc_import_TransInfo_set_match_list (info, match_trans);
+    };
 }
 
 Transaction *



Summary of changes:
 gnucash/import-export/import-backend.cpp | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)



More information about the gnucash-changes mailing list