gnucash stable: Bug 798919 - Inconsistent signs in creating budget

Christopher Lam clam at code.gnucash.org
Sat Jun 3 20:21:40 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/d47230a4 (commit)
	from  https://github.com/Gnucash/gnucash/commit/ccc75cfc (commit)



commit d47230a4188d61605c6bb828b36e2b5dcf7d6ba2
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sun Jun 4 08:20:10 2023 +0800

    Bug 798919 - Inconsistent signs in creating budget
    
    further Reversed Balance Accounts fixes

diff --git a/gnucash/gnome/gnc-budget-view.c b/gnucash/gnome/gnc-budget-view.c
index ebfadd2818..ccde466828 100644
--- a/gnucash/gnome/gnc-budget-view.c
+++ b/gnucash/gnome/gnc-budget-view.c
@@ -1219,6 +1219,9 @@ bgv_get_total_for_account (Account *account, GncBudget *budget, gnc_commodity *n
         }
     }
 
+    if (gnc_reverse_balance (account))
+        total = gnc_numeric_neg (total);
+
     return total;
 }
 
diff --git a/gnucash/gnome/gnc-plugin-page-budget.c b/gnucash/gnome/gnc-plugin-page-budget.c
index a4966494e4..0c93bd3c02 100644
--- a/gnucash/gnome/gnc-plugin-page-budget.c
+++ b/gnucash/gnome/gnc-plugin-page-budget.c
@@ -1109,7 +1109,9 @@ allperiods_budget_helper (GtkTreeModel *model, GtkTreePath *path,
     acct = gnc_budget_view_get_account_from_path (priv->budget_view, path);
     num_periods = gnc_budget_get_num_periods (priv->budget);
     allvalue = priv->allValue;
-    allvalue = gnc_numeric_neg (allvalue);
+
+    if (gnc_reverse_balance (acct))
+        allvalue = gnc_numeric_neg (priv->allValueallvalue);
 
     for (i = 0; i < num_periods; i++)
     {



Summary of changes:
 gnucash/gnome/gnc-budget-view.c        | 3 +++
 gnucash/gnome/gnc-plugin-page-budget.c | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)



More information about the gnucash-changes mailing list