gnucash stable: Bug 798919 - Inconsistent signs in creating budget, bis

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/60e6c23a (commit)
	from  https://github.com/Gnucash/gnucash/commit/c9c8d489 (commit)



commit 60e6c23ac9711761c39b296b2f1f02d4812f386a
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Mon Jun 5 18:56:39 2023 +0800

    Bug 798919 - Inconsistent signs in creating budget, bis
    
    bgv_get_total_for_account must return the account budget total.

diff --git a/gnucash/gnome/gnc-budget-view.c b/gnucash/gnome/gnc-budget-view.c
index ccde466828..dab47171d0 100644
--- a/gnucash/gnome/gnc-budget-view.c
+++ b/gnucash/gnome/gnc-budget-view.c
@@ -1219,9 +1219,6 @@ bgv_get_total_for_account (Account *account, GncBudget *budget, gnc_commodity *n
         }
     }
 
-    if (gnc_reverse_balance (account))
-        total = gnc_numeric_neg (total);
-
     return total;
 }
 
@@ -1240,6 +1237,9 @@ budget_total_col_source (Account *account, GtkTreeViewColumn *col,
     priv = GNC_BUDGET_VIEW_GET_PRIVATE(budget_view);
 
     total = bgv_get_total_for_account (account, priv->budget, NULL);
+    if (gnc_reverse_balance (account))
+        total = gnc_numeric_neg (total);
+
     xaccSPrintAmount (amtbuff, total, gnc_account_print_info (account, TRUE));
 
     if (priv->use_red_color && gnc_numeric_negative_p (total))



Summary of changes:
 gnucash/gnome/gnc-budget-view.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)