gnucash stable: xxxgtk_textview_get_text must be g_freed after use

Christopher Lam clam at code.gnucash.org
Fri Jun 30 05:53:32 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/5e376265 (commit)
	from  https://github.com/Gnucash/gnucash/commit/833a681a (commit)



commit 5e376265e48575e064c39c4090732e9f8905d931
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jun 30 17:43:19 2023 +0800

    xxxgtk_textview_get_text must be g_freed after use

diff --git a/gnucash/gnome-utils/gnc-option-gtk-ui.cpp b/gnucash/gnome-utils/gnc-option-gtk-ui.cpp
index 9c6c725984..d766398211 100644
--- a/gnucash/gnome-utils/gnc-option-gtk-ui.cpp
+++ b/gnucash/gnome-utils/gnc-option-gtk-ui.cpp
@@ -252,7 +252,9 @@ public:
     void set_option_from_ui_item(GncOption& option) noexcept override
     {
         auto widget{GTK_TEXT_VIEW(get_widget())};
-        option.set_value(std::string{xxxgtk_textview_get_text(widget)});
+        auto str{xxxgtk_textview_get_text(widget)};
+        option.set_value(std::string{str});
+        g_free (str);
     }
 };
 



Summary of changes:
 gnucash/gnome-utils/gnc-option-gtk-ui.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)



More information about the gnucash-changes mailing list