gnucash master: Don't change report_name to "GnuCash-Report" in cdb674ebf1

Christopher Lam clam at code.gnucash.org
Mon Mar 6 20:40:21 EST 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/aa296bd7 (commit)
	from  https://github.com/Gnucash/gnucash/commit/1341511e (commit)



commit aa296bd7180cb3159b86ee967e2137cff85c6f94
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Tue Mar 7 09:28:06 2023 +0800

    Don't change report_name to "GnuCash-Report" in cdb674ebf1
    
    for PDF filename

diff --git a/gnucash/gnome/gnc-plugin-page-report.cpp b/gnucash/gnome/gnc-plugin-page-report.cpp
index d2bf4368ee..3fc55b6e05 100644
--- a/gnucash/gnome/gnc-plugin-page-report.cpp
+++ b/gnucash/gnome/gnc-plugin-page-report.cpp
@@ -1901,8 +1901,9 @@ static gchar *report_create_jobname(GncPluginPageReportPrivate *priv)
                                                                    "Report name");
         if (!report_name_str.empty())
             report_name = g_strdup(report_name_str.c_str());
-        if (report_name)
+        else
             report_name = g_strdup (_(default_jobname));
+
         if (g_strcmp0(report_name, _("Printable Invoice")) == 0
                 || g_strcmp0(report_name, _("Tax Invoice")) == 0
                 || g_strcmp0(report_name, _("Easy Invoice")) == 0



Summary of changes:
 gnucash/gnome/gnc-plugin-page-report.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)



More information about the gnucash-changes mailing list