gnucash stable: [gnc-plugin-page-report] re-enable actions after disabling

Christopher Lam clam at code.gnucash.org
Tue Nov 7 16:55:57 EST 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/b450d9a6 (commit)
	from  https://github.com/Gnucash/gnucash/commit/9e47c297 (commit)



commit b450d9a63710a5d09f1f18d9109ec034c6a7b40d
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Wed Nov 8 05:53:50 2023 +0800

    [gnc-plugin-page-report] re-enable actions after disabling
    
    Otherwise Print, PDFExport, Report Options remain disabled after
    modifying report options. Also restore nullptr sentinel in
    disable_during_load_actions array.

diff --git a/gnucash/gnome/gnc-plugin-page-report.cpp b/gnucash/gnome/gnc-plugin-page-report.cpp
index a8a58ce7e0..a700a233c2 100644
--- a/gnucash/gnome/gnc-plugin-page-report.cpp
+++ b/gnucash/gnome/gnc-plugin-page-report.cpp
@@ -210,7 +210,8 @@ static const gchar *disable_during_load_actions[] =
 {
     "FilePrintAction",
     "FilePrintPDFAction",
-    "ReportOptionsAction"
+    "ReportOptionsAction",
+    nullptr
 };
 
 /** The default menu items that need to be add to the menu */
@@ -827,7 +828,7 @@ gnc_plugin_page_report_option_change_cb(gpointer data)
     gnc_window_set_progressbar_window( nullptr );
 
     gnc_plugin_set_actions_enabled(G_ACTION_MAP(priv->action_group),
-                                   disable_during_load_actions, FALSE);
+                                   disable_during_load_actions, TRUE);
     priv->reloading = FALSE;
 }
 
@@ -1489,7 +1490,7 @@ gnc_plugin_page_report_reload_cb (GSimpleAction *simple,
     // this resets the window for the progressbar to nullptr
     gnc_window_set_progressbar_window( nullptr );
     gnc_plugin_set_actions_enabled(G_ACTION_MAP(priv->action_group),
-                                   disable_during_load_actions, FALSE);
+                                   disable_during_load_actions, TRUE);
     priv->reloading = FALSE;
 }
 



Summary of changes:
 gnucash/gnome/gnc-plugin-page-report.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)



More information about the gnucash-changes mailing list