gnucash stable: Use csv_price_imp_preview_sep_button_cb only as a callback.

John Ralls jralls at code.gnucash.org
Fri Nov 17 12:02:41 EST 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/2db3a6ba (commit)
	from  https://github.com/Gnucash/gnucash/commit/102304b3 (commit)



commit 2db3a6bad977bc4f0c6ca90b333692c32649b187
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Nov 17 09:00:48 2023 -0800

    Use csv_price_imp_preview_sep_button_cb only as a callback.
    
    Its error handling doesn't make sense in other contexts.

diff --git a/gnucash/import-export/csv-imp/assistant-csv-price-import.cpp b/gnucash/import-export/csv-imp/assistant-csv-price-import.cpp
index 3e39920cc1..ddb0a2a1e4 100644
--- a/gnucash/import-export/csv-imp/assistant-csv-price-import.cpp
+++ b/gnucash/import-export/csv-imp/assistant-csv-price-import.cpp
@@ -1811,7 +1811,14 @@ CsvImpPriceAssist::preview_refresh ()
 
         g_signal_handlers_unblock_by_func (custom_cbutton, (gpointer) csv_price_imp_preview_sep_button_cb, this);
         g_signal_handlers_unblock_by_func (custom_entry, (gpointer) csv_price_imp_preview_sep_button_cb, this);
-        csv_price_imp_preview_sep_button_cb (GTK_WIDGET(custom_cbutton), this);
+        try
+        {
+            price_imp->tokenize (false);
+        }
+        catch (std::range_error& err)
+        {
+            PERR ("CSV Tokenization Failed: %s", err.what ());
+        }
     }
     // Repopulate the parsed data table
     g_idle_add ((GSourceFunc)csv_imp_preview_queue_rebuild_table, this);



Summary of changes:
 gnucash/import-export/csv-imp/assistant-csv-price-import.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)



More information about the gnucash-changes mailing list