gnucash stable: Bug 799075 - Saving display tab changes in Report Options does not work.

John Ralls jralls at code.gnucash.org
Tue Sep 5 19:46:47 EDT 2023


Updated	 via  https://github.com/Gnucash/gnucash/commit/4206300d (commit)
	from  https://github.com/Gnucash/gnucash/commit/4ffe1082 (commit)



commit 4206300dce7ce52e2df4e6a3c5ebecdc53041930
Author: John Ralls <jralls at ceridwen.us>
Date:   Tue Sep 5 16:42:48 2023 -0700

    Bug 799075 - Saving display tab changes in Report Options does not work.
    
    When altering a library report option change the default value, not
    the value so that the option system recognizes user changes correctly.

diff --git a/gnucash/report/reports/standard/reconcile-report.scm b/gnucash/report/reports/standard/reconcile-report.scm
index dab4b5c461..d102eb9a98 100644
--- a/gnucash/report/reports/standard/reconcile-report.scm
+++ b/gnucash/report/reports/standard/reconcile-report.scm
@@ -33,26 +33,26 @@
 
 (define (reconcile-report-options-generator)
   (let ((options (gnc:trep-options-generator)))
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options "Sorting" "Primary Key") 'reconciled-status)
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options "Sorting" "Secondary Key")   'date)
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options "Sorting" "Secondary Subtotal for Date Key") 'none)
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options gnc:pagename-general "Start Date")
      (cons 'relative 'start-prev-quarter))
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options gnc:pagename-general "End Date")
      (cons 'relative 'today))
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options gnc:pagename-general "Date Filter")
      'reconciled)
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options gnc:pagename-display "Reconciled Date") #t)
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options gnc:pagename-display "Running Balance") #f)
-    (GncOption-set-value
+    (GncOption-set-default-value
      (gnc-lookup-option options gnc:pagename-display "Memo") #f)
     (GncOptionDBPtr-make-internal options gnc:pagename-display "Running Balance")
     options))



Summary of changes:
 gnucash/report/reports/standard/reconcile-report.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)



More information about the gnucash-changes mailing list