gnucash stable: Loan Assistant: Partly fix payments per year.

[John Ralls]

Updated	 via  https://github.com/Gnucash/gnucash/commit/e0cd75c1 (commit)
	from  https://github.com/Gnucash/gnucash/commit/10d51954 (commit)



commit e0cd75c12ddb754d401457d69fe7caf1975a53b0
Author: John Ralls <jralls at ceridwen.us>
Date:   Sat May 3 18:30:29 2025 -0700

    Loan Assistant: Partly fix payments per year.
    
    Hard-code to 12 for now. That's wrong unless it's monthly payments,
    but the actual number of payments isn't currently known until after the
    formulas are calculated.

diff --git a/gnucash/gnome/assistant-loan.cpp b/gnucash/gnome/assistant-loan.cpp
index 0765945b67..2fa47c93af 100644
--- a/gnucash/gnome/assistant-loan.cpp
+++ b/gnucash/gnome/assistant-loan.cpp
@@ -2413,22 +2413,22 @@ loan_get_formula_internal( LoanAssistantData *ldd, GString *gstr, const gchar *t
         period_rate = pass_thru_rate;
         break;
     case GNC_IRATE_APR_DAILY:
-        period_rate = loan_apr_to_simple_formula (pass_thru_rate, periods, 365);
+        period_rate = loan_apr_to_simple_formula (pass_thru_rate, 12, 365);
         break;
     case GNC_IRATE_APR_WEEKLY:
-        period_rate = loan_apr_to_simple_formula (pass_thru_rate, periods, 52);
+        period_rate = loan_apr_to_simple_formula (pass_thru_rate, 12, 52);
         break;
     case GNC_IRATE_APR_MONTHLY:
-        period_rate = loan_apr_to_simple_formula (pass_thru_rate, periods, 12);
+        period_rate = loan_apr_to_simple_formula (pass_thru_rate, 12, 12);
         break;
     case GNC_IRATE_APR_QUARTERLY:
-        period_rate = loan_apr_to_simple_formula (pass_thru_rate, periods, 4);
+        period_rate = loan_apr_to_simple_formula (pass_thru_rate, 12, 4);
         break;
     case GNC_IRATE_APR_SEMIANNUALLY:
-        period_rate = loan_apr_to_simple_formula (pass_thru_rate, periods, 2);
+        period_rate = loan_apr_to_simple_formula (pass_thru_rate, 12, 2);
         break;
     case GNC_IRATE_APR_ANNUALLY:
-        period_rate = loan_apr_to_simple_formula (pass_thru_rate, periods, 1);
+        period_rate = loan_apr_to_simple_formula (pass_thru_rate, 12, 1);
         break;
     default:
         period_rate = ldd->ld.interestRate / 100;



Summary of changes:
 gnucash/gnome/assistant-loan.cpp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)