gnucash stable: [Transaction.cpp] null check before accessing struct member

Christopher Lam clam at code.gnucash.org
Thu Aug 6 10:38:16 EDT 2026


Updated	 via  https://github.com/Gnucash/gnucash/commit/a4f69f44 (commit)
	from  https://github.com/Gnucash/gnucash/commit/c935c2fb (commit)



commit a4f69f44a79d467a98ed92f56ad2738f3174f2a6
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Thu Aug 6 22:27:34 2026 +0800

    [Transaction.cpp] null check before accessing struct member

diff --git a/libgnucash/engine/Transaction.cpp b/libgnucash/engine/Transaction.cpp
index 67e28e75cc..56d3c59dfa 100644
--- a/libgnucash/engine/Transaction.cpp
+++ b/libgnucash/engine/Transaction.cpp
@@ -1324,8 +1324,9 @@ split_set_new_value(Split* split, gnc_commodity *curr, gnc_commodity *old_curr,
 void
 xaccTransSetCurrency (Transaction *trans, gnc_commodity *curr)
 {
-    gnc_commodity *old_curr = trans->common_currency;
     if (!trans || !curr || trans->common_currency == curr) return;
+
+    gnc_commodity *old_curr = trans->common_currency;
     xaccTransBeginEdit(trans);
 
     trans->common_currency = curr;



Summary of changes:
 libgnucash/engine/Transaction.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)



More information about the gnucash-changes mailing list