gnucash stable: [html-chart.scm] each chart must isolate its vars and helper fns

Christopher Lam clam at code.gnucash.org
Sun Aug 16 00:01:47 EDT 2026


Updated	 via  https://github.com/Gnucash/gnucash/commit/0de89eec (commit)
	from  https://github.com/Gnucash/gnucash/commit/6079615b (commit)



commit 0de89eecba0c3ae8581bd149412d989c696bdd8b
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Aug 15 22:19:06 2026 +0800

    [html-chart.scm] each chart must isolate its vars and helper fns
    
    by wrapping them inside an Immediately Involed Function Expression.

diff --git a/gnucash/report/html-chart.scm b/gnucash/report/html-chart.scm
index 541495c135..d8a8fdfa10 100644
--- a/gnucash/report/html-chart.scm
+++ b/gnucash/report/html-chart.scm
@@ -471,6 +471,7 @@ document.getElementById(chartid).onclick = function(evt) {
     (push (format #f "<canvas id=~s></canvas>\n" id))
     (push "</div>\n")
     (push (format #f "<script id='script-~a'>\n" id))
+    (push "(function () {\n")
     (push (format #f "var curriso = ~s;\n" (gnc:html-chart-currency-iso chart)))
     (push (format #f "var currsym = ~s;\n" (gnc:html-chart-currency-symbol chart)))
     (push (format #f "var formsty = ~s;\n" (gnc:html-chart-format-style chart)))
@@ -493,6 +494,7 @@ document.getElementById(chartid).onclick = function(evt) {
     (push JS-setup)
 
     (push "var myChart = new Chart(chartid, chartjsoptions);\n")
+    (push "})();\n")
     (push "</script>")
 
     retval))



Summary of changes:
 gnucash/report/html-chart.scm | 2 ++
 1 file changed, 2 insertions(+)



More information about the gnucash-changes mailing list