gnucash stable: [gnc-commodity.cpp] gnc_quote_source_num_entries speedup

Christopher Lam clam at code.gnucash.org
Fri Jun 19 04:37:59 EDT 2026


Updated	 via  https://github.com/Gnucash/gnucash/commit/54693abe (commit)
	from  https://github.com/Gnucash/gnucash/commit/368b2894 (commit)



commit 54693abe30eef0b7414958847580efa45e914e9d
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jun 19 16:09:25 2026 +0800

    [gnc-commodity.cpp] gnc_quote_source_num_entries speedup
    
    previously was allocating a vector copy, and measuring the distance
    manually. return std::list size() which is maintained internally.

diff --git a/libgnucash/engine/gnc-commodity.cpp b/libgnucash/engine/gnc-commodity.cpp
index 4295f8750d..943db0c702 100644
--- a/libgnucash/engine/gnc-commodity.cpp
+++ b/libgnucash/engine/gnc-commodity.cpp
@@ -301,8 +301,7 @@ get_quote_source_from_type (QuoteSourceType type)
  ********************************************************************/
 gint gnc_quote_source_num_entries(QuoteSourceType type)
 {
-    auto source{get_quote_source_from_type(type)};
-    return std::distance(source.begin(), source.end());
+    return get_quote_source_from_type(type).size();
 }
 
 



Summary of changes:
 libgnucash/engine/gnc-commodity.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)



More information about the gnucash-changes mailing list