Euro conversion druid -- please test it extensively now

[Christian Stimming]

-----BEGIN PGP SIGNED MESSAGE-----

On Monday 10 December 2001 10:00 pm, Herbert Thoma wrote:
> I have one stock account which is still in DEM. The Euro converter
> subtracts the money amount (share amount * share price) from the share
> amount, i.e.: there are 2 shares worth 300 DEM each, total 600 DEM, after
> the conversion there are -598 shares in this account.

I understand the problem -- in druid-euro-conv.c:263 the converter just sets 
both the Value and the Amount to the account's current balance:

amount = xaccAccountGetBalance(old_account);
xaccSplitSetAmount (split, gnc_numeric_neg(amount));
xaccSplitSetValue (split, gnc_numeric_neg(amount));

But what else should it do? Hm, maybe it could test whether account_type = 
{STOCK,MUTUAL}, and if that's the case, it could 
SetAmount(xaccAccountGetShareBalance(old_account)) . In fact, I'll just 
implement that one. The patch goes into CVS in a minute.

Herbert, do you think that would be more appropriate?

> - It would be nice, if I could use my existing DEM-EUR conversion currency
>   account insted of creating a new one.

Err, that's a harder one. How could you tell which one to use? You would need 
another druid page with an account selection box, where you could either 
select the exchange account to use or you choose 'create new exchange 
account'. Err, I'm rather busy with my MS thesis  (due in 7 days) and I'm not 
quite willing to do this extra GUI work -- sorry.

Thanks for the feedback, anyway.

Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.5 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iQCVAwUBPBUsMmXAi+BfhivFAQE59gP/UPxX0HlbuWUr9cyg8uR3TLydmo7Dcqb/
TqozPrLwQqY5hAQAgSzqOpU8D2YZpFt6dEhZQJQG7pka1AsZq5QtWgptIvrk9taC
CE0EQ0YDUeQOITmYvc0IVDli5DHiZY5taaUiaNsq4E7/F+aqTZMRjeX62DnzQdEQ
P+sYuXSUsIQ=
=QaZr
-----END PGP SIGNATURE-----