currency clarification

Christian Stimming stimming@uclink.berkeley.edu
Thu, 22 Feb 2001 21:29:22 -0800


-----BEGIN PGP SIGNED MESSAGE-----

In a recent chat with goonie, it appeared to me that our consensus on the 
currency/commodity in the account/transaction/split structures is still 
unclear to most developers. Therefore I cleaned up all the respective 
comments in the header files, see attached patch. Additionally, I 
recovered grib's mail from last October which is the best summary of our 
new policy. I think src/doc/currencies.txt is a good place for that.

BUT I have a request. Each split will store two amounts, value and 
damount[1]. The function to get those two amounts are xaccSplitGetValue 
and xaccSplitGetShareAmount (for damount). I *don't like* the latter name! 
Since the latter function will be getting used in a lot of places which 
don't relate to what we know as shares at all, I would rather like to have 
it renamed to SplitGetDAmount (referring to the fieldname) or just 
SplitGetAmount. What do people think?

Christian

[1] 'value' is the amount of the transaction balancing commodity (i.e. 
currency) involved, 'damount' is the amount of the account's commodity 
(formerly known as 'security') involved.
-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
Charset: noconv

iQCVAwUBOpX1M2XAi+BfhivFAQG96wQAtMc077c7TdRKi9KwAQy9f4LmITx4JDvA
9PHZTQeXasC3CR1bEXSO0BJBumfyEhTBg+hTD91mc+pGQdSj7god6tStjA+8Gmx8
MFS2LXSjvb67XgGi3dcW53cezxVqOofqxRBcdYN/Acd9BH8EKPGgn56vlIAPToRf
W0UZECKtYDo=
=sw4G
-----END PGP SIGNATURE-----