fopen doesn't check for errors in io-gncxml-v2.c & io-example-account.c

Peter O'Gorman peter@pogma.com
Thu, 24 Jan 2002 13:51:57 +0900


These are against 1.6.5 (sorry)

Peter


diff -Naur ../../../gnucash-1.6.5.old/src/engine/io-gncxml-v2.c 
./io-gncxml-v2.c
--- ../../../gnucash-1.6.5.old/src/engine/io-gncxml-v2.c        
Mon Sep  3 05:31:52 2001
+++ ./io-gncxml-v2.c    Thu Jan 24 13:33:32 2002
@@ -505,6 +505,10 @@
      FILE *out;

      out = fopen(filename, "w");
+    if (NULL==out)
+    {
+        return FALSE;
+    }

      fprintf(out, "<?xml version=\"1.0\"?>\n");
      fprintf(out, "<" GNC_V2_STRING ">\n");
diff -Naur ../../../gnucash-1.6.5.old/src/engine/io-example-
account.c ./io-example-account.c
--- ../../../gnucash-1.6.5.old/src/engine/io-example-account.c  
Wed May 16 00:49:10 2001
+++ ./io-example-account.c      Thu Jan 24 13:47:22 2002
@@ -316,6 +317,10 @@
      FILE *out;

      out = fopen(filename, "w");
+    if (NULL==out)
+    {
+        return FALSE;
+    }

      fprintf(out, "<?xml version=\"1.0\"?>\n");
      fprintf(out, "<" GNC_ACCOUNT_STRING ">\n");



On Thursday, January 24, 2002, at 01:39  PM, Derek Atkins wrote:

> Unlikely..  Feel free to send patches, either against 1.6 or the
> head.  (patches against the head preferred).
>
> -derek
>