Recent patches break Solaris

[Derek Atkins]

In general I would agree with you, except in this particular case
'foo' is not user-defined, but defined previously by the system..

-derek

Kevin Benton <KevinB@webex.com> writes:

> Not to mention
> 
> if test $foo = no; then
> 
> is a serious security hole.  It should be re-written as 
> 
> if test "$foo" = no; then
> 
> to prevent carefully crafted security hacks.  It's also commonly acceptable
> (and often more readable) to write...
> 
> if [ "$foo" = no ]; then
> 
> Kevin Benton
> Denver Operations Manager
> 
> A defect is any instance or event in which the product or process fails to
> meet a customer requirement - The Six Sigma Way.
> 
> This email may contain information that is Confidential and Proprietary to
> WebEx Communications, Inc., and should be disclosed only the WebEx employees
> with a need to know. If you are not the intended recipient of this message,
> please immediately destroy any and all paper and electronic copies.  Please
> also notify the sender that this misdirection happened.  Disclosure,
> copying, or other action taken in respect to this email or in reliance on it
> is prohibited.
> 
> WebEx Communications, Inc. accepts no liability in relation to any personal
> emails, or any content of any email that does not relate directly to the
> business of WebEx Communications, Inc.
> 
> 
> -----Original Message-----
> From: Derek Atkins [mailto:warlord@MIT.EDU]
> Sent: Tuesday, May 07, 2002 10:21 PM
> To: hampton@linas.org
> Cc: gnucash-devel@lists.gnucash.org
> Subject: Recent patches break Solaris
> 
> 
> The recent batches of checkins broke the build on Solaris
> (yet again!).  I'm in the process of fixing it (yet again!)
> but would appreciate it if people were more careful when
> testing a patch.
> 
> In particular, this is _NOT_ valid sh syntax:
>         if test $foo=no; then
> 
> it needs to be:
>         if test $foo = no; then
> 
> Yes, the spaces actually matter!  I'll check in a patch for this soon.
> However...  There also appears to be a problem in that on Solaris it's
> trying to libk agains libc-missing.a, but said lib does not exist....
> This is REALLY REALLY broken!  BLAH!
> 
> -derek
> -- 
>        Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>        Member, MIT Student Information Processing Board  (SIPB)
>        URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>        warlord@MIT.EDU                        PGP key available
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel@lists.gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel@lists.gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord@MIT.EDU                        PGP key available