CVS update: gnucash/src/import-export

Christian Stimming stimming@tuhh.de
Mon, 25 Nov 2002 12:55:22 +0100


Benoit Gr?goire wrote:

> Log Message:
> 2002-11-25  Benoit Grégoire  <bock@step.polymtl.ca>
> 	* src/import-export/gnc-gen-transaction.c:  Use the more feature

>	 complete Account-matcher.h from the generic import module instead
> 	 of dialog-account-pick.h.  Christian, tell me you didn't implement
> 	a fourth account picker from scratch. 

No I didn't :-) but good that you ask. The dialog-account-pick already 
existed in the HBCI module, i.e. I wrote it ~3 months ago by copying 
from the qif-importer's dialog-account-picker, and only recently moved 
it to a common location. The dialog-account-pick is still being used in 
the HBCI Setup druid.

If your Account-matcher dialog is able to do the same thing but offering 
more features, it might be an option to move the Account-matcher code to 
a common generic location (src/gnome-utils) and using only that one for 
account picking.

The qif-importer's account picker, however, is a bit more specialized 
since if you click "create new account" there then a new account is 
*not* created in the actual account tree but in the qif-importer's own 
duplicated account tree. The actual account in the 'real' tree is only 
created when you click 'Finish' in the druid. Clear benefit: If you 
cancel the druid, none of the 'created accounts' will suddenly show up 
in the real account tree. Downside: This is almost impossible to 
implement in a generic way. That's why the qif-importer will probably 
continue to have its own account picker.

Christian