QOF merge code ready
Linas Vepstas
linas at linas.org
Thu Aug 26 00:13:30 EDT 2004
Looks good to me.
Check it in ...
This is going into the qof.sourceforge.net cvs. If its not too
much trouble, make a corresponding patch for gnucash.org
One minor comment:
Carefule with adding documetnation like this:
> +/** QofIdType declaration */
> typedef const char * QofIdType;
> +/** QofIdTypeConst declaration */
> typedef const char * QofIdTypeConst;
>
> #define QOF_ID_NONE NULL
> @@ -112,10 +114,25 @@ typedef const char * QofIdTypeConst;
> (obj); \
> }))
>
> -
> +/** QofEntity declaration */
> typedef struct QofEntity_s QofEntity;
> +/** QofCollection declaration
> +
> + at param e_type QofIdType
> + at param is_dirty gboolean
> + at param hash_of_entities GHashTable
> + at param data gpointer, place where object class can hang arbitrari data
> +
> +*/
> typedef struct QofCollection_s QofCollection;
This doesn't seem to contain any information that isn't already in the
C code. i.e. just reading teh C code will tell you everything here
already. So I'm not to thrilled with this, it just clutters things
up needlessly, wihtout adding value. Something better may have been:
'is_dirty is a boolean flag that, when set indicates that the object
has been modified but has not yet been saved to disk.' That's
something you wouldn't get by reading the header file.
Let this one slide, but in general don't do this unless there's
real true value add.
--linas
--
pub 1024D/01045933 2001-02-01 Linas Vepstas (Labas!) <linas at linas.org>
PGP Key fingerprint = 8305 2521 6000 0B5E 8984 3F54 64A9 9A82 0104 5933
More information about the gnucash-devel
mailing list