gcc4 compile fixes in bugzilla.gnome #162582

[Derek Atkins]

John Ellson <ellson at research.att.com> writes:

> I just posted a patch in:
>     http://bugzilla.gnome.org/show_bug.cgi?id=162582
> to fix (or at least, workaround) the many additional warnings
> generated by gcc4
> when compiling gnucash from cvs head on Fedora development (FC3+).
>
> I hope this is a suitable method for contributing patches to gnucash?

Works just fine.  Just make sure in the future you add "PATCH" to the
keywords.

I didn't even know that gcc4 was released, yet.

Also, I've looked at the patch -- it seems to add a bunch of casts.  I
really don't think those casts are necessary, and in many cases an
explicit cast that hide bugs.  Perhaps there's another way to fix the
compiler warnings?

> John Ellson

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available