[Gnucash-changes] QOF/CashUtil Sync: Engine

[Neil Williams]

On Wednesday 17 August 2005 1:43 pm, Derek Atkins wrote:
> > Index: FreqSpec.c
> > ===================================================================
> > RCS file: /home/cvs/cvsroot/gnucash/src/engine/FreqSpec.c,v
> > @@ -74,7 +74,6 @@
> >  \********************************************************************/
>
> [snip]

That snip really confused me initially - I was looking in the wrong part of 
the file!

> >      /* This is displayed instead of the number of the day of month. */
> > -    g_string_sprintf(str, _( "last day"));
> > +    g_string_sprintf(str, (char*)_( "last day"));
> >    }
>
> What's the point of this cast (and similar casts in this file)?

I was getting compiler errors that halted the build on Mac OSX - complaining 
about a change of sign.

I've done a lot on the CashUtil compiler error flags in configure.in this 
morning and I now cannot reproduce the error with the cast removed.

I will continue to investigate but I suspect I may have been the victim of the 
very problem you describe with too many casts - it hid something else that 
was actually the cause of the report.

Regarding Transaction.c:

> Instead of adding new functions here I think it would've been
> better to just add the begin_edit/commit_edit around the
> description and notes fields.  IMHO it's a bug that they
> don't have begin/commit.

OK, I'll do that.

-- 

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20050817/5b8707da/attachment.bin