[PATCH] Fixes sentinel warnings on GCC4

Derek Atkins warlord at MIT.EDU
Mon Dec 5 22:34:40 EST 2005


Quoting Chris Shoemaker <c.shoemaker at cox.net>:

> On Mon, Dec 05, 2005 at 10:09:10PM -0500, David Hampton wrote:
>> On Mon, 2005-12-05 at 21:25 -0500, Chris Shoemaker wrote:
>>
>> > The #define NULL 0 case is explicitly allowed by the ISO C standard,
>> > and it's easy to write portable code that works for that case, so why
>> > wouldn't we?
>>
>> I don't know for sure, but I strongly suspect that our code is already
>> limited to compiling with the gnu tool chain.  Given that gcc seems to
>> do the right thing where NULL is concerned, I feel no need to do
>> anything more than add a note that gcc is required to compile gnucash.
>> I've got too many other dragons to slay.
>
> Fair enough.  I'll grab the original patch, remove redundant portions
> and apply it.  I'm convinced it's correct.  I figure it's easier to
> follow the standard than to figure out what weird systems people
> compile GnuCash on.  ( I don't even want to hazard a guess. )

Is the patch actually required?   Nobody else can reproduce the
problem on 32- or 64-bit platforms...

> -chris

-derek
-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available



More information about the gnucash-devel mailing list