[Gnucash-changes] r12132 - gnucash/trunk - Don't chown() the owner,

[Derek Atkins]

Christian Stimming <stimming at tuhh.de> writes:

> Chris Shoemaker schrieb:
>> On Mon, Dec 05, 2005 at 03:39:35PM -0500, Christian Stimming wrote:
>>
>>> #if VFAT_DOESNT_SUCK /* chown always fails on vfat fs */
>>>-                g_free(tmp_name);
>>>-                return FALSE;
>>>+                /* g_free(tmp_name);
>>>+		   return FALSE; */
>>> #endif
>> Is this your prediction that VFAT will never not suck?  :)
>
> No, my point is written just two lines ahead of these ones: A failed 
> chown doesn't mean that the saving itself failed. So don't abort with an 
> error here!

You should check the errno value.  If the errno is ENOENT
then the saving failed.  If the errno is EPERM then we shouldn't
abort with an error..

> Christian

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available