[Gnucash-changes] r12197 - gnucash/trunk/src/engine - remove random qof_commit_edit from xaccSplitSetSlots_nc

[Chris Shoemaker]

On Thu, Dec 29, 2005 at 12:27:21AM -0500, Derek Atkins wrote:
> If it's unbalanced, the proper fix here is to add a begin_edit,
> not to remove the commit_edit.

Nope.  SplitSetters don't do their own begin/commit.  It's a
bug.

-chris

> 
> -derek
> 
> Quoting Chris Shoemaker <chris at cvs.gnucash.org>:
> 
> >Modified: gnucash/trunk/src/engine/Transaction.c
> >===================================================================
> >--- gnucash/trunk/src/engine/Transaction.c	2005-12-29 05:18:07 UTC 
> >(rev 12196)
> >+++ gnucash/trunk/src/engine/Transaction.c	2005-12-29 05:21:02 UTC 
> >(rev 12197)
> >@@ -649,7 +649,6 @@
> >  }
> >
> >  s->kvp_data = frm;
> >-  qof_commit_edit(&s->parent->inst);
> >}
> 
> -- 
>       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>       Member, MIT Student Information Processing Board  (SIPB)
>       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>       warlord at MIT.EDU                        PGP key available
>