ChangeLog policy (Re: r12219 - gnucash/trunk/src - Move functions from GncPluginPageAccountTree to GncTreeViewAccount)

[Christian Stimming]

Hi Chris,

thanks for this nice work. It's certainly good if common functionality can be 
moved to a place where it belongs even better.

However, I would kindly like to ask that you stick to gnucash's so-far 
convention and add some entry to the ChangeLog file -- especially for stuff 
like "move functions xy from file a to file b", and especially when there's a 
recent ChangeLog entry that talks about precisely those functions xy. 
(hampton on 2005-12-29: "src/gnome/gnc-plugin-page-account-tree.c ...:  
Migrate the account page options to a new "Filter By" dialog. " -- I tried to 
double-check some translations and was rather surprised/annoyed not to find 
any of those functions in that file or directory anymore.) 

We all know that you've proposed a different approach to ChangeLog handling 
and this has been discussed before, but there was no final conclusion and/or 
consensus about a new policy. Therefore I would kindly ask that we do 
continue the old policy as long as we don't have agreed on a new one. And 
"moving stuff from file a to file b" is certainly that kind of ChangeLog 
notes that should be collected in a central file, because that's where 
developers look up the latest changes (or at least that's what I used to do 
and would like to do in the future). 

And no, from looking at http://svn.gnucash.org/trac/timeline I cannot 
immediately see that hampton's "new Filter-By dialog" is now no longer in 
gnc-plugin-page-account-tree.c but in a different file instead. Even if I run 
"make ChangeLog.svn" then the (to me) important information "stuff was moved 
from file a to file b" is lost in all kinds of minor tweaks here and there. 
IMHO when looking at ChangeLog.svn about 10% of the actual commits affect 
other developers in a way that should be documented, and the rest of the 
commits don't and don't need to be documented more than the SVN commit 
message. The process of manually adding an entry to the ChangeLog file IMHO 
precisely offers this filtering step, so that "ChangeLog" is basically 
"ChangeLog.svn minus noise". That's why I still stick with the previous 
ChangeLog policy of gnucash.

Christian

Am Samstag, 31. Dezember 2005 05:47 schrieb Chris Shoemaker:
> Author: chris
> Date: 2005-12-30 23:47:52 -0500 (Fri, 30 Dec 2005)
> New Revision: 12219
> Trac: http://svn.gnucash.org/trac/changeset/12219
>
> Modified:
>    gnucash/trunk/src/gnome-utils/gnc-tree-view-account.c
>    gnucash/trunk/src/gnome-utils/gnc-tree-view-account.h
>    gnucash/trunk/src/gnome/gnc-plugin-page-account-tree.c
>    gnucash/trunk/src/gnome/gnc-plugin-page-account-tree.h
> Log:
> Move functions from GncPluginPageAccountTree to GncTreeViewAccount
>
> The reason GncPluginPageBudget keeps wanting to use functions in
> GncPluginPageAccountTree is that they both use GncTreeViewAccount.
>
> So, we're moving those functions (the account view filter functions
> and the account view save/restore functions) into
> gnc-tree-view-account.  Along the way, we're also narrowing the
> argument types from GtkTreeView to GncTreeViewAccount to avoid
> unnecessary down-casting.