Dirty entity identification.

David Hampton hampton-gnucash at rainbolthampton.net
Fri Jul 22 13:35:32 EDT 2005

On Fri, 2005-07-22 at 09:10 +0100, Neil Williams wrote:

> The book reports as dirty if the collections are dirty. As there are so few 
> collections, it makes more sense to check each collection when asked rather 
> than continuously set the book dirty flag every time another collection has 
> changed.
> It's retrospective, not prospective. I see no need to check or set the book 
> dirty flag every single time a single entity is changed, again and again and 
> again throughout the entire session. Propagating the flag to the collection 
> is sufficient.

So why have a book dirty flag at all?  If you have the flag, you must
insure it reflects the state of the system.  I'm not saying you have to
set the flag every time a change is made, just that you ensure that the
flag *always* reflects the state of the underlying collections.  If it
doesn't do that then the code is broken.

Once you've ensure that the book flag correctly reflects the state of
the collections, what's the point of running the collections in
qok_book_not_saved()?  Its redundant work.


More information about the gnucash-devel mailing list