gnc_gconf_toolbar_detachable

[David Hampton]

On Fri, 2005-06-03 at 13:18 -0400, Chris Shoemaker wrote:
> On Fri, Jun 03, 2005 at 12:39:44PM -0400, David Hampton wrote:
> > On Fri, 2005-06-03 at 12:19 -0400, Chris Shoemaker wrote:
> > > I did recently add --enable-doxygen and --disable-error-on-warning to
> > > my autogen line.  Let me remove them and retry...
> > 
> > Why would you want to turn off error-on-warning?
> 
> Basically, I don't want my compile to fail when the warnings are from
> -Wunused.  My old solution was to comment the Wunused out of the
> configure.in file, but I thought this was cleaner.  Is there a better
> way?

You'll also miss any other warning message that gets lost in the
voluminous make output.  (Been there, done that.  Compilation ran to
completion, fired up gnucash and watched it die horribly, wondered why
the ^%$# the compiler didn't catch the problem, then discovered someone
had turned off -Werror.  Its happened to me more than once.)  If you're
just worried about unused declarations I'd stick with the configure.in
hack to remove -Wunused (or add -Wno-unused).

I'd appreciate it if you'd always do a final compile with -Werror
enabled before submitting patches, as that is the default for compiling
gnucash.  If not, anyone who tests your patch might get hit by the very
compile warnings you chose to ignore.

David