OSX problems with 64bit patch (was Re: libgsf, goffice and gnucash)

[Neil Williams]

On Sunday 20 November 2005 5:37 pm, David Hampton wrote:
> On Sun, 2005-11-20 at 17:25 +0000, Neil Williams wrote:
> > Mac OSX requires that the 'z' is dropped for ssize_t.
> >
> > Debian appears not to care which way it goes, I just removed the 'z' from
> > each line and recompiled - no errors, no problems.
> >
> > Are you happy for me to commit this change, David?
>
> IIRC, the original reason the 'z' was added was a problem with 64 bit
> systems, and I don't have any of those to test with.  :-(

Yes, it was Revision 11941, Scott Oonk's patch for x86_64 compile warnings.

Scott - I can't use your patch on OSX. Can we try another method?

Derek did originally advise the quick hack I used initially:
https://lists.gnucash.org/pipermail/gnucash-devel/2005-November/014764.html
"I would suggest you just add
(int) to cast the 'written' variables in the error printf."

Scott, could you test this patch:

Index: gnc-gkeyfile-utils.c
===================================================================
--- gnc-gkeyfile-utils.c        (revision 11984)
+++ gnc-gkeyfile-utils.c        (working copy)
@@ -122,11 +122,11 @@
     success = FALSE;
     if (error) {
       *error = g_error_new(G_FILE_ERROR, g_file_error_from_errno(errno), 
-                          "File %s truncated (provided %d, written %zd)",
-                          filename, length, written);
+                          "File %s truncated (provided %d, written %d)",
+                          filename, length, (int)written);
     } else {
-      g_critical("File %s truncated (provided %d, written %zd)",
-             filename, length, written);
+      g_critical("File %s truncated (provided %d, written %d)",
+             filename, length, (int)written);
     }
     /* Ignore any error */
     close(fd);

Thanks.

-- 

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20051120/512dd87d/attachment.bin