[patch 00/15] Initial batch of non-budget-related patches

c.shoemaker at cox.net c.shoemaker at cox.net
Mon Oct 10 10:34:22 EDT 2005


Ok, I'm firing this off in a hurry... possibly won't be available for 
next ~8 hrs.

Please pay special attention to makedist patch as I've just started this 
work, and I'm not sure it's on right track.

-chris

Begin Log:

**************************makedist.diff*************************
Subject: [patch 00/15] [makedist.diff] initial attempt at getting make dist to succeed

 * configure.in:
   - remove from AC_OUTPUT Makefiles that aren't distributed.

 * lib/goffice/Makefile.am                   |    2 
 * lib/goffice/split/Makefile.am             |   16 +
   - add needed header files to EXTRA_DIST and SOURCES
 
 * Makefile.am                               |    5 
   - drop 'm4' from SUBDIRS
   - drop 'config.rpath' from EXTRA_DIST

 * macros/autogen.sh                         |    2 
   - only use a single configure.in instead of searching for all
   - same for macros directory

 * src/engine/Makefile.am                    |    4 
 * src/import-export/Makefile.am             |    2 
 * src/Makefile.am                           |    4 
 * src/backend/Makefile.am                   |    2 
 * doc/Makefile.am                           |    3 
   - added files to EXTRA_DIRS, DIST_SUBDIRS, HEADERS as needed.

 * make-gnucash-potfiles.in                  |    2 
   - keep file list sorted

 * po/POTFILES.in                            |  999 ++++++++++++++++--------------
   - refresh

 * src/business/business-core/gncBusPeriod.c |    4 
   - comment out comments

 * po/ChangeLog:
   - added new empty file to keep 'make dist' happy.

 Makefile.am                               |    5 
 configure.in                              |    4 
 doc/Makefile.am                           |    3 
 lib/goffice/Makefile.am                   |    2 
 lib/goffice/split/Makefile.am             |   16 +
 macros/autogen.sh                         |    4 
 make-gnucash-potfiles.in                  |    2 
 po/ChangeLog                              |    1 
 po/POTFILES.in                            |  341 +++++++++++++++++++-----------
 src/Makefile.am                           |    4 
 src/backend/Makefile.am                   |    2 
 src/business/business-core/gncBusPeriod.c |    4 
 src/engine/Makefile.am                    |    4 
 src/import-export/Makefile.am             |    2 
 14 files changed, 251 insertions(+), 143 deletions(-)

**************************inlines.diff*************************
Subject: [patch 00/15] [inlines.diff] fix the linking problems caused by G_INLINE_FUNC

* src/app-utils/gnc-ui-util.c                 |    2 +-
* src/business/business-core/gncAddress.c     |    3 +--
* src/business/business-core/gncCustomer.c    |    3 +--
* src/business/business-core/gncEmployee.c    |    3 +--
* src/business/business-core/gncEntry.c       |    3 +--
* src/business/business-core/gncJob.c         |    3 +--
* src/business/business-core/gncOrder.c       |    3 +--
* src/business/business-core/gncVendor.c      |    3 +--
* src/engine/Account.c                        |    2 +-
* src/engine/Transaction.c                    |   11 +++++------
* src/register/register-gnome/gnucash-grid.c  |    2 +-
* src/register/register-gnome/gnucash-sheet.c |    2 +-
   - This patch fixes linking errors that I was getting from the use
     of G_INLINE_FUNC.  I think that what was happening was that the
     G_INLINE_FUNC macro was expanding to 'extern inline' even in the
     function definition.  Evidentally, in that case, the symbol has 
     external linkage and is marked as undefined in the object's symbol
     table.  My approach to fix this is to remove G_INLINE_FUNC from
     function definitions, while leaving it on function declarations.  I
     don't know if this prevents inlines, but it at least marks the symbol
     as defined which lets me link the objects.


 src/app-utils/gnc-ui-util.c                 |    2 +-
 src/business/business-core/gncAddress.c     |    3 +--
 src/business/business-core/gncCustomer.c    |    3 +--
 src/business/business-core/gncEmployee.c    |    3 +--
 src/business/business-core/gncEntry.c       |    3 +--
 src/business/business-core/gncJob.c         |    3 +--
 src/business/business-core/gncOrder.c       |    3 +--
 src/business/business-core/gncVendor.c      |    3 +--
 src/engine/Account.c                        |    2 +-
 src/engine/Transaction.c                    |   11 +++++------
 src/register/register-gnome/gnucash-grid.c  |    2 +-
 src/register/register-gnome/gnucash-sheet.c |    2 +-
 12 files changed, 16 insertions(+), 24 deletions(-)

**************************tags.diff*************************
Subject: [patch 00/15] [tags.diff] Exclude emacs temp files from from etags table

 * Makefile.TAGS
   - exclude emacs temp files from etags table
   - wrap line

 Makefile.TAGS |    4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)

**************************account.diff*************************
Subject: [patch 00/15] [account.diff] Adding const to Account accessor function arguments

  * src/engine/Account.[ch]
  * src/app-utils/gnc-ui-util.c:
  * src/backend/file/io-example-aacount.c:
  * src/backend/file/io-gncxml-v2.c:
    - adding const to Account accessor function arguments


 src/app-utils/gnc-ui-util.c           |    4 ++--
 src/backend/file/io-example-account.c |    2 +-
 src/backend/file/io-gncxml-v2.c       |    4 ++--
 src/engine/Account.c                  |   10 +++++-----
 src/engine/Account.h                  |   10 +++++-----
 5 files changed, 15 insertions(+), 15 deletions(-)

**************************account-types.diff*************************
Subject: [patch 00/15] [account-types.diff] Improvements for GncTreeModelAccountTypes

       * src/gnome-utils/gnc-tree-model-account-types.[ch]:
         - add an api for accessing a program-wide static account-type tree
       model
         - add convenience functions for mapping between the selection
       state of a treeview using the static account-type tree model and a
       account-type selection bitfield.
         - lots of line wrap fixes


 src/gnome-utils/gnc-tree-model-account-types.c |  507 +++++++++++++++----------
 src/gnome-utils/gnc-tree-model-account-types.h |   56 ++
 2 files changed, 361 insertions(+), 202 deletions(-)

**************************gnc-tree-view-account.diff*************************
Subject: [patch 00/15] [gnc-tree-view-account.diff] Convert gnc-tree-view-account to use GObject

       * gnc-tree-view-account.c: 
         - convert gnc-tree-view-account to use GObject instead of GtkObject
         - line wrap fixes

 src/gnome-utils/gnc-tree-view-account.c |   65 ++++++++++++++++----------------
 1 files changed, 34 insertions(+), 31 deletions(-)

**************************misc.diff*************************
Subject: [patch 00/15] [misc.diff] Minor random code tweaks.

 * src/gnc-module/gnc-module.c: 
   - code factoring

 * src/engine/qofbook.c                             |   24 +++---
 * src/report/report-gnome/gnc-plugin-page-report.c |   10 +-
   - line-wrap fixes, minor code simplications, comments

 * src/app-utils/gnc-euro.c                         |    1 
 * src/app-utils/gnc-ui-util.h                      |    1 
 * src/gnome-utils/dialog-commodity.h               |    4 -
 * src/gnome-utils/gnc-currency-edit.c              |    1 
   - remove #include "gnc-engine.h"
   - comments

 * src/backend/file/gnc-account-xml-v2.c            |    9 --
   - Code simplification.

 src/app-utils/gnc-euro.c                         |    1 
 src/app-utils/gnc-ui-util.h                      |    1 
 src/backend/file/gnc-account-xml-v2.c            |    9 --
 src/engine/qofbook.c                             |   24 +++---
 src/gnc-module/gnc-module.c                      |   87 +++++++++++------------
 src/gnome-utils/dialog-commodity.h               |    4 -
 src/gnome-utils/gnc-currency-edit.c              |    1 
 src/report/report-gnome/gnc-plugin-page-report.c |   10 +-
 8 files changed, 65 insertions(+), 72 deletions(-)

**************************trace.diff*************************
Subject: [patch 00/15] [trace.diff] Swallow the semicolon on tracing macros

 * src/engine/gnc-trace.h                                 |   50 +++++++++--------
    - swallow the semicolon on the tracing macros

 * src/business/business-core/file/gnc-bill-term-xml-v2.c |    2 
 * src/business/business-core/file/gnc-tax-table-xml-v2.c |    2 
 * src/engine/Scrub.c                                     |    2 
 * src/engine/gnc-hooks.c                                 |    2 
    - make tracing macros end in semicolon

 src/business/business-core/file/gnc-bill-term-xml-v2.c |    2 
 src/business/business-core/file/gnc-tax-table-xml-v2.c |    2 
 src/engine/Scrub.c                                     |    2 
 src/engine/gnc-hooks.c                                 |    2 
 src/engine/gnc-trace.h                                 |   50 +++++++++--------
 src/import-export/import-backend.c                     |    4 -
 6 files changed, 33 insertions(+), 29 deletions(-)

**************************gnc-string-cache.diff*************************
Subject: [patch 00/15] [gnc-string-cache.diff] Privatization of the string GCache 

 * src/engine/gnc-engine-util.c                    |   57 ++++++++++++++++-----
 * src/engine/gnc-engine-util.h                    |   44 ++++++++++------
     - Previously, gnc-engine-util exposed direct access to the static
       GCache.  This makes debugging various uses (and misuses) very
       difficult.  Now, the static GCache itself is private, and all
       access is through gnc_string_cache_{remove,insert}().

 * src/app-utils/gnc-component-manager.c           |    8 +--
 * src/business/business-core/gncAddress.c         |    3 -
 * src/business/business-core/gncBillTerm.c        |    3 -
 * src/business/business-core/gncCustomer.c        |    3 -
 * src/business/business-core/gncEmployee.c        |    3 -
 * src/business/business-core/gncEntry.c           |    3 -
 * src/business/business-core/gncInvoice.c         |    3 -
 * src/business/business-core/gncJob.c             |    3 -
 * src/business/business-core/gncOrder.c           |    3 -
 * src/business/business-core/gncTaxTable.c        |    3 -
 * src/business/business-core/gncVendor.c          |    3 -
 * src/business/business-core/test/test-customer.c |   10 +--
 * src/business/business-core/test/test-employee.c |    4 -
 * src/business/business-core/test/test-job.c      |    2 
 * src/business/business-core/test/test-vendor.c   |    2 
 * src/engine/Transaction.c                        |   64 ++++++++++++------------
 * src/engine/gnc-commodity.c                      |   33 ++++--------
 * src/engine/gnc-engine.c                         |    2 
 * src/engine/gnc-pricedb.c                        |   16 ++----
 * src/engine/kvp_frame.c                          |   12 ++--
 * src/engine/qofid.c                              |    3 -
 * src/engine/qofquery-deserial.c                  |    6 --
 * src/engine/test/test-commodities.c              |   24 ++++-----
 * src/gnome-utils/QuickFill.c                     |   18 +-----
   - Convert all gcache users to use only public functions
   - consolidate CACHE_INSERT and CACHE_REMOVE macros into one place

 * src/engine/qofquery-deserial.c
   - annotate one possible bug discovered during the above


 
 src/app-utils/gnc-component-manager.c           |    8 +--
 src/business/business-core/gncAddress.c         |    3 -
 src/business/business-core/gncBillTerm.c        |    3 -
 src/business/business-core/gncCustomer.c        |    3 -
 src/business/business-core/gncEmployee.c        |    3 -
 src/business/business-core/gncEntry.c           |    3 -
 src/business/business-core/gncInvoice.c         |    3 -
 src/business/business-core/gncJob.c             |    3 -
 src/business/business-core/gncOrder.c           |    3 -
 src/business/business-core/gncTaxTable.c        |    3 -
 src/business/business-core/gncVendor.c          |    3 -
 src/business/business-core/test/test-customer.c |   10 +--
 src/business/business-core/test/test-employee.c |    4 -
 src/business/business-core/test/test-job.c      |    2 
 src/business/business-core/test/test-vendor.c   |    2 
 src/engine/Transaction.c                        |   64 ++++++++++++------------
 src/engine/gnc-commodity.c                      |   33 ++++--------
 src/engine/gnc-engine-util.c                    |   57 ++++++++++++++++-----
 src/engine/gnc-engine-util.h                    |   44 ++++++++++------
 src/engine/gnc-engine.c                         |    2 
 src/engine/gnc-pricedb.c                        |   16 ++----
 src/engine/kvp_frame.c                          |   12 ++--
 src/engine/qofid.c                              |    3 -
 src/engine/qofquery-deserial.c                  |    6 --
 src/engine/test/test-commodities.c              |   24 ++++-----
 src/gnome-utils/QuickFill.c                     |   18 +-----
 26 files changed, 153 insertions(+), 182 deletions(-)

**************************plugins.diff*************************
Subject: [patch 00/15] [plugins.diff] Minor tweaks to gnc-main-window.c

       * src/gnome-utils/gnc-main-window.c:
           - avoid trying to double-add plugins to plugin manager by
             delaying signal connection until the plugins are already
             managed by the plugin manager.
           - question the correctness of a comment

 src/gnome-utils/gnc-main-window.c |   15 ++++++++++-----
 1 files changed, 10 insertions(+), 5 deletions(-)

**************************comments.diff*************************
Subject: [patch 00/15] [comments.diff] A collection of miscellaneous comments

         - spelling corrections, line wrap fixes, whitespace changes
         - inline documentation
         - silence a texinfo warning
         - various _deeply_ insightful one-liners


 GNOME2_STATUS                                    |   49 +++++++++++++++++------
 HACKING                                          |    6 ++
 src/app-utils/config-var.scm                     |    2 
 src/app-utils/gnc-component-manager.h            |    3 -
 src/backend/file/gnc-schedxaction-xml-v2.c       |    1 
 src/backend/postgres/gncquery.c                  |    1 
 src/business/business-utils/business-options.scm |    2 
 src/doc/design/engine.texinfo                    |    6 +-
 src/doc/multicurrency-discussion.txt             |    6 --
 src/engine/Query.h                               |    2 
 src/engine/SX-book.c                             |    3 -
 src/engine/SchedXaction.c                        |    4 +
 src/engine/TransactionP.h                        |    4 -
 src/engine/gnc-numeric.h                         |    4 -
 src/engine/guid.c                                |    1 
 src/engine/qofbook.h                             |    3 -
 src/engine/qofclass.c                            |    2 
 src/engine/qofclass.h                            |    4 -
 src/engine/qofquery.c                            |    1 
 src/engine/qofquery.h                            |    8 ++-
 src/engine/qofsession.c                          |    5 +-
 src/experimental/cgi-bin/gnc-server.c            |    2 
 src/gnome-utils/dialog-utils.c                   |   13 +++++-
 src/gnome-utils/gnc-amount-edit.c                |    6 +-
 src/gnome-utils/gnc-amount-edit.h                |    8 +--
 src/gnome-utils/gnc-date-format.c                |    1 
 src/gnome-utils/gnc-plugin-manager.h             |    6 +-
 src/gnome-utils/gnc-plugin.h                     |    9 ++--
 src/gnome-utils/gnc-tree-model-account.c         |    7 +--
 src/gnome-utils/gnc-tree-model.c                 |    2 
 src/gnome/dialog-scheduledxaction.c              |    4 +
 src/gnome/dialog-sxsincelast.c                   |    3 +
 src/report/report-gnome/gw-report-gnome-spec.scm |    3 +
 src/report/report-gnome/report-gnome.scm         |    6 ++
 src/report/report-system/html-document.scm       |    2 
 src/report/report-system/html-table.scm          |    5 ++
 src/report/report-system/report-utilities.scm    |   25 +++++++----
 src/report/report-system/report.scm              |   49 +++++++++++++++--------
 38 files changed, 183 insertions(+), 85 deletions(-)

**************************freqspec.diff*************************
Subject: [patch 00/15] [freqspec.diff] Minor tweaks to FreqSpec

       * src/engine/FreqSpec.c: line-wrap fixes

       * src/enging/test/test-freq-spec.c: 
         - add a failing test case for FreqSpec

 src/engine/FreqSpec.c            |   12 +++++++-----
 src/engine/test/test-freq-spec.c |   23 ++++++++++++++++++++++-
 2 files changed, 29 insertions(+), 6 deletions(-)

**************************valgrind.diff*************************
Subject: [patch 00/15] [valgrind.diff] new valgrind suppression files

 * src/valgrind-gdk.supp:
 * src/valgrind-x22.supp:
  - add a couple lib specific suppression files for valgrind

 * src/valgrind-gnucash.supp:
  - add a bunch of general suppressions, too.  I don't think 
        any of these mask any bugs in gnucash.


 src/valgrind-gdk.supp     |   72 +++++++++++++++
 src/valgrind-gnucash.supp |  218 ++++++++++++++++++++++++++++++++++++++++++++++
 src/valgrind-x11.supp     |  125 ++++++++++++++++++++++++++
 3 files changed, 415 insertions(+)

**************************commodities.diff*************************
Subject: [patch 00/15] [commodities.diff] Minor fixes for commodity-utilities.scm

       * src/report/report-system/commodity-utilities.scm:
         - change the handling of invalid exchange functions
         - warn about dangerous usage of gnc:exchange-if-same

 src/report/report-system/commodity-utilities.scm |   62 +++++++++++++++--------
 1 files changed, 41 insertions(+), 21 deletions(-)

**************************html-acct-table.diff*************************
Subject: [patch 00/15] [html-acct-table.diff] Major tweaks for html-acct-table.scm

       * src/report/report-system/html-acct-table.scm:
         - Clarify some explanations, document some bugs
         - fix one use of price source where exchange-fn was needed
         - added lots of comments
         - factor out one small block of code


 src/report/report-system/html-acct-table.scm |  279 +++++++++++++++++++--------
 1 files changed, 199 insertions(+), 80 deletions(-)



More information about the gnucash-devel mailing list