[Gnucash-changes] Fix function name.

[Neil Williams]

On Wednesday 14 September 2005 3:01 pm, David Hampton wrote:
> On Wed, 2005-09-14 at 08:01 +0100, Neil Williams wrote:
> > On Wednesday 14 September 2005 7:11 am, David Hampton wrote:
> > > -const gchar *qof_date_format_get_format(QofDateFormat df)
> > > +const gchar *qof_date_text_format_get_string(QofDateFormat df)
> >
> > Should we just be changing the API like that?? This isn't a static.
> > http://qof.sourceforge.net/doxy/group__Date.html#ga22
> > (QOF is now on pre-release and I'd rather not change the API just now.)
> >
> > :-(
>
> Given that I was restoring the function to its original name, I thought
> it was appropriate.

?? GnuCash CVS shows this name in ALL G2 versions, Linas made the last change 
to that line at v1.3 when the file was still in MAIN.
Mon Jun 30 04:14:50 2003 UTC (2 years, 2 months ago) by linas
ChangeLog:
standardize some of the names of the date handling routines;
add routines to print time.

I can't find a record of the original name you quote.
Linas' change was:
const gchar *getDateTextFormatString(DateFormat df)   const gchar 
*qof_date_format_get_format(QofDateFormat df)

http://cvs.gnucash.org/cgi-bin/cvsweb.cgi/gnucash/src/engine/gnc-date.c.diff?r1=1.2;r2=1.3;f=h

Please, can you revert this change?

> Somewhere along the line the code was broken in the 
> g2 branch.

Not as far as I can tell.

> > Can you use a #define, David, and deprecate the old version so that we
> > don't break the build of a program using the current API?
>
> Did I break CashUtils?  I doubt it.

It would probably break GnoTime if I allowed your change into QOF.

> I doubt that there was any code 
> used this function, given that its sole existing documentation was the
> string "DOCUMENT ME!".

I can't say, Linas is still writing code for GnoTime and he didn't always 
document every function he used.

> Got any suggestions?

For now, all I can suggest is that you declare them locally where they are 
needed and if that results in a new file in src/gnome/ then that would become 
a suitable place for the other scan/print functions - ready for me to 
deprecate the QOF versions for v0.7.

> If a file-io backend needs date handling, and the UI needs date
> handling, shouldn't they share a common set of functions?

Because the backend should not use LOCALE time settings, backends need to use 
UTC.

> Isn't gnc- 
> date.c the appropriate existing shared file?

No. As the alert mentions, (written before I started), it is clearly NOT 
suitable.

-- 

Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20050915/7ee048e4/attachment.bin