[Gnucash-changes] r13723 - gnucash/trunk - Mike Alexander's patch to get currency quote retrieval working again,

[Mike Alexander]

--On April 1, 2006 5:30:35 PM -0500 David Hampton 
<hampton-gnucash at rainbolthampton.net> wrote:

> On Sat, 2006-04-01 at 12:01 -0500, Derek Atkins wrote:
>> David Hampton <hampton at cvs.gnucash.org> writes:
>>
>> >  	  com = xaccAccountGetCommodity(act);
>> >  	  if (com &&
>> > -	      !gnc_commodity_is_iso(com) &&
>> > +	      (!gnc_commodity_is_iso(com) || xaccAccountGetType(act) ==
>> > CURRENCY) && gnc_commodity_get_quote_flag(com)) {
>> >  	    if (!kvpnode)
>> >  	      kvpnode= xmlNewNode(NULL, BAD_CAST act_slots_string);
>>
>> I'm not sure about this hunk..  CURRENCY type accounts are
>> deprecated. There's got to be a better way to notice that we should
>> grab quotes for this commodity other than testing for a CURRENCY
>> type account.
>
> Working on it.  There's mostly finished code in svn to allow you to
> set the "Get Online Quotes" flag for currencies.  I have it working
> locally but haven't had the chance to commit yet.

Good.  I didn't much like that change either, but it's backwards 
compatible with 1.8 and I didn't feel qualified to fix it better.

-- 
Mike Alexander           mta at umich.edu
Ann Arbor, MI            PGP key ID: BEA343A6