AUDIT: r14591 - gnucash/trunk - Check for account type compatibility when creating a new account. Fixes

[Andreas Köhler]

Hi,

On Fr, 2006-08-04 at 21:17 -0400, Andreas Köhler wrote:
> Author: andi5
> Date: 2006-08-04 21:17:28 -0400 (Fri, 04 Aug 2006)
> New Revision: 14591
> Trac: http://svn.gnucash.org/trac/changeset/14591
> 
> Modified:
>    gnucash/trunk/ChangeLog
>    gnucash/trunk/src/gnome-utils/dialog-account.c
> Log:
> Check for account type compatibility when creating a new account. Fixes
> 344966.
> BP

http://bugzilla.gnome.org/show_bug.cgi?id=344966
makes me feel that there is more than one way to think about how to
handle account type incompatibilities in the create/edit account dialog.
Maybe I am plain wrong :)

= The chosen account type is authoritative =

"Either make me <T> or forget it". Seems to be the current behavior.
If you reparent an account, ask the user whether she is willing to
change the account type of all parents, their descendants and all
children to make them compatible with <T>.
r14591 adds the test for parent compatibility in the create account
dialog in this fashion (before you could create incompatible adjacent
accounts).

= The chosen account type is a hint =

"I would like to be <T>, but parents decision is OK too, will teach my
children then".
This is how I understand the request in comment #1.
If you create or edit an account and <T> is incompatible with the
parents type, suggest to adjust <T> (and the type of existing,
<T>-compatible children). Never change parents.

Maybe this has been discussed before, but what do you think? Which one
is more useful / intuitive?

-- andi5