[PATCH] Updated add/edit account window

[Chris Shoemaker]

On Wed, Feb 15, 2006 at 06:40:10PM +0100, Andreas Köhler wrote:
> Here is a patch that tries to replace the list store with a filtered
> GncTreeModelAccountTypes. If you do not want to go this way (do not
> think so), there are still two open bugs in my own code ;)

Just out of curiousity, were you referring to bugs in this patch?
Anyway...

> What it does:
> 
> * uses a filtered GncTreeModelAccountTypes with eigher
>   aw->valid_types or xaccAccountTypesValid | 1<< aw->type
> 
> * adds gnc_tree_model_account_types_get_iter_from_type to set an
>   iter to a specific type
> 
> * some minor changes, including one to
>   gnc_tree_model_account_types_get_flags
> 
> What do you think?

I just applied a rather extended version of this patch as r13271.
Take a look.  I think you'll see that it's much nicer to hide the
complex conversions of paths and iters between the filter model and
the child model _inside_ gnc-tree-model-account-types.c, where it has
to be considered anyway.

But, in the account dialog, this becomes as simple as using

GNCAccountType
gnc_tree_model_account_types_get_selection_single(GtkTreeSelection *sel);

and

void 
gnc_tree_model_account_types_set_selection(GtkTreeSelection *sel,
                                                guint32 selected);

Now, I didn't commit the
gnc_tree_model_account_types_get_iter_from_type(), but we should hold
on to the idea, because, if we decide to use a GtkComboBox, the
GtkTreeSelection functions won't help.  We'd need something very much
like gnc_tree_model_account_types_get_iter_from_type() [ and
...get_type_from_iter() ], _except_ they should work with the
_filter-model's_ iters, not the child model's iters.  The goal here is
that there be only one kind of account-types treemodel - the filtered
kind - so we want to hide the child model and _all_ its iters.

Thanks for the patch.

-chris