[Gnucash-changes] r13352 - gnucash/trunk - Fix "default limit" QOF eventing stuff; thanks Andi.

[Derek Atkins]

Quoting Neil Williams <linux at codehelp.co.uk>:

> On Tuesday 21 February 2006 11:10 pm, Joshua Sled wrote:
>> Author: jsled
>> +	* lib/libqof/qof/qofevent.[ch] (QOF_DEFAULT_EVENT_LIMIT): rename, set
>> +	to reasonable value (the last-defined event).
>
>> Modified: gnucash/trunk/lib/libqof/qof/qofevent.h
>> ===================================================================
>> --- gnucash/trunk/lib/libqof/qof/qofevent.h	2006-02-21 21:46:07 UTC (rev
>> 13351) +++ gnucash/trunk/lib/libqof/qof/qofevent.h	2006-02-21 23:10:33 UTC
>> (rev 13352) @@ -50,11 +50,12 @@
>>  #define QOF_EVENT_REMOVE   (1 << 4)
>> +#define QOF_EVENT__LAST    QOF_EVENT_REMOVE
>>  #define QOF_EVENT_ALL      (0xff)
>
> (do we need QOF_EVENT_ALL ?)

Yes, I think we do.

>>  /** Allow scope for more defaults in future. Additional
>>  event identifiers must be larger than this. */
>> -#define QOF_DEFAULT_LIMIT  10
>> +#define QOF_DEFAULT_EVENT_LIMIT  QOF_EVENT__LAST
>
> Josh - why was this a bug? What was wrong with a gap?
>
> Supplementary events will now have to be based on QOF_DEFAULT_LIMIT + 
> n rather
> than just something bigger than 10?

I don't have an issue with a gap.  I'm not 100% sure why Josh made this
particular change.

> I thought nobody wanted to iterate over event identifiers?

I'm not sure where iteration comes into this.  The key is being able
to use bitmasks to figure out what event this is.

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available