Error making pot file.

Christian Stimming stimming at tuhh.de
Wed Jan 4 16:30:30 EST 2006


Am Mittwoch, 4. Januar 2006 21:06 schrieb Neil Williams:
> On Wednesday 04 January 2006 10:23 am, Christian Stimming wrote:
> > Neil Williams schrieb:
> > >>Does anyone know why we version-control this generated file?
> > >
> > > AFAICT, we can remove po/POTFILES.in
> >
> > No, please don't remove it.
>
> > The reason why we version-control this
> > generated file is because the Makefile in that directory is not under
> > our control
>
> Wrong, Christian, sorry. po/POTFILES.in is solely under our control and
> always was. It does not have to be generated by the Makefile in po/ (which
> we do not control), it can (and is) made by the Makefile in the directory
> above.

Okay. Now after testing this I agree that auto-generation of po/POTFILES.in is 
possible. It is possible because and only because we can rely that "make" in 
the po/ directory is either run by a "make" in the top-level directory (and 
SUBDIRS in top-level Makefile.am contains "." first), or if a translator only 
wants the pot file updated then it will be run by "make pot". I agree that we 
can provide automatic rules for both cases, so the build won't be broken by 
this. 

The build will be broken for the hypothetical case that someone unpacks a 
tarballs or the autogen.sh'ed SVN, doesn't run make in the top-level 
directory but instead in the po/ subdirectory. It is okay to break this 
(seemingly absurd) use of make.

Therefore I agree that po/POTFILES.in should be removed from SVN altogether.

HOWEVER, what I still don't see is how your change actually solves the 
original problem: A file somewhere in the tree was deleted and POTFILES.in 
wasn't updated. How is your solution going to fix this? Currently I can't see 
how POTFILES.in will be regenerated for that.

> I would like r12257 reverted.

Okay so far.

Christian


More information about the gnucash-devel mailing list