[Gnucash-changes] r12341 - gnucash/trunk - Using Derek's build-from-tree fix to fix the test-version check

[Derek Atkins]

Neil Williams <linux at codehelp.co.uk> writes:

> On Friday 13 January 2006 7:22 pm, Derek Atkins wrote:
>> Quoting Neil Williams <codehelp at cvs.gnucash.org>:
>> > --- gnucash/trunk/src/bin/test/test-version	2006-01-13 17:41:53 UTC
>> > (rev 12340)
>> > +++ gnucash/trunk/src/bin/test/test-version	2006-01-13 19:12:12 UTC
>> > (rev 12341)
>> > @@ -1,3 +1,5 @@
>> > #!/bin/sh
>> > +PATH="../overrides/:$PATH"
>> > +export PATH
>> >
>> > -exec ../gnucash --version
>> > +exec gnucash-build-env gnucash --version
>>
>> I'm not sure this works..  Did you test this before you committed it?
>
> Yes. make uninstall first, then tested src/bin/test-version and ran make 
> check.

> It certainly did not work before the change - and using only
> gnucash-build-env or just the PATH didn't work either.

That doesn't mean that this is the correct fix.  For example, I suspect
it would also work if you ran:

  exec ../overrides/gnucash-build-env ../gnucash --version

Without setting the PATH at all.  Another option is:

  exec ../overrides/gnucash-build-env  ../gnucash-bin --version

>> It's going to call gnucash-env which is going to override the settings
>> that gnucash-build-env sets.
>
> It doesn't seem to and it does work.

Have you tested this?  I mean, have you tested whether it's calling
gnucash-build-env?  It might work.. I don't know.  It just feels
wrong.

-derek
-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available