[Gnucash-changes] r12341 - gnucash/trunk - Using Derek's build-from-tree fix to fix the test-version check

[Derek Atkins]

Quoting Neil Williams <linux at codehelp.co.uk>:

> On Friday 13 January 2006 8:43 pm, Derek Atkins wrote:
>> it would also work if you ran:
>>
>>   exec ../overrides/gnucash-build-env ../gnucash --version
>
> /opt/svn/gnucash/src/bin/test/../gnucash: line 29: exec: gnucash-bin: not
> found

Okay, that's not surprising.  src/bin/gnucash doesn't know where to find
src/bin/gnucash-bin because src/bin isn't in the PATH.   That makes sense.

>> Without setting the PATH at all.  Another option is:
>>
>>   exec ../overrides/gnucash-build-env  ../gnucash-bin --version
>
> ** (lt-gnucash-bin:27683): WARNING **: Failed to dlopen()
> '/opt/svn/gnucash/src/bin/overrides/../../../src/business/dialog-tax-table/libgncmod-dialog-tax-table.la':
> /opt/svn/gnucash/src/bin/overrides/../../../src/business/dialog-tax-table/libgncmod-dialog-tax-table.so.0:
> cannot open shared object file: No such file or directory
>
> GnuCash 1.9.0 development version
>
> Ugly, but yes, it does work. Leaves a worry that it's not being called
> correctly. (It's even worse if you don't also export GUILE_DEPRECATED=no).

Indeed, this seems to imply that we're missing the dialog-tax-table
configuration.   I wonder why I didn't notice this in my tests here.
I just tried this here and I don't get this problem.

> Why? gnucash-build-env is the right script to call to run from the build tree
> and it is the copy of the script gnucash in overrides that is being run - the
> same script trying to call gnucash-bin fails:
> /opt/svn/gnucash/src/bin/test/../overrides/gnucash-build-env: line 78: exec:
> gnucash-bin: not found

If feels wrong using src/bin/overrides/gnucash.  It feels wrong adding
it to the path.  It feels wrong getting src/bin/overrides/gnucash-env
called at all.  And yes, it WILL be called if you call
src/bin/overrides/gnucash.  Take a look at the script:

#!/bin/sh
exec gnucash-env guile -e main -s "$0" "$@"

Honestly, IMNSHO this script (src/bin/overrides/gnucash) should just be
removed now that we have gnucash-bin.

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available