[PATCH] Updated add/edit account window

Chris Shoemaker c.shoemaker at cox.net
Mon Jan 16 11:25:07 EST 2006


On Mon, Jan 16, 2006 at 04:49:32PM +0100, Eskil Bylund wrote:
> Hi,
> 
> Here's a patch that updates the add/edit account window. Changes are:
> 
>  * src/gnome/glade/account.glade
>  * src/gnome-utils/dialog-account.c: Clean up the Account dialog.
> Replace the account type clist with a GtkComboBox. 

Hello Eskil,

  Instead of creating and populating a GtkListStore for the Account
types, could you please use the pre-made GtkTreeModel offered by
gnc-tree-model-account-types.[ch]?  (Preferrably "Method 1".)  That
way, you don't have to worry about life-cycle issues for the
ListStore.  You can still use the GtkComboBox and if you need
convenience routines for managing the account-type selection state of
the combo box, then it's okay to add them to
gnc-tree-model-account-types.

> Update the title
> when changing parent account.
> 
> By the way. The GnomeDateEdit in the opening balance notebook allows
> one to set not only the date but also the time. Is this time ever
> used? If not, the GnomeDateEdit should be set to only display the
> date.

I think it's not used and I agree.  If you submit a patch for this,
please make it separate from other issues.

Thanks for hacking!

-chris


More information about the gnucash-devel mailing list